New issue
Advanced search Search tips

Issue 668583 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug

Blocking:
issue 667575



Sign in to add a comment

fast/dom/HTMLAnchorElement/anchor-ismap-crash.html doesn't completely work

Project Member Reported by xiaoche...@chromium.org, Nov 25 2016

Issue description

The test currently works fine, but fails if the test script is run with clean style. For example, if we force style update before test script, if fails:

<!DOCTYPE html>
<body>
<script src="../../../resources/js-test.js"></script> 
<a href="javascript:">foo<img ismap style="content:'bar'; display:block;"></a>
<script>
document.body.offsetHeight;
document.getElementsByTagName('img')[0].click();
testPassed('if not crashed.');
</script>
</body>

It throws:

CONSOLE ERROR: line 1: Uncaught SyntaxError: Unexpected token ?

We can also repro the same error by loading the layout test in browser, wait until load and then run document.querySelector('img').click()

The bug repros in stable.
 
Working on this issue.
Status: ExternalDependency (was: Available)
Marking as ExternalDependency, as this seems to be a spec bug: https://github.com/whatwg/html/issues/3103
Status: Available (was: ExternalDependency)
As discussed in https://github.com/whatwg/html/issues/3103, it's better not to create a special case.

The correct fix is to rebaseline the test when needed.
Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f86bab7b4ac656b682431cb9fe65ca9897742ee

commit 7f86bab7b4ac656b682431cb9fe65ca9897742ee
Author: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Date: Thu Oct 12 06:30:31 2017

Modified anchor-ismap-crash layout test case with test-harness and more accurate

This CL contains:
1. Convert fast/dom/HTMLAnchorElement/anchor-ismap-crash.html with test-harness
2. Defer test code to after 'load' event to make the test behavior more natural

Bug:  668583 
Change-Id: I4a673459ea028fa188799c841d938b3b5a11ecda
Reviewed-on: https://chromium-review.googlesource.com/704618
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508268}
[delete] https://crrev.com/4b215935dccf392557df907d8eb68f06edc1a227/third_party/WebKit/LayoutTests/fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt
[modify] https://crrev.com/7f86bab7b4ac656b682431cb9fe65ca9897742ee/third_party/WebKit/LayoutTests/fast/dom/HTMLAnchorElement/anchor-ismap-crash.html

Status: Fixed (was: Available)
Thanks to bhagirathi.s@ for working on this!

Sign in to add a comment