New issue
Advanced search Search tips

Issue 668578 link

Starred by 2 users
Status: Assigned
Owner:
bashi@chromium.org
Cc:
drott@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Make FontCache throttleable

Project Member Reported by bashi@chromium.org, Nov 25 2016 
Memory coordinator dispatches "throttled" notification when free memory becomes somewhat low. It would be great to provide a way to throttle # of inactive font objects in font caches.

The current ownership / relationship of font objects (SimpleFontData, PlatformFontData, HarfBuzzFace etc) are very confusing. We might want to untangle them before making FontCache throtteable.

Also, we need to have measures to see the reduction impacts (and performance impacts).
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 25 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c33cef3224fde184a75ca9f79adc1a2f56ac3c14

commit c33cef3224fde184a75ca9f79adc1a2f56ac3c14
Author: bashi <bashi@chromium.org>
Date: Fri Nov 25 12:30:17 2016

Report decoded webfont blob size to memory-infra

Decoded webfonts are stored as SkData, and its backing store is malloc.
(See WebFontDecoder::decode() for the implementation)
Report them as a part of web_cache because FontResource is the owner
of FontCustomPlatformData, which retains a reference to SkTypeface and
SkData.

BUG=668578

Review-Url: https://codereview.chromium.org/2533503002
Cr-Commit-Position: refs/heads/master@{#434486}

[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/core/fetch/FontResource.cpp
[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/core/fetch/FontResource.h
[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.cpp
[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/platform/fonts/FontCustomPlatformData.h
[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/platform/fonts/WebFontDecoder.cpp
[modify] https://crrev.com/c33cef3224fde184a75ca9f79adc1a2f56ac3c14/third_party/WebKit/Source/platform/fonts/WebFontDecoder.h
►

Sign in to add a comment