New issue
Advanced search Search tips

Issue 668571 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

with `build all` on Mac: ld: framework not found CoreMidi

Project Member Reported by tapted@chromium.org, Nov 25 2016

Issue description

Chrome Version       : 56.0.2914.3
OS Version: OS X 10.12.1

I think it needs to be CoreMIDI not CoreMidi

CoreMidi was added a while ago in r392969

$ build all
[1/276] LINK ./midi_unittests
FAILED: midi_unittests
export DEVELOPER_DIR=/Volumes/bdd/tapted/git/chromium/src/build/mac_files/Xcode.app;  TOOL_VERSION=1478048412 ../../build/toolchain/mac/linker_driver.py ../../third_party/llvm-build/Release+Asserts/bin/clang++  -stdlib=libc++ -arch x86_64 -isysroot /Volumes/bdd/tapted/git/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -Wl,-ObjC -Wl,-rpath,@loader_path/. -Wl,-rpath,@loader_path/../../.. -Wl,-pie -o "./midi_unittests" -Wl,-filelist,"./midi_unittests.rsp" ./libmidi.dylib ./libbase.dylib ./libbase_i18n.dylib ./libicui18n.dylib ./libicuuc.dylib -framework CoreMidi -framework AppKit
ld: framework not found CoreMidi
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['../../third_party/llvm-build/Release+Asserts/bin/clang++', '-stdlib=libc++', '-arch', 'x86_64', '-isysroot', '/Volumes/bdd/tapted/git/chromium/src/build/mac_files/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk', '-mmacosx-version-min=10.9', '-Wl,-ObjC', '-Wl,-rpath,@loader_path/.', '-Wl,-rpath,@loader_path/../../..', '-Wl,-pie', '-o', './midi_unittests', '-Wl,-filelist,./midi_unittests.rsp', './libmidi.dylib', './libbase.dylib', './libbase_i18n.dylib', './libicui18n.dylib', './libicuuc.dylib', '-framework', 'CoreMidi', '-framework', 'AppKit']' returned non-zero exit status 1
[194/198] STAMP obj/chrome/test/unit_tests_run.stamp
ninja: build stopped: cannot make progress due to previous errors.
 
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7758f1009343fcb9d79eafc514ac2f86956c023b

commit 7758f1009343fcb9d79eafc514ac2f86956c023b
Author: tapted <tapted@chromium.org>
Date: Mon Nov 28 09:22:34 2016

Mac: Fix case of CoreMIDI.framework when building midi_unittests.

It's currently CoreMidi, which causes a failure on `build all` when on a
case-sensitive filesystem.

BUG= 668571 
R=toyoshim@chromium.org

Review-Url: https://codereview.chromium.org/2535443002
Cr-Commit-Position: refs/heads/master@{#434623}

[modify] https://crrev.com/7758f1009343fcb9d79eafc514ac2f86956c023b/media/midi/BUILD.gn

Comment 3 by tapted@chromium.org, Nov 28 2016

Status: Fixed (was: Started)

Sign in to add a comment