ThreadSafeInterfacePtr doesn't support sync messages |
|||||
Issue descriptionSync calls fail rather than waiting for a response.
,
Nov 30 2016
,
Jan 18 2017
,
Mar 30 2017
,
Mar 31 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1 commit 0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1 Author: watk <watk@chromium.org> Date: Fri Mar 31 03:37:02 2017 mojo: Support sync calls through ThreadSafeInterfacePtr Previously ThreadSafeInterfacePtr only supported async calls. Now it also supports sync calls. The one caveat to be aware of is that sync calls will block both the calling thread and the thread that the underlying InterfacePtr is bound to. That means, e.g., that the InterfacePtr can't be bound to the IO thread. Letting the call be async on the InterfacePtr thread is left as a TODO. BUG= 668565 Review-Url: https://codereview.chromium.org/2770153003 Cr-Commit-Position: refs/heads/master@{#461016} [modify] https://crrev.com/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1/mojo/public/cpp/bindings/tests/sync_method_unittest.cc [modify] https://crrev.com/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1/mojo/public/cpp/bindings/thread_safe_interface_ptr.h
,
Apr 24 2017
This is done. I filed a new bug to address the final TODO: http://crbug.com/714807 |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ajha@chromium.org
, Nov 30 2016