New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668565 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ThreadSafeInterfacePtr doesn't support sync messages

Project Member Reported by sa...@chromium.org, Nov 25 2016

Issue description

Sync calls fail rather than waiting for a response.
 

Comment 1 by ajha@chromium.org, Nov 30 2016

Labels: M-57
Labelling this with M-57, please adjust the milestone if not proper.

Thank you!
Cc: penghuang@chromium.org dcheng@chromium.org

Comment 3 by yzshen@chromium.org, Jan 18 2017

Cc: blundell@chromium.org yzshen@chromium.org
Components: Internals>Mojo>Bindings

Comment 4 by w...@chromium.org, Mar 30 2017

Owner: w...@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1

commit 0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1
Author: watk <watk@chromium.org>
Date: Fri Mar 31 03:37:02 2017

mojo: Support sync calls through ThreadSafeInterfacePtr

Previously ThreadSafeInterfacePtr only supported async calls. Now it
also supports sync calls.

The one caveat to be aware of is that sync calls will block both the
calling thread and the thread that the underlying InterfacePtr is bound
to. That means, e.g., that the InterfacePtr can't be bound to the IO
thread. Letting the call be async on the InterfacePtr thread is left as
a TODO.

BUG= 668565 

Review-Url: https://codereview.chromium.org/2770153003
Cr-Commit-Position: refs/heads/master@{#461016}

[modify] https://crrev.com/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1/mojo/public/cpp/bindings/tests/sync_method_unittest.cc
[modify] https://crrev.com/0c3ac0678cbc511f793dfd7386729b1b2ae2e7e1/mojo/public/cpp/bindings/thread_safe_interface_ptr.h

Comment 6 by w...@chromium.org, Apr 24 2017

Status: Fixed (was: Started)
This is done. I filed a new bug to address the final TODO: http://crbug.com/714807

Sign in to add a comment