Testing createImageBitmap color space conversion in a layout test |
|||||||||||
Issue descriptionCurrently we cannot test the color space conversion attribute passed to the createImageBitmap in a layout test. This affects the layout tests that were created without passing this parameter, for which now "default" color space conversion is assumed. Examples can be seen in codereview.chromium.org/2522693002 -> tex-image-and-sub-image-image-bitmap-utils.js -> runTestOnBindingTarget(). If we decide that there is no way to test this in a layout test, these tests must be removed from this script and all the layout tests in fast/canvas/webgl/texImage-imageBitmap-*.html.
,
Dec 5 2016
By putting the new behavior of "default" color space conversion mode behind a flag in codereview.chromium.org/2522693002 the previous layout tests do not fail anymore. However this bug is still open as the requirement for layout tests for createImageBitmap is still valid.
,
Mar 29 2017
,
Sep 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af0188902ff0dada4e69be68c4c057717c36a2b1 commit af0188902ff0dada4e69be68c4c057717c36a2b1 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Wed Sep 06 16:19:30 2017 Add layout tests for color managed createImageBitmap Along with some corrections in the color management code path, this change adds three layout tests to test createImageBitmap in linear-rgb, p3 and rec2020 color spaces from different sources in different color spaces. The test coverage is not complete as some sources (image, video, svg) are not decodable in non-srgb color spaces for now. Furthermore, color correcting OffscreenCanvas works fine in software code path, but fails in accelerated code path ( crbug.com/761424 ). Bug: 668547 , 754713 Change-Id: I5bbc23e00d8886c1c34e171101036195dd4a4e5c Reviewed-on: https://chromium-review.googlesource.com/646508 Reviewed-by: Justin Novosad <junov@chromium.org> Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#499983} [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-createImageBitmap-p3.html [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/resources/pattern-srgb-fullcolor.ogv [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/resources/pattern-srgb-transparent.png [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/resources/pattern-srgb.png [add] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/LayoutTests/virtual/color_space/fast/canvas/color-space/resources/pattern-srgb.svg [modify] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/Source/core/html/ImageData.cpp [modify] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/Source/core/imagebitmap/ImageBitmap.cpp [modify] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/Source/core/imagebitmap/ImageBitmapTest.cpp [modify] https://crrev.com/af0188902ff0dada4e69be68c4c057717c36a2b1/third_party/WebKit/Source/core/offscreencanvas/OffscreenCanvas.cpp
,
Sep 7 2017
Update: after the above CL, we have test coverage for createImageBitmap from these wide color gamut sources: HTMLCanvasElement, ImageData, ImageBitmap, OffscreenCanvas (unaccelerated path) For these sources, we still miss the test coverage for createImageBitmap from WCG sources: HTMLImageElement, HTMLVideoElement, Blob
,
Oct 25 2017
,
Nov 27 2017
,
Mar 7 2018
,
May 17 2018
Not sure what we should do for the video, probably will ask hubbe@. Blob and HTMLImageElement should be doable now.
,
May 17 2018
Ah, toBlob() is now converting to sRGB. After we landed convertToBlob() ( crbug.com/840372 ), we can fix this.
,
May 17 2018
,
Jul 25
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e4b4531efe35877fd19d94c23f513002c19722a9 commit e4b4531efe35877fd19d94c23f513002c19722a9 Author: Reza.Zakerinasab <zakerinasab@chromium.org> Date: Thu Oct 11 13:16:22 2018 Add CreateImageBitmap colorSpaceConversion tests from color managed Blob Bug: 668547 Change-Id: Iaba2654ae8f3940a803eede41b940f811e52c9ba Reviewed-on: https://chromium-review.googlesource.com/c/1273990 Reviewed-by: Fernando Serboncini <fserb@chromium.org> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org> Cr-Commit-Position: refs/heads/master@{#598738} [modify] https://crrev.com/e4b4531efe35877fd19d94c23f513002c19722a9/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-linear-rgb.html [modify] https://crrev.com/e4b4531efe35877fd19d94c23f513002c19722a9/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-p3.html [modify] https://crrev.com/e4b4531efe35877fd19d94c23f513002c19722a9/third_party/WebKit/LayoutTests/fast/canvas/color-space/canvas-createImageBitmap-rec2020.html
,
Oct 11
|
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by zakerinasab@chromium.org
, Dec 2 2016