Correct createImageBitmap default color space conversion behavior |
||||
Issue descriptionIn codereview.chromium.org/2522693002 -> ImageBitmap.cpp -> parseOptions the color space for "default" color space conversion in createImageBitmap is set to sRGB. It must be set to ImageDecoder::globalTargetColorSpace() when the crash problem on Mac is fixed for this API (part of crbug.com/667420 ).
,
Dec 22 2016
To be more clear, the "default" must be mapped to sRGB when color correct rendering is enabled, and to display color profile otherwise.
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73af4f477cdc6b962b8fd069353ea8df80af8491 commit 73af4f477cdc6b962b8fd069353ea8df80af8491 Author: zakerinasab <zakerinasab@chromium.org> Date: Thu Jan 05 17:19:30 2017 Correct the behavior of createImageBitmap's "default" color space conversion In ImageBitmap.cpp -> parseOptions, when color correct rendering is disabled, the destination color space for "default" color space conversion in createImageBitmap is set to sRGB. It must be set to display color profile. BUG= 668546 Review-Url: https://codereview.chromium.org/2595833003 Cr-Commit-Position: refs/heads/master@{#441683} [modify] https://crrev.com/73af4f477cdc6b962b8fd069353ea8df80af8491/third_party/WebKit/Source/core/frame/ImageBitmap.cpp [modify] https://crrev.com/73af4f477cdc6b962b8fd069353ea8df80af8491/third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp [modify] https://crrev.com/73af4f477cdc6b962b8fd069353ea8df80af8491/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp
,
Jan 24 2017
,
Nov 27 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by zakerinasab@chromium.org
, Dec 2 2016