New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668542 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Look into Chrome.Browser.CrashedExecutionPhase

Project Member Reported by manzagop@chromium.org, Nov 24 2016

Issue description

Chrome.Browser.CrashedExecutionPhase sounds like it could be useful, but it's not providing much signal. Look into it.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c14de297e7610734444f2bbc99141810e8e7b44

commit 7c14de297e7610734444f2bbc99141810e8e7b44
Author: manzagop <manzagop@chromium.org>
Date: Fri Nov 25 16:19:34 2016

MetricsService: ensure in-memory/pref execution phase are in sync

Background: MetricsService contains an |execution_phase_| which is mirrored to prefs::kStabilityExecutionPhase. In some cases, the mirroring doesn't happen.

- Mobile
In OnAppEnterBackground we call MarkAppCleanShutdownAndCommit which stores SHUTDOWN_COMPLETE to the pref but leaves |execution_phase_| unchanged. That seems ok. However, we restore the pref back to |execution_phase_| in OnAppEnterForeground. This CL does so.

- LogCleanShutdown
Now also updates MetricsService::execution_phase_ (in addition to
the pref) by calling MetricsService::SetExecutionPhase

- ClearSavedStabilityMetrics now sets the pref to
|execution_phase_| instead of UNINITIALIZED_PHASE.
It equivalent right now, but it seems more correct.

BUG=668542

Review-Url: https://codereview.chromium.org/2528033003
Cr-Commit-Position: refs/heads/master@{#434518}

[modify] https://crrev.com/7c14de297e7610734444f2bbc99141810e8e7b44/components/metrics/metrics_service.cc
[modify] https://crrev.com/7c14de297e7610734444f2bbc99141810e8e7b44/tools/metrics/histograms/histograms.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5f74dbb3ccdc02be372cec383f3accd6b240f41

commit b5f74dbb3ccdc02be372cec383f3accd6b240f41
Author: manzagop <manzagop@chromium.org>
Date: Mon Nov 28 18:05:52 2016

Stability execution phase: register shutdown timebomb state in quick exit path

The SHUTDOWN_TIMEBOMB_ARM execution phase was not set on the quick exit path
(SessionEnding).

BUG=668542

Review-Url: https://codereview.chromium.org/2527373003
Cr-Commit-Position: refs/heads/master@{#434689}

[modify] https://crrev.com/b5f74dbb3ccdc02be372cec383f3accd6b240f41/chrome/browser/lifetime/application_lifetime.cc

Cc: manzagop@chromium.org
Owner: ----
Status: Available (was: Assigned)
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 2

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment