New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668541 link

Starred by 5 users
Status: Fixed
Owner:
█ bshe@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
mthiesse@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR

Blocked on:
issue 670813
issue 673528
issue 682471
issue 706033
issue 706629
issue 728148


Sign in to add a comment

Improve WebVR/VR Shell DON transition smoothness

Project Member Reported by mthiesse@chromium.org, Nov 24 2016 
Currently we jump back and forth between stereo/non-stereo rendering on transition, and could be doing a lot better.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/27fd48978b4e4b24ce8e017cdc3036375f911a45

commit 27fd48978b4e4b24ce8e017cdc3036375f911a45
Author: mthiesse <mthiesse@chromium.org>
Date: Tue Nov 29 16:35:08 2016

Clean up VR Shell mode transitions (and fix potential webvr startup race).

BUG= 668541 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2536873002
Cr-Commit-Position: refs/heads/master@{#435010}

[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShell.java
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/android/vr_shell/ui_interface.cc
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/android/vr_shell/ui_interface.h
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/android/vr_shell/vr_web_contents_observer.cc
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/resources/vr_shell/vr_shell_ui.js
[modify] https://crrev.com/27fd48978b4e4b24ce8e017cdc3036375f911a45/chrome/browser/resources/vr_shell/vr_shell_ui_api.js

Comment 2 by mthiesse@chromium.org, Nov 30 2016 

Issue 669743 has been merged into this issue.

Comment 3 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 4 by ddorwin@chromium.org, Dec 5 2016

Labels: -VR-Fishfood VR-FF

Comment 5 by sko...@chromium.org, Dec 5 2016

Labels: -Pri-1 Pri-2

Comment 6 by sko...@chromium.org, Jan 5 2017 

Michael, is there more work to be done here?

Comment 7 by mthiesse@chromium.org, Jan 5 2017 

Issue 674008 has been merged into this issue.

Comment 8 by mthiesse@chromium.org, Jan 5 2017 

Yes, lots of work.

Comment 9 by ddorwin@chromium.org, Jan 7 2017

Labels: -M-57

Comment 10 by sko...@chromium.org, Jan 19 2017

Blockedon: 682471

Comment 11 by mthiesse@chromium.org, Jan 19 2017

Cc: mthiesse@chromium.org
Owner: ----
Status: Available (was: Assigned)

Comment 12 by sko...@chromium.org, Feb 2 2017

Labels: -VR-FF VR-DF

Comment 13 by bshe@chromium.org, Mar 27 2017

Owner: bshe@chromium.org
Status: Assigned (was: Available)

Comment 14 by bshe@chromium.org, Mar 29 2017

Blockedon: 706033 670813 673528
Making this the main bug to track transition weirdness

Comment 15 by bshe@chromium.org, Mar 29 2017

Blockedon: 706629

Comment 16 by mthiesse@chromium.org, May 31 2017

Blockedon: 728148

Comment 17 by mthiesse@chromium.org, Jun 13 2017

Status: Fixed (was: Assigned)
I think we can consider this fixed. We no longer show 2D UI entering VR or going to DD home.
►

Sign in to add a comment