New issue
Advanced search Search tips

Issue 668539 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"SSLErrorClassificationTest.GetClockState" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 24 2016

Issue description

"SSLErrorClassificationTest.GetClockState" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihTU0xFcnJvckNsYXNzaWZpY2F0aW9uVGVzdC5HZXRDbG9ja1N0YXRlDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d7985e4f3fdc371708db3f4c47a093577d27a02

commit 1d7985e4f3fdc371708db3f4c47a093577d27a02
Author: magjed <magjed@chromium.org>
Date: Fri Nov 25 13:54:40 2016

Disable SSLErrorClassificationTest.GetClockState test

This test is flaky. See bug for more info.

BUG= 668539 
NOTRY=True
TBR=estark

Review-Url: https://codereview.chromium.org/2532623003
Cr-Commit-Position: refs/heads/master@{#434492}

[modify] https://crrev.com/1d7985e4f3fdc371708db3f4c47a093577d27a02/components/ssl_errors/error_classification_unittest.cc

Comment 2 by magjed@chromium.org, Nov 25 2016

Owner: est...@chromium.org

Comment 3 by magjed@chromium.org, Nov 25 2016

Labels: -Sheriff-Chromium
Project Member

Comment 4 by chromium...@appspot.gserviceaccount.com, Nov 25 2016

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "SSLErrorClassificationTest.GetClockState". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyMwsSBUZsYWtlIihTU0xFcnJvckNsYXNzaWZpY2F0aW9uVGVzdC5HZXRDbG9ja1N0YXRlDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).

Comment 5 by magjed@chromium.org, Nov 28 2016

Labels: -Sheriff-Chromium
The test is already disabled, removing sheriff label.

Comment 6 by est...@chromium.org, Nov 28 2016

Components: UI>Browser>Interstitials
Labels: Team-Security-UX M-57
Status: Assigned (was: Untriaged)
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e544a08ab677f679c3f5b0c74112140e2f0b8d4

commit 5e544a08ab677f679c3f5b0c74112140e2f0b8d4
Author: estark <estark@chromium.org>
Date: Tue Nov 29 02:22:42 2016

Fix flaky GetClockState test

Setting the testing build time ensures that the test passes even if the
system clock is incorrect when running the test.

BUG= 668539 

Review-Url: https://codereview.chromium.org/2532273003
Cr-Commit-Position: refs/heads/master@{#434835}

[modify] https://crrev.com/5e544a08ab677f679c3f5b0c74112140e2f0b8d4/components/ssl_errors/error_classification_unittest.cc

Comment 8 by est...@chromium.org, Nov 29 2016

Status: Fixed (was: Assigned)
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6da1461c10818dd99c0a08709bb4e7eee6df94a

commit f6da1461c10818dd99c0a08709bb4e7eee6df94a
Author: battre <battre@chromium.org>
Date: Thu Dec 01 08:41:40 2016

Fix flakiness in SSLErrorHandlerDateInvalidTest tests

Setting the testing build time ensures that the test passes even if the
system clock is incorrect when running the test.

BUG=666821, 668539 

Review-Url: https://codereview.chromium.org/2546433002
Cr-Commit-Position: refs/heads/master@{#435584}

[modify] https://crrev.com/f6da1461c10818dd99c0a08709bb4e7eee6df94a/chrome/browser/ssl/ssl_error_handler_unittest.cc

Sign in to add a comment