New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668518 link

Starred by 2 users
Status: Fixed
Owner:
█ asimjour@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Controller click events not firing ~half of the time in VR Shell

Project Member Reported by mthiesse@chromium.org, Nov 24 2016 
It looks like scrolling might be taking priority over click events? Either way, clicks should always fire.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7f51e89599e3a75c42ad82d1d65b815fd6be3e96

commit 7f51e89599e3a75c42ad82d1d65b815fd6be3e96
Author: asimjour <asimjour@chromium.org>
Date: Tue Nov 29 19:14:03 2016

VR: Fix click during scrolling

Now we can click while scrolling. The scrolling stops and Tap is sent.

BUG= 668518 

Review-Url: https://codereview.chromium.org/2533493002
Cr-Commit-Position: refs/heads/master@{#435051}

[modify] https://crrev.com/7f51e89599e3a75c42ad82d1d65b815fd6be3e96/chrome/browser/android/vr_shell/vr_controller.cc
[modify] https://crrev.com/7f51e89599e3a75c42ad82d1d65b815fd6be3e96/chrome/browser/android/vr_shell/vr_shell.cc

Comment 2 by ddorwin@chromium.org, Nov 30 2016

Labels: Proj-VR-Daydream

Comment 3 by ddorwin@chromium.org, Jan 7 2017

Labels: Proj-VR-Shell
Status: Started (was: Assigned)
Is this fixed?

Comment 4 by mthiesse@chromium.org, Jan 9 2017 

The original issue is fixed. Feel free to re-open if there's more work here Amir.

Comment 5 by asimjour@chromium.org, Jan 9 2017

Status: Fixed (was: Started)
►

Sign in to add a comment