New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668515 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

move components/safe_browsing_db/ into components/safe_browsing/

Project Member Reported by timvolod...@chromium.org, Nov 24 2016

Issue description

To minimize the number of components and keep related code in one place the existing safe_browsing_db/ component code can be moved to the new safe_browsing/ component (after https://codereview.chromium.org/2450993003/ lands).

 
As discussed in https://codereview.chromium.org/2450993003/ and email the safe_browsing_db code can probably live in a separate directory under components/safe_browsing/db or something like that.

Is there any blocking work on safe_browsing_db/ (except for https://codereview.chromium.org/2450993003/) going on? I understood there might be some patches in flight?

Comment 2 by ajha@chromium.org, Nov 24 2016

Components: Services>Safebrowsing
Cc: vakh@chromium.org
Yes, vakh often has patches in flight until the Pver4 implementation work is done. You should coordinate the move with him, or wait till the bulk of his work is complete.

Comment 4 by vakh@chromium.org, Dec 2 2016

Labels: SafeBrowsing-Triaged
Owner: timvolod...@chromium.org
Tim, assigning this to you for now and marking as Triaged.
Status: Assigned (was: Untriaged)
Status: Started (was: Assigned)
design doc for the component structure: https://goo.gl/2R6K3G
Cc: jialiul@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, May 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/89cf1171a6451dea5588e7b053a24d3a64a77f82

commit 89cf1171a6451dea5588e7b053a24d3a64a77f82
Author: timvolodine <timvolodine@chromium.org>
Date: Mon May 15 18:05:07 2017

Unify safe_browsing* components [1]: move safe_browsing_prefs*

This patch performs a step towards unification of safe_browsing_db
and safe_browsing components by moving safe_browsing_prefs* to
safe_browsing/common/ as discussed in the design doc
(https://goo.gl/2R6K3G).

BUG= 668515 
TBR=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2869383002
Cr-Commit-Position: refs/heads/master@{#471824}

[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/android/preferences/pref_service_bridge.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/download/download_browsertest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/extensions/api/preference/preference_api.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/interstitials/chrome_controller_client.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/profiles/profile.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/certificate_reporting_service.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/chrome_cleaner/reporter_runner_browsertest_win.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/chrome_cleaner/srt_client_info_win.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/client_side_detection_service.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/download_protection_service.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/download_protection_service_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/incident_reporting/last_download_finder_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/protocol_manager.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/safe_browsing_blocking_page_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/ui_manager.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ssl/bad_clock_blocking_page.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ssl/captive_portal_blocking_page.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ssl/cert_report_helper.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ssl/certificate_reporting_test_utils.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ssl/ssl_blocking_page.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/views/download/download_feedback_dialog_view.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/views/download/download_item_view.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/webui/options/browser_options_handler.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/chrome/browser/ui/webui/settings/safe_browsing_handler.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/base_blocking_page.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/common/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/common/DEPS
[rename] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/common/safe_browsing_prefs.cc
[rename] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/common/safe_browsing_prefs.h
[rename] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing/common/safe_browsing_prefs_unittest.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing_db/DEPS
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing_db/hit_report.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing_db/util.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/safe_browsing_db/v4_update_protocol_manager.h
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/security_interstitials/content/BUILD.gn
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/security_interstitials/content/DEPS
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/security_interstitials/content/security_interstitial_controller_client.cc
[modify] https://crrev.com/89cf1171a6451dea5588e7b053a24d3a64a77f82/components/security_interstitials/content/security_interstitial_page.cc

Project Member

Comment 9 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8df5d0b074e120e844acb736830d169feb7a1ec2

commit 8df5d0b074e120e844acb736830d169feb7a1ec2
Author: Tim Volodine <timvolodine@chromium.org>
Date: Thu Aug 17 17:00:10 2017

Unify safe_browsing* components [2]: move android bits.

Move android related code from the safe_browsing_db component to the
safe_browsing component. This is part of the unification effort
between the two components.

In particular this patch:
- moves android related original db files, tests and build targets to
  components/safe_browsing/db directory,
- moves safe_browsing_db/android -> safe_browsing/android,
- updates target name: safe_browsing_db_mobile -> safe_browsing_mobile,
- updates/creates relevant dependencies, includes and build files.

NOTE:
requires two-sided patch in order to not break downstream.

BUG= 668515 
NOTRY=true

Change-Id: Idd9b597369406729913b0d8283c35e08d3ea3f3b
Reviewed-on: https://chromium-review.googlesource.com/589847
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Cr-Commit-Position: refs/heads/master@{#495199}
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/browser/aw_browser_context.h
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/java/DEPS
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/javatests/DEPS
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/lib/aw_main_delegate.cc
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/android_webview/test/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/android/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/app/DEPS
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/app/android/chrome_main_delegate_android.cc
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/BUILD.gn
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/BUILD.gn
[add] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/DEPS
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiBridge.java
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/java/src/org/chromium/components/safe_browsing/SafeBrowsingApiHandler.java
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/android/safe_browsing_api_handler_bridge.h
[add] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/BUILD.gn
[add] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/DEPS
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/remote_database_manager.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/remote_database_manager.h
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/remote_database_manager_unittest.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/safe_browsing_api_handler.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/safe_browsing_api_handler.h
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[rename] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing/db/safe_browsing_api_handler_util.h
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing_db/BUILD.gn
[modify] https://crrev.com/8df5d0b074e120e844acb736830d169feb7a1ec2/components/safe_browsing_db/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Aug 17 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/clank/internal/apps/+/6d89687c1fce4ae61d11e94ef90d45e62f14951a

commit 6d89687c1fce4ae61d11e94ef90d45e62f14951a
Author: Tim Volodine <timvolodine@google.com>
Date: Thu Aug 17 17:46:13 2017

Project Member

Comment 11 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/155fea2f909d0b42cb32817d473e2a2673e22e5a

commit 155fea2f909d0b42cb32817d473e2a2673e22e5a
Author: Tim Volodine <timvolodine@google.com>
Date: Wed Sep 20 08:09:57 2017

Move components/safe_browsing_db to components/safe_browsing/db

Move the remaining contents of compontents/safe_browsing_db into
the safe_browsing component and delete the safe_browsing_db
component completely.

Update DEPS, build files, and all relevant includes.

BUG= 668515 
TBR=thestig@chromium.org,sgurun@chromium.org,battre@chromium.org,blundell@chromium.org

Change-Id: Ifb3ee4448ce4b9890e0546e6526563e3a4e40a09
Reviewed-on: https://chromium-review.googlesource.com/660740
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell (slow until Sept 25) <blundell@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503083}
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/android_webview/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/android_webview/browser/DEPS
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/android_webview/browser/aw_safe_browsing_resource_throttle.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/android_webview/browser/aw_safe_browsing_resource_throttle.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/android_webview/browser/aw_url_checker_delegate_impl.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/extensions/blacklist.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/extensions/blacklist.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/extensions/blacklist_state_fetcher.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/loader/safe_browsing_resource_throttle.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/permissions/permission_blacklist_client.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/download_protection/check_client_download_request.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/download_protection/download_protection_service.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/download_protection/download_url_sb_client.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/protocol_manager.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/protocol_manager.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/protocol_parser.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/protocol_parser_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_store.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/safe_browsing_util.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/services_delegate_stub.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/test_safe_browsing_database_helper.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/test_safe_browsing_service.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/test_safe_browsing_service.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/safe_browsing/v4_test_utils.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/subresource_filter/subresource_filter_test_harness.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/test/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/DEPS
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/android/safe_browsing_api_handler_bridge.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/base_blocking_page.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/base_ping_manager.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/base_resource_throttle.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/base_resource_throttle.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/browser/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/browser/safe_browsing_url_checker_impl.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/browser/url_checker_delegate.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/DEPS
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/README
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/database_manager.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/database_manager.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/database_manager_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/hit_report.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/hit_report.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/metadata.proto
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/prefix_set.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/prefix_set.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/prefix_set_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/remote_database_manager.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/remote_database_manager.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/safe_browsing_api_handler.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/safe_browsing_api_handler_util.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/safebrowsing.proto
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/test_database_manager.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/test_database_manager.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/util.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/util.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/util_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_database.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_database.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_database_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_feature_list.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_feature_list.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_get_hash_protocol_manager.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_get_hash_protocol_manager.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_local_database_manager.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_local_database_manager.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_local_database_manager_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_protocol_manager_util.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_protocol_manager_util.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_protocol_manager_util_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_rice.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_rice.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_rice_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_store.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_store.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_store.proto
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_store_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_test_util.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_test_util.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_update_protocol_manager.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_update_protocol_manager.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/v4_update_protocol_manager_unittest.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/whitelist_checker_client.cc
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/whitelist_checker_client.h
[rename] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/db/whitelist_checker_client_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/web_ui/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/safe_browsing/web_ui/safe_browsing_ui.cc
[delete] https://crrev.com/45137e0ca02c82be04046f24bdc7006334adbd47/components/safe_browsing_db/BUILD.gn
[delete] https://crrev.com/45137e0ca02c82be04046f24bdc7006334adbd47/components/safe_browsing_db/DEPS
[delete] https://crrev.com/45137e0ca02c82be04046f24bdc7006334adbd47/components/safe_browsing_db/OWNERS
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/security_interstitials/content/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/security_interstitials/content/DEPS
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/security_interstitials/content/unsafe_resource.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/DEPS
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/content_activation_list_utils.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_observer.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.h
[modify] https://crrev.com/155fea2f909d0b42cb32817d473e2a2673e22e5a/components/subresource_filter/core/common/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e1e964fdec277df9b67b78c4ac0a08047602bd

commit 58e1e964fdec277df9b67b78c4ac0a08047602bd
Author: vitaliii <vitaliii@chromium.org>
Date: Wed Sep 20 08:27:21 2017

Revert "Move components/safe_browsing_db to components/safe_browsing/db"

This reverts commit 155fea2f909d0b42cb32817d473e2a2673e22e5a.

Reason for revert: does not compile

https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/49275

../../chrome/browser/safe_browsing/protocol_parser.cc:23:10: fatal error: 'components/safe_browsing_db/metadata.pb.h' file not found
#include "components/safe_browsing_db/metadata.pb.h"
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Original change's description:
> Move components/safe_browsing_db to components/safe_browsing/db
> 
> Move the remaining contents of compontents/safe_browsing_db into
> the safe_browsing component and delete the safe_browsing_db
> component completely.
> 
> Update DEPS, build files, and all relevant includes.
> 
> BUG= 668515 
> TBR=thestig@chromium.org,sgurun@chromium.org,battre@chromium.org,blundell@chromium.org
> 
> Change-Id: Ifb3ee4448ce4b9890e0546e6526563e3a4e40a09
> Reviewed-on: https://chromium-review.googlesource.com/660740
> Commit-Queue: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Selim Gurun <sgurun@chromium.org>
> Reviewed-by: Dominic Battré <battre@chromium.org>
> Reviewed-by: Tim Volodine <timvolodine@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Colin Blundell (slow until Sept 25) <blundell@chromium.org>
> Reviewed-by: Varun Khaneja <vakh@chromium.org>
> Reviewed-by: Jialiu Lin <jialiul@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#503083}

TBR=thestig@chromium.org,jam@chromium.org,battre@chromium.org,blundell@chromium.org,sgurun@chromium.org,timvolodine@chromium.org,vakh@chromium.org,jialiul@chromium.org

Change-Id: I60f196fb7abf838f69f568818da232e8844dde15
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  668515 
Reviewed-on: https://chromium-review.googlesource.com/674963
Reviewed-by: vitaliii <vitaliii@chromium.org>
Commit-Queue: vitaliii <vitaliii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503086}
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/android_webview/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/android_webview/browser/DEPS
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/android_webview/browser/aw_safe_browsing_resource_throttle.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/android_webview/browser/aw_safe_browsing_resource_throttle.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/android_webview/browser/aw_url_checker_delegate_impl.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/extensions/blacklist.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/extensions/blacklist.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/extensions/blacklist_state_fetcher.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/loader/safe_browsing_resource_throttle.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/permissions/permission_blacklist_client.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/download_protection/check_client_download_request.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/download_protection/download_protection_service.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/download_protection/download_url_sb_client.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/incident_reporting/module_load_analyzer_win_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/protocol_manager.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/protocol_manager.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/protocol_parser.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/protocol_parser_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_store.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/safe_browsing_util.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/services_delegate_stub.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/test_safe_browsing_database_helper.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/test_safe_browsing_service.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/test_safe_browsing_service.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/safe_browsing/v4_test_utils.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/subresource_filter/subresource_filter_test_harness.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/test/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/DEPS
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/android/safe_browsing_api_handler_bridge.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/base_blocking_page.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/base_ping_manager.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/base_resource_throttle.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/base_resource_throttle.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/browser/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/browser/safe_browsing_url_checker_impl.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/browser/url_checker_delegate.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/DEPS
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/remote_database_manager.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/remote_database_manager.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/safe_browsing_api_handler.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/db/safe_browsing_api_handler_util.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/web_ui/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing/web_ui/safe_browsing_ui.cc
[add] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/BUILD.gn
[add] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/DEPS
[add] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/OWNERS
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/README
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/database_manager.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/database_manager.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/database_manager_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/hit_report.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/hit_report.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/metadata.proto
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/prefix_set.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/prefix_set.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/prefix_set_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/safebrowsing.proto
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/test_database_manager.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/test_database_manager.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/util.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/util.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/util_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_database.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_database.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_database_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_feature_list.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_feature_list.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_get_hash_protocol_manager.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_get_hash_protocol_manager.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_get_hash_protocol_manager_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_local_database_manager.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_local_database_manager.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_local_database_manager_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_protocol_manager_util.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_protocol_manager_util.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_protocol_manager_util_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_rice.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_rice.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_rice_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_store.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_store.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_store.proto
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_store_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_test_util.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_test_util.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_update_protocol_manager.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_update_protocol_manager.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/v4_update_protocol_manager_unittest.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/whitelist_checker_client.cc
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/whitelist_checker_client.h
[rename] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/safe_browsing_db/whitelist_checker_client_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/security_interstitials/content/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/security_interstitials/content/DEPS
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/security_interstitials/content/unsafe_resource.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/DEPS
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/content_activation_list_utils.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_observer.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.h
[modify] https://crrev.com/58e1e964fdec277df9b67b78c4ac0a08047602bd/components/subresource_filter/core/common/DEPS

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e459384764c733c62fe4c4e78f17ced72a70a6b4

commit e459384764c733c62fe4c4e78f17ced72a70a6b4
Author: Tim Volodine <timvolodine@google.com>
Date: Thu Sep 21 10:08:22 2017

Reland: Move components/safe_browsing_db to components/safe_browsing/db

Reland of https://chromium-review.googlesource.com/660740.

Move the remaining contents of compontents/safe_browsing_db into
the safe_browsing component and delete the safe_browsing_db
component completely.

Update DEPS, build files, and all relevant includes.

BUG= 668515 
TBR=thestig@chromium.org,sgurun@chromium.org,battre@chromium.org,blundell@chromium.org,vakh@chromium.org

Reviewed-on: https://chromium-review.googlesource.com/660740
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Selim Gurun <sgurun@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Colin Blundell (slow until Sept 25) <blundell@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#503083}
Change-Id: I7e3fac2b6e906b1f78ba262d594b9b01574a8a3a
Reviewed-on: https://chromium-review.googlesource.com/676848
Cr-Commit-Position: refs/heads/master@{#503408}
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/android_webview/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/android_webview/browser/DEPS
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/android_webview/browser/aw_safe_browsing_resource_throttle.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/android_webview/browser/aw_safe_browsing_resource_throttle.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/android_webview/browser/aw_url_checker_delegate_impl.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/download/download_danger_prompt_browsertest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/extensions/blacklist.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/extensions/blacklist.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/extensions/blacklist_state_fetcher.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/extensions/fake_safe_browsing_database_manager.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/loader/safe_browsing_resource_throttle.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/permissions/permission_blacklist_client.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/permissions/permission_context_base.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/permissions/permission_context_base_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/permissions/permission_decision_auto_blocker.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/permissions/permission_decision_auto_blocker_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/prerender/prerender_test_utils.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/prerender/prerender_test_utils.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/browser_feature_extractor.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/chrome_password_protection_service.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/chrome_password_protection_service_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/client_side_detection_host.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/client_side_detection_host.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/download_protection/check_client_download_request.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/download_protection/download_protection_service.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/download_protection/download_protection_service_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/download_protection/download_url_sb_client.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/download_protection/ppapi_download_request.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/incident_reporting/incident_reporting_service.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/incident_reporting/resource_request_detector.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/incident_reporting/resource_request_detector_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/local_database_manager.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/local_database_manager.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/local_database_manager_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/notification_image_reporter.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/notification_image_reporter_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_manager.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_manager.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_manager_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_parser.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_parser.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/protocol_parser_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_database.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_database.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_service.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_service_browsertest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_store.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_store_file.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_store_file_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_store_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/safe_browsing_util.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/services_delegate_impl.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/services_delegate_stub.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/test_safe_browsing_database_helper.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/test_safe_browsing_database_helper.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/test_safe_browsing_service.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/test_safe_browsing_service.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/ui_manager_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/url_checker_delegate_impl.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/safe_browsing/v4_test_utils.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/subresource_filter/chrome_subresource_filter_client.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/subresource_filter/subresource_filter_browser_test_harness.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/subresource_filter/subresource_filter_test_harness.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/subresource_filter/subresource_filter_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/browser/ui/webui/interstitials/interstitial_ui.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/test/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/chrome/test/ppapi/ppapi_filechooser_browsertest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/DEPS
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/android/safe_browsing_api_handler_bridge.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/base_blocking_page.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/base_ping_manager.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/base_resource_throttle.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/base_resource_throttle.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/browser/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/browser/safe_browsing_url_checker_impl.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/browser/threat_details.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/browser/url_checker_delegate.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/DEPS
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/README
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/database_manager.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/database_manager.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/database_manager_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/hit_report.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/hit_report.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/metadata.proto
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/prefix_set.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/prefix_set.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/prefix_set_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/remote_database_manager.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/remote_database_manager.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/safe_browsing_api_handler.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/safe_browsing_api_handler_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/safe_browsing_api_handler_util.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/safe_browsing_api_handler_util.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/safebrowsing.proto
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/test_database_manager.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/test_database_manager.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/util.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/util.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/util_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_database.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_database.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_database_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_feature_list.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_feature_list.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_get_hash_protocol_manager.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_get_hash_protocol_manager.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_get_hash_protocol_manager_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_local_database_manager.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_local_database_manager.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_local_database_manager_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_protocol_manager_util.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_protocol_manager_util.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_protocol_manager_util_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_rice.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_rice.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_rice_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_store.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_store.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_store.proto
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_store_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_test_util.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_test_util.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_update_protocol_manager.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_update_protocol_manager.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/v4_update_protocol_manager_unittest.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/whitelist_checker_client.cc
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/whitelist_checker_client.h
[rename] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/db/whitelist_checker_client_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/password_protection/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/password_protection/password_protection_request.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/password_protection/password_protection_service.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/password_protection/password_protection_service.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/password_protection/password_protection_service_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/web_ui/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/safe_browsing/web_ui/safe_browsing_ui.cc
[delete] https://crrev.com/63a99b490e1e463f2adbaa0ada07f1b0d25edcc4/components/safe_browsing_db/BUILD.gn
[delete] https://crrev.com/63a99b490e1e463f2adbaa0ada07f1b0d25edcc4/components/safe_browsing_db/DEPS
[delete] https://crrev.com/63a99b490e1e463f2adbaa0ada07f1b0d25edcc4/components/safe_browsing_db/OWNERS
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/security_interstitials/content/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/security_interstitials/content/DEPS
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/security_interstitials/content/unsafe_resource.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/BUILD.gn
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/DEPS
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/content_activation_list_utils.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/fake_safe_browsing_database_manager.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_observer.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_observer_test_utils.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/content/browser/subresource_filter_safe_browsing_client_request.h
[modify] https://crrev.com/e459384764c733c62fe4c4e78f17ced72a70a6b4/components/subresource_filter/core/common/DEPS

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a921ee2df3784bee21246a98f56283b8679fd7fb

commit a921ee2df3784bee21246a98f56283b8679fd7fb
Author: Tim Volodine <timvolodine@google.com>
Date: Thu Nov 02 12:02:32 2017

safe_browsing: move android specific files to safe_browsing/android directory

Move the remaining android only targets and files from
safe_browsing/db to safe_browsing/android directory.
Update includes, build files and dependencies.

BUG= 668515 
TBR=torne@chromium.org,thestig@chromium.org,blundell@chromium.org

Change-Id: Iac822078e63e338d5c2c938f6b90203a0c09e509
Reviewed-on: https://chromium-review.googlesource.com/738240
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#513462}
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/android_webview/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/android_webview/browser/aw_browser_context.h
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/chrome/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/chrome/app/android/chrome_main_delegate_android.cc
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/chrome/browser/safe_browsing/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/chrome/browser/safe_browsing/safe_browsing_service.cc
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/DEPS
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/remote_database_manager.cc
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/remote_database_manager.h
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/remote_database_manager_unittest.cc
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler.cc
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler.h
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler_bridge.h
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler_unittest.cc
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler_util.cc
[rename] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/android/safe_browsing_api_handler_util.h
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/db/BUILD.gn
[modify] https://crrev.com/a921ee2df3784bee21246a98f56283b8679fd7fb/components/safe_browsing/db/DEPS

Project Member

Comment 15 by bugdroid1@chromium.org, Nov 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a686a28b421b6efbe23e86defd423714620c159

commit 7a686a28b421b6efbe23e86defd423714620c159
Author: Tim Volodine <timvolodine@chromium.org>
Date: Thu Nov 09 18:38:54 2017

safe_browsing: remove unused bits in android/BUILD.gn

The android targets are not compiled on windows, therefore
the "is_win" related bits can be removed.

(as per original comment on
https://chromium-review.googlesource.com/c/chromium/src/+/738240/1)

BUG= 668515 

Change-Id: Ibf16b209dc6fac1f83790c2abf40b3add43f5db4
Reviewed-on: https://chromium-review.googlesource.com/753344
Commit-Queue: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Reviewed-by: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#515220}
[modify] https://crrev.com/7a686a28b421b6efbe23e86defd423714620c159/components/safe_browsing/android/BUILD.gn

Labels: Hotlist-EnamelAndFriendsFixIt
Labels: -Hotlist-EnamelAndFriendsFixIt
Status: Fixed (was: Started)

Sign in to add a comment