New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668510 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Crash in v8::internal::DoubleToRadixCString

Project Member Reported by ClusterFuzz, Nov 24 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5631879828209664

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_dbg
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f305efe6980
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Recommended Security Severity: Medium

Regressed: V8: r41254:41255

Minimized Testcase (8.61 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96I_mzJFv5CUq1VHG7hWpgpyHVrCotjJ0PizDNJLOAW7N35uU-YKtkS1bZZnNe5y9QMdAVjvwpwBQgZVOpUwxRbQgZjnjMu5YLH_AvEcFiOXHCozELIy88APAk0gqjuJAb1xKDWecz9X0ZnWNlq93WZzIlCEA?testcase_id=5631879828209664

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Owner: yangguo@chromium.org
Status: Assigned (was: Untriaged)
Yang, bisects to your CL.
Labels: Security_Impact-Head
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 25 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b6d2bacd66391c0c6e501a810695259ab852a573

commit b6d2bacd66391c0c6e501a810695259ab852a573
Author: yangguo <yangguo@chromium.org>
Date: Fri Nov 25 07:46:10 2016

Fix Number.prototype.toString with non-default radix wrt modulo.

TBR=tebbi@chromium.org
BUG= chromium:668510 

Review-Url: https://codereview.chromium.org/2526223003
Cr-Commit-Position: refs/heads/master@{#41280}

[modify] https://crrev.com/b6d2bacd66391c0c6e501a810695259ab852a573/src/conversions.cc
[modify] https://crrev.com/b6d2bacd66391c0c6e501a810695259ab852a573/test/mjsunit/number-tostring.js

Project Member

Comment 4 by ClusterFuzz, Nov 25 2016

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5663238525288448

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: Global-buffer-overflow READ 1
Crash Address: 0xf67c5838
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Regressed: V8: r41254:41255

Minimized Testcase (0.09 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96Zvj-3UE3IEN0UCQLAl8JhESOHYUEbOP0l1d1zwbZmcEte_zGMU0or1U6rhwEpYaQpMpdQDEMkAHC1azN66jpyhRhNq23FI2uoNBoCttji7kab9vsp1REXoAcp2yfckfF2SYL5NQ907h4asB2X1jVteknGcA?testcase_id=5663238525288448
function __f_6(a, b, c) {
 b.toString(c);
}
__f_6("600f9f6dd18bc8000",111111111111111114140, 12);


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
Project Member

Comment 5 by sheriffbot@chromium.org, Nov 25 2016

Labels: M-56
Project Member

Comment 6 by sheriffbot@chromium.org, Nov 25 2016

Labels: ReleaseBlock-Beta
This issue is a security regression. If you are not able to fix this quickly, please revert the change that introduced it.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 7 by sheriffbot@chromium.org, Nov 25 2016

Labels: Pri-1
Project Member

Comment 8 by ClusterFuzz, Nov 26 2016

ClusterFuzz has detected this issue as fixed in range 41279:41280.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5631879828209664

Fuzzer: decoder_langfuzz
Job Type: linux_asan_d8_ignition_dbg
Platform Id: linux

Crash Type: UNKNOWN READ
Crash Address: 0x7f305efe6980
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Recommended Security Severity: Medium

Regressed: V8: r41254:41255
Fixed: V8: r41279:41280

Minimized Testcase (8.61 Kb): https://cluster-fuzz.appspot.com/download/AMIfv96I_mzJFv5CUq1VHG7hWpgpyHVrCotjJ0PizDNJLOAW7N35uU-YKtkS1bZZnNe5y9QMdAVjvwpwBQgZVOpUwxRbQgZjnjMu5YLH_AvEcFiOXHCozELIy88APAk0gqjuJAb1xKDWecz9X0ZnWNlq93WZzIlCEA?testcase_id=5631879828209664

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Nov 26 2016

ClusterFuzz has detected this issue as fixed in range 41279:41280.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5663238525288448

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: Global-buffer-overflow READ 1
Crash Address: 0xf67c5838
Crash State:
  v8::internal::DoubleToRadixCString
  v8::internal::Builtin_Impl_NumberPrototypeToString
  v8::internal::Builtin_NumberPrototypeToString
  
Regressed: V8: r41254:41255
Fixed: V8: r41279:41280

Minimized Testcase (0.09 Kb):
Download: https://cluster-fuzz.appspot.com/download/AMIfv96Zvj-3UE3IEN0UCQLAl8JhESOHYUEbOP0l1d1zwbZmcEte_zGMU0or1U6rhwEpYaQpMpdQDEMkAHC1azN66jpyhRhNq23FI2uoNBoCttji7kab9vsp1REXoAcp2yfckfF2SYL5NQ907h4asB2X1jVteknGcA?testcase_id=5663238525288448
function __f_6(a, b, c) {
 b.toString(c);
}
__f_6("600f9f6dd18bc8000",111111111111111114140, 12);


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 26 2016

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase is verified as fixed, closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Nov 26 2016

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -reward-topanel reward-0
The panel declined to reward in this case, since it was trunk churn.
Umm, since when are trunk issues not eligible for rewards? It was found as part of the fuzzer contribution program and fixed as a result of this bug report.
Labels: -reward-0 reward-topanel
Retagging with reward-topanel as we might have missed #3!
Labels: Merge-Request-56

Comment 16 by dimu@chromium.org, Dec 16 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 17 by sheriffbot@chromium.org, Dec 20 2016

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Approved -Merge-Approved-56
Labels: -reward-topanel reward-unpaid reward-500
Hi decoder.oh@ - the panel took another look at this.  While there was a fix landed in this bug, the mbarbella_js_mutation fuzzer found (#9) it independently within 48 hours - even though that was after the fix.  We double checked that our fuzzer hadn't just picked up the case that was check in as part of #3 so we're confident that we would have found this bug without your fuzzer, and thus it falls outside the scope of the VRP. However the panel used their discretion to reward $500 in this case.
hi yangguo@ - would you be able to merge this to the M56 branch?
Labels: -reward-unpaid reward-inprocess
Labels: -ReleaseBlock-Beta -M-56 M-57
Project Member

Comment 24 by sheriffbot@chromium.org, Mar 4 2017

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment