New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668508 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature



Sign in to add a comment

Merge Mid-Call probing fix to M55

Project Member Reported by philipel@chromium.org, Nov 24 2016

Issue description

Mid-call probing is already available in M54 but a bug was discovered/fixed recently (https://codereview.webrtc.org/2481383002/) that we would like to merge into M55
 
CL is ready to be landed: https://codereview.webrtc.org/2525383002

Comment 2 by gov...@chromium.org, Nov 24 2016

Is this change applicable to all OSs or any specific os?

Also before we approve the merge to M55, could you please confirm this change is well baked/verified in Canary and safe to merge to M55?


Labels: OS-All
Yes, it's for all OSs. I have tested it locally and it works well.

Also, the mid-call probing is not really used in M54, but we want to start using it in M55, so we don't risk breaking any current application.

Comment 4 by dimu@chromium.org, Nov 25 2016

Labels: -Merge-Request-55 Merge-Review-55 Hotlist-Merge-Review
[Automated comment] Less than 2 weeks to go before stable on M55, manual review required.

Comment 5 by gov...@chromium.org, Nov 26 2016

Labels: -Merge-Review-55 Merge-Approved-55
Approving merge to M55 branch 2883 based on comment #3. Please merge ASAP. Merge has to happen before 4:00 PM PT, Monday (11/28) in order to make into the Desktop final build cut.
Status: Fixed (was: Assigned)
Merge CL has now landed: https://chromium.googlesource.com/external/webrtc/+/5ff9cd35c5f5052cc7a9c4a63759cf8d86a5234b

Comment 7 by gov...@chromium.org, Nov 28 2016

Labels: -Merge-Approved-55 Merge-Merged-55
Applying "merge-merged-55" label and removing "Merge-Approved-55" label based on comment #6.

Is this require a merge to M56?
No, the original CL landed 2 days before the M56 branch cut, so it's already in.

Sign in to add a comment