New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668467 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Mac
Pri: 2
Type: Bug



Sign in to add a comment

CreateWaitAndExitThread(base::TimeDelta::FromSeconds(60)) in child_thread_impl.cc

Project Member Reported by ClusterFuzz, Nov 24 2016

Issue description

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=5475886146256896

Fuzzer: attekett_dom_fuzzer
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  CreateWaitAndExitThread(base::TimeDelta::FromSeconds(60)) in child_thread_impl.c
  content::SuicideOnChannelErrorFilter::OnChannelError
  IPC::ChannelProxy::Context::OnChannelError
  
Regressed: https://cluster-fuzz.appspot.com/revisions?job=mac_asan_chrome&range=434175:434178

Minimized Testcase (0.28 Kb): https://cluster-fuzz.appspot.com/download/AMIfv94hxzf-2vpBtt1Uv1YI4PuHIfLHAI5wiNjzO6uQgYC2RS43geADfI3mVa_FTFE6oucT1Q6ucMydSQ21UlZPFlylowVQxjmQuyrPEsu64l0KwBbe8syWXacrc8CMEXrVNA1dV57DXnd62oKRXjR-MFwEGD1WSA?testcase_id=5475886146256896

Issue filed automatically.

See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.
 
Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong
Owner: sadrul@chromium.org
Status: Assigned (was: Untriaged)
Unable to find possible suspect from find it and CL.
Assigning to concern owner using Code Search for the file, "child_thread_impl.cc".

Suspecting the following CL --
https://chromium.googlesource.com/chromium/src/+/b9ff6c9da80f39e37c8f44cd0f9d8749f0fa377f

@sadrul -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.
Owner: ----
Status: Available (was: Assigned)
The crash is not related to my CL. Not sure what may be responsible.
Cc: kcc@chromium.org tzik@chromium.org
Project Member

Comment 4 by ClusterFuzz, Mar 16 2017

Labels: OS-Android
Project Member

Comment 5 by ClusterFuzz, Mar 18 2017

Labels: OS-Linux
Project Member

Comment 6 by ClusterFuzz, Jan 30 2018

Labels: ClusterFuzz-Top-Crash M-66 ReleaseBlock-Beta
Testcase 5475886146256896 is a top crash on ClusterFuzz for mac platform. Please prioritize fixing this crash.

Marking this crash as a Beta release blocker.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Labels: Stability-Sheriff-Desktop
Adding stability sheriff for further help as it is marked as beta blocker & no update from longtime.

Thanks..!

Comment 8 Deleted

Labels: Stability-Sheriff-Desktop

Comment 10 by nick@chromium.org, Feb 7 2018

Stability sheriff's deputy here.

This bug doesn't look particularly actionable. This sort of crash signature has been happening for a fairly long time -- see e.g.  bug 665188  -- so unless there has been a demonstrable spike in its frequency on clusterfuzz systems, it might just be an old situation.

What's apparently going on here is that the pthread_create is failing, while we're in the middle of exiting due to a channel error. pthread_create can fail if we've hit the system thread limit (what is that on clusterfuzz systems?); it could also (maybe?) be an OOM. The thread is being created to let the process run for another minute before shutting things down, to give sanitizers a chance to detect bugs and such.

Because the shutdown is due to a channel error, if there's been a spike in channel errors, we might see a commensurate spike here.

As for causes, the only clue I see is that the test case includes a window.close() (it's pretty boring otherwise), which might trigger a less-common process exit ordering, which could plausibly lead to a channel error.

Comment 11 by nick@chromium.org, Feb 7 2018

on the other hand, clusterfuzz claims this is reproduceable, and the test case is small. I just kicked off a re-run of the blame range.

It's also worth pointing out that this bug won't be reproduceable with a vanilla build of Chrome. The function in question only exists in ASAN builds.

Comment 12 by nick@chromium.org, Feb 7 2018

It does seem like there's a spike in crashes observed by clusterfuzz. The spike seems to have started around Jan 29 @ 2 PM UTC: the rate goes from very infrequent to steadily dozens per hour.
Project Member

Comment 13 by ClusterFuzz, Feb 9 2018

Labels: Fuzz-Blocker
This crash occurs very frequently on mac platform and is likely preventing the fuzzer attekett_dom_fuzzer from making much progress. Fixing this will allow more bugs to be found.

Marking this bug as a blocker for next Beta release.

If this is incorrect, please add ClusterFuzz-Wrong label and remove the ReleaseBlock-Beta label.
Cc: -msrchandra@chromium.org nick@chromium.org
Friendly ping!
Nick@,
Could you please take a look and assign to the right owner as it is marked as Fuzz blocker & beta blocker issue.
Thanks in advance..!

Stability sheriff here -- in c#11 there was a re-run seeking blame range, is there an update on that?
Components: Blink>Internals
Labels: -ReleaseBlock-Beta
Owner: haraken@chromium.org
Status: Untriaged (was: Available)
Per C#11 this crash can only happen in ASAN builds (not user builds) so I don't think this should be a beta blocker.  I would suggest this code needs to be more robust to system resource exhaustion and fail gracefully instead of crashing.

The original author (earthdok@) of this code seems to no longer be contributing?

I don't know who would be a good owner... assigning to haraken@ as the owner of content/child for re-triage.





Labels: -Pri-1 -Stability-Sheriff-Desktop Pri-2
Also lowering priority and removing from sheriff queue.
Summary: CreateWaitAndExitThread(base::TimeDelta::FromSeconds(60)) in child_thread_impl.cc (was: CreateWaitAndExitThread(base::TimeDelta::FromSeconds(60)) in child_thread_impl.c)
Labels: CF-NeedsTriage
Unable to provide possible suspect using Predator, CL and Code Search.
Could someone please look into the issue.

Thank You...

Status: Assigned (was: Untriaged)
This bug has an owner, thus, it's been triaged. Changing status to "assigned".
Project Member

Comment 21 by ClusterFuzz, Sep 8

ClusterFuzz has detected this issue as fixed in range 589552:589567.

Detailed report: https://clusterfuzz.com/testcase?key=5475886146256896

Fuzzer: attekett_dom_fuzzer
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: CHECK failure
Crash Address: 
Crash State:
  CreateWaitAndExitThread(base::TimeDelta::FromSeconds(60)) in child_thread_impl.c
  content::SuicideOnChannelErrorFilter::OnChannelError
  IPC::ChannelProxy::Context::OnChannelError
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=338204:338244
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=589552:589567

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5475886146256896

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 22 by ClusterFuzz, Sep 8

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5475886146256896 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment