New issue
Advanced search Search tips

Issue 668455 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 668491



Sign in to add a comment

Remove --enable-ad command line flag

Project Member Reported by tnagel@chromium.org, Nov 24 2016

Issue description

Remove --enable-ad command line flag as soon as we have
a) enabled the requisition parameter
b) agreement from KIR that they'll reliably gate AD enrollment on the set of whitelisted domains.
 
Additional requirement: Changed to code to make sure it only runs on dev channel (i.e. it'll self-disable if executed on a different channel).

Comment 2 by tnagel@chromium.org, Nov 24 2016

Yes, we have CL in flight for that already: https://chromium-review.googlesource.com/#/c/414044/


Comment 3 by tnagel@chromium.org, Nov 24 2016

Labels: -TT V1
Relegating to V1 since we'll revamp that code anyways.

Comment 5 by tnagel@chromium.org, Nov 24 2016

And requisition parameter has been enabled per https://codereview.chromium.org/2528923002/.
Project Member

Comment 6 by bugdroid1@chromium.org, Nov 28 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e56edf619ec2a7cea8cbd81c2b90c93f30f2e937

commit e56edf619ec2a7cea8cbd81c2b90c93f30f2e937
Author: Lutz Justen <ljusten@chromium.org>
Date: Wed Nov 23 14:03:01 2016

authpolicy: Prevent startup on non-dev channels

During the initial testing phase of authpolicy prevent that it is run on beta
or release channels.

BUG= chromium:668455 
TEST=Emerges, verified that it runs on a testimage-channel

Change-Id: I2ddaae75d56fa2cba0d6c9cddf50cbce77ebea33
Reviewed-on: https://chromium-review.googlesource.com/414044
Commit-Ready: Lutz Justen <ljusten@chromium.org>
Tested-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Thiemo Nagel <tnagel@chromium.org>

[modify] https://crrev.com/e56edf619ec2a7cea8cbd81c2b90c93f30f2e937/authpolicy/authpolicy_main.cc

Comment 7 by tnagel@chromium.org, Dec 19 2016

Owner: rsorokin@chromium.org
Status: Assigned (was: Available)

Comment 8 by tnagel@chromium.org, Dec 19 2016

Labels: -Pri-1 Pri-2
Blockedon: 668491
Labels: -M-57 -V1 M-58
Labels: CodeHealth
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Status: Verified (was: Fixed)
bulk Verify of older or not-user-facing Chromad bugs

Sign in to add a comment