New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668427 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Non-Regression : Delete Overlay is seen missing when clicking Search Icon of selected Image

Project Member Reported by mmanchala@chromium.org, Nov 24 2016

Issue description

Version: 56.0.2924.4/9000.5.0 dev-channel Daisy,Candy,Peppy and Quawks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Save any Image -> Go to Files App
(2)Select the image('Open','Delete' options are enabled) -> Click on Search Icon
(3)Now click on Delete icon and observe for overlay (Please refer Video)

Expected: Delete Overlay should be seen on clicking Delete icon
Actual: Instead Delete Overlay is seen missing i.e. on clicking Delete Icon search field is getting closed

This is Non-Regression Issue seen from M-54
@fukino: Please confirm the issue.

Note:
Issue is not seen on clicking 'Open' option i.e. Gallery gets opened

 
Actual_DeleteOption.webm
677 KB View Download
Expected_Options.webm
769 KB View Download
Labels: -m-56

Comment 2 by sashab@chromium.org, Feb 24 2018

Labels: CrOS-FilesApp-UI
Owner: ----
Status: Unconfirmed (was: Assigned)

Comment 4 by sashab@chromium.org, Feb 28 2018

Labels: -CrOS-FilesApp-UI CrOSFilesCategory-UI

Comment 5 by dats@google.com, Mar 19 2018

Status: WontFix (was: Unconfirmed)
No repro on 67.
Cc: dats@chromium.org
Owner: fukino@chromium.org
Status: Assigned (was: WontFix)
Able to reproduce the Issue on latest M-67 67.0.3376.0/10505.0.0 dev-channel Daisy.
Attaching Video for reference.

Reopening Issue

Thanks..!!
OnLatestM67.webm
1.4 MB View Download
Cc: fukino@chromium.org
Labels: -Pri-2 Pri-3
Owner: ----
Status: Available (was: Assigned)
Labels: Files-Fixit-2018
Owner: joelhockey@chromium.org
Status: Started (was: Available)
Joel's brain dump for anyone else that might pick up this bug:

The delete button listens to 'click' event.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/toolbar_controller.js?l=104&rcl=5c5f86f2c1fda2d9ec2b947aa7b44cea985f0d03

The open button has 2 sections in it, the main 'open' listens to 'click', the little arrow listens to 'mousedown' (via MenuButton).
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/combobutton.js?l=106&rcl=915ec100be7e4ded68283627b8a03fca214e04d0
https://cs.chromium.org/chromium/src/ui/webui/resources/js/cr/ui/menu_button.js?l=126&rcl=915ec100be7e4ded68283627b8a03fca214e04d0

The search text listens for 'blur'.
https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/js/ui/search_box.js?l=60&rcl=915ec100be7e4ded68283627b8a03fca214e04d0

The order that events are fired by the browser are:
mousedown
blur
mouseup
click

By calling event.prevendDefault(), it is possible for earlier events to stop the following events from happening.

I can't see why, but click is not firing after blur.  Hence the search box closes, but delete or open doesn't trigger.  An alternative is to change delete and open to listen to 'mousedown' rather than 'click'.  The downside for this solution is that blur does not seem to fire then and the search box is left open.
Cc: adan...@google.com
Alex, let me know if you have any thoughts about this bug.
Looks a bit more complicated. I somehow managed to get it to fail for the 'Open' button as well. Try this:
1) Select image
2) click 'search'
3) click 'open'
4) click 'open again.
The open at step (3) fails, then works in (4) so there's something strange going on with retained state by the looks of it. 
I think the behaviour you are seeing is the same that I described.  The first time you click open (step 3), the blur event triggers, but the click event for open does not.  Then when you click open again (step 4), the click event triggers and the open succeeds.
Owner: ----
Status: Available (was: Started)

Sign in to add a comment