New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668416 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Image which is selected using arrow buttons from keyboard is not seen as profile pic in chrome://md-settings

Project Member Reported by mmanchala@chromium.org, Nov 24 2016

Issue description

Version: 56.0.2924.4/9000.5.0 dev-channel Daisy,Candy,Peppy and Quawks
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Go to chrome://md-settings/changePicture-> Now select any Image using mouse cursor(Ex:Dragonfly)
(2)Now Use Up/Down/Right/left arrow buttons from keyboard to select any Image(Ex: select Bicycle) and click on back arrow to navigate to chrome://md-settings page
(3)Now observe profile pic under People(Please refer Video)

Expected: Image (Bicycle)which is selected using arrow buttons from keyboard should be seen as profile pic under People
Actual: Instead Image(Dragonfly) which is selected using mouse is seen as profile pic

This is Regression Issue as same is working fine in chrome://settings page
 
Actual_Image.webm
2.0 MB View Download
Expected_Image.webm
1.4 MB View Download
Owner: tommycli@chromium.org
Status: Assigned (was: Untriaged)
Reproducible and definitely confusing.

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e

commit 6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e
Author: tommycli <tommycli@chromium.org>
Date: Wed Jan 11 04:14:25 2017

MD Settings People: Fix ChromeOS Change Picture arrow keys

The arrow keys now actually select the newly highlighted picture.

BUG= 668416 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2623993002
Cr-Commit-Position: refs/heads/master@{#442795}

[modify] https://crrev.com/6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e/chrome/browser/resources/settings/people_page/change_picture.js
[modify] https://crrev.com/6b13e1b5dfc1d83b733e6e6ec4d536a47feb8c7e/chrome/test/data/webui/settings/people_page_change_picture_test.js

Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Verified on ChromeOS 9202.0.0, 57.0.2984.0

Sign in to add a comment