New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668400 link

Starred by 1 user
Status: Fixed
Owner:
█ eostroukhov@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
nyerramilli@chromium.org
█ msrchandra@chromium.org
█ ranjitkan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Weird large gap is seen on chrome://inspect/ page.

Reported by adha...@etouch.net, Nov 24 2016 
Chrome Version: 57.0.2929.3 (Official Build)3619fbd7f57a1d171fac4d4adedde499f17eec95-refs/branch-heads/2929@{#3} 32/64-bit.
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.10.5, 10.11.4)

What steps will reproduce the problem?
1. Launch chrome, go to chrome://inspect/#devices page and observe.

Large gap is seen between lower border of omnibox and first separator line of Devices page.
Gap should be proper between lower border of omnibox and first separator line of Devices page.

This is a regression issue, broken in M-55 series, below is manual regression range.

Good build: 55.0.2866.0
Bad build: 55.0.2867.0

Kindly review the attached screenshot for reference.
Gap_Screenshot.png
35.4 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 24 2016

Labels: hasbisect-per-revision
Owner: pfeldman@chromium.org
Status: Assigned (was: Unconfirmed)
Ran the bisect by changing good and bad builds,

Using the per-revision bisect providing the bisect results,
Good build: 55.0.2865.0 (Revision: 419930).
Bad build: 55.0.2866.0 (Revision: 419628).

You are probably looking for a change made after 419668 (known bad), but no later than 419669 (first known good).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/25ab67835b2abc9fcd2fa4f3b83897e515265a5f..79757ed652996cb3fc82417ef025fb3f621214ce

@pfeldman -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You.

Comment 2 by pfeldman@chromium.org, Nov 28 2016

Owner: eostroukhov@chromium.org

Comment 3 by ranjitkan@chromium.org, Nov 30 2016

Cc: ranjitkan@chromium.org
@eostroukhov: Gentle ping, request you to please take a look into it. Issue is marked with M55 label and is approaching stable soon.

Thanks.!
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/203fe850b9f974f324bda2c0a30707f2d4bd77bb

commit 203fe850b9f974f324bda2c0a30707f2d4bd77bb
Author: eostroukhov <eostroukhov@chromium.org>
Date: Fri Dec 02 23:12:40 2016

[DevTools] Pin the infobar to the top of the page

This fixes following issues:
1. Infobar is still visible when the user scrolls down.
2. Double scroll bar issues are fixed.
3. Gap above the headers is reduced.

BUG= 668400 ,  661456 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2540483004
Cr-Commit-Position: refs/heads/master@{#436072}

[modify] https://crrev.com/203fe850b9f974f324bda2c0a30707f2d4bd77bb/chrome/browser/resources/inspect/inspect.css

Comment 5 by dchau...@etouch.net, Dec 9 2016 

Retested this issue on latest canary chrome version 57.0.2945.0 (Official Build). It's seems to be fixed and working as intended i.e. Gap is proper between lower border of omnibox and first separator line of Devices page.

Comment 6 by eostroukhov@chromium.org, Dec 9 2016

Status: Fixed (was: Assigned)
►

Sign in to add a comment