New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668397 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Feature



Sign in to add a comment

Make the event log application name dependent on the branding of the build

Project Member Reported by pastarmovj@chromium.org, Nov 24 2016

Issue description

Right now it is hard coded to be "chrome" which makes it hard for other projects sharing the codebase to use their own branding when using the logging facility (the SYSLOG macros).

 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3eac43eeb3dc4bb862e6e27e9d12f7250428804

commit a3eac43eeb3dc4bb862e6e27e9d12f7250428804
Author: pastarmovj <pastarmovj@chromium.org>
Date: Wed Dec 07 17:38:52 2016

Make the name of the event source for SYSLOG configurable.

In order to allow this code to properly operate for all Chromium and Chrome flavors (e.g. Stable, Beta, Canary etc.) it is important to allow for different source names for the Event Logger.

The default behavior of SYSLOG now is equivalent to a LOG unless
SetEventSourceName is called at which point the function can start
logging to the Event Log as well.

For Branded Chrome build the event source stays Chrome for the Stable channel and will have the proper appendix for the various other channels whereas for non-branded build it will be Chromium.

BUG= 668397 
TEST=none

Review-Url: https://codereview.chromium.org/2530163002
Cr-Commit-Position: refs/heads/master@{#436994}

[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/base/syslog_logging.cc
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/base/syslog_logging.h
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/common/BUILD.gn
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/common/DEPS
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/common/logging_chrome.cc
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/install_static/install_details.h
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/install_static/install_modes.h
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/install_static/product_install_details.cc
[modify] https://crrev.com/a3eac43eeb3dc4bb862e6e27e9d12f7250428804/chrome/install_static/product_install_details_unittest.cc

Status: Fixed (was: Assigned)

Sign in to add a comment