New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668382 link

Starred by 0 users
Status: Duplicate
Merged: issue 770514
Owner: ----
Closed: Mar 2018
Cc:
rsesek@chromium.org
nyerramilli@chromium.org
kkaluri@chromium.org
█ msrchandra@chromium.org
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: In Incognito mode, Cast icon is not visible in action area.

Reported by lpa...@etouch.net, Nov 24 2016 
Version: 57.0.2929.4 (Official Build) canary 	82367cc74e9f970cf4cfe84f62db913f06d0fc95-refs/branch-heads/2929@{#5} (64-bit)
OS: Mac (10.11.6, 10.12.1)

URL: https://chrome.google.com/webstore/detail/google-cast/boadgeojelhgndaghljhdicfkmllpafd?hl=en-GB

What steps will reproduce the problem?
1) Launch chrome, go to above URL and add the extension.
2) Open a New Incognito window, right click on the page and select Cast option (Cast overlay opens).
3) Observe the Cast icon in action area besides omnibox.

Cast icon is not visible clearly in action area.

Cast icon should be visible clearly in action area.

This is a Regression issue broken in M-56, will soon update other info
Manual bisect:
Good build: 55.0.2882.0 
Bad build: 56.0.2886.0

Note: Issue is not seen on Windows and Linux OS.
cast.jpg
225 KB View Download

Comment 1 by kkaluri@chromium.org, Nov 24 2016

Cc: kkaluri@chromium.org
Labels: -M-56 hasbisect-per-revision M-57
Owner: rsesek@chromium.org
Status: Assigned (was: Unconfirmed)
Bisect Info:
===========

Good build : 55.0.2882.0,  Revision Range	423378
Bad build  : 56.0.2886.0,  Revision Range 	424099

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/902c98512627a485449a0684a4cdeebc0bcf1373..6d3dbe8eb6ff81ed2c9e89df2e13d1764056e9d7

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/6d3dbe8eb6ff81ed2c9e89df2e13d1764056e9d7

From the above CL suspecting the below change
---------------------------
https://codereview.chromium.org/2395083003


rsesek@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Comment 2 by jmukthavaram@chromium.org, Nov 30 2016 

Still we are able to reproduce the issue on Mac 10.11.6 with  latest Canary #57.0.2936.0.

rsesek@ Please take a look into this issue & update the thread.

Thanks.

Comment 3 by shrike@chromium.org, Nov 30 2016 

Confirmed that https://codereview.chromium.org/2395083003 caused the regression. It also happens without the change if you click the window's title bar to drag the window around.

I think the real issue is the gray of the cast icon. I don't know if there are two different versions, one for normal and another for Incognito, but the icon is not visible as long as you press the cast button.

Comment 4 by hdodda@chromium.org, Jan 13 2017 

Still we are able to reproduce the issue on Mac 10.12.2 with  latest Canary #57.0.2980.0.

rsesek@ Please take a look into this issue & update the thread.

Thanks.

Comment 5 by sureshkumari@chromium.org, Jan 19 2017 

Still we are able to reproduce the issue on Mac-10.12.2 using Chrome canary 57.0.2986.0.

rsesek@ Please take a look into this issue.

Thanks..

Comment 6 by mfo...@chromium.org, Mar 22 2017

Cc: rsesek@chromium.org
Components: Internals>Cast>UI
Labels: -Pri-1 Pri-2
Owner: ----
Status: Available (was: Assigned)
If this still reproduces, we can consider generating a custom icon for incognito windows.

Comment 7 by mfo...@chromium.org, Mar 22 2017

Components: -Platform>Extensions

Comment 8 by amp@chromium.org, Mar 30 2018

Mergedinto: 770514
Status: Duplicate (was: Available)
►

Sign in to add a comment