Issue metadata
Sign in to add a comment
|
Regression: Spacing issue is seen between faint text and omnibox border.
Reported by
lpa...@etouch.net,
Nov 24 2016
|
||||||||||||||||||||||
Issue descriptionVersion: 57.0.2929.4 (Official Build) canary 82367cc74e9f970cf4cfe84f62db913f06d0fc95-refs/branch-heads/2929@{#5} (64-bit) OS: Mac (10.11.6, 10.12.1) What steps will reproduce the problem? 1) Launch chrome and open a New tab. 2) In omnibox, type bing.com and observe the right side of omnibox. Spacing issue is seen between faint text and omnibox. Spacing issue should not be seen between faint text and omnibox. This is a Regression issue broken in M-56, will soon update other info Manual bisect: Good build: 56.0.2908.0 Bad build: 56.0.2909.0 Note: Issue is not seen on Windows and Linux OS.
,
Dec 5 2016
Able to reproduce the issue on Mac 10.11.6 using chrome version 57.0.2939.0. spqchan@ could you please look into this issue. Thanks,
,
Dec 5 2016
I will look into it once I have the chance
,
Jan 4 2017
Just to update, still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2970.0. Thanks...!!
,
Jan 23 2017
Just to update, still able to reproduce this issue on Mac 10.12.2 using latest canary #57.0.2989.0. Thanks!
,
Jan 25 2017
,
Jan 25 2017
@sdy, since you said you're taking some UI bugs, can you work on this? Feel free to reassign to me if you don't want to. Thanks!
,
Feb 6 2017
This fix should also include a test to ensure that the spacing does not regress.
,
Feb 21 2017
Friendly ping!! Still we are able to reproduce the issue on mac 10.12.2 using latest Canary-58.0.3018.0. sdy@Could you please look into this issue & update the thread. Thank you!!
,
Feb 23 2017
Ping received.
,
Mar 1 2017
Just to an Update Issue is still seen on mac 10.12.3 with latest canary(58.0.3026.0) sdy@: Could you please take a look at this and provide the latest update.
,
Mar 4 2017
,
Mar 6 2017
,
Mar 15 2017
,
Mar 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6d41b083683603ccb42c1d01c0389d12c219cb8 commit e6d41b083683603ccb42c1d01c0389d12c219cb8 Author: spqchan <spqchan@chromium.org> Date: Fri Mar 17 04:54:48 2017 [Mac] Added missing right padding for keyword hint BUG= 668380 Review-Url: https://codereview.chromium.org/2753103002 Cr-Commit-Position: refs/heads/master@{#457687} [modify] https://crrev.com/e6d41b083683603ccb42c1d01c0389d12c219cb8/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm
,
Mar 17 2017
,
Mar 18 2017
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ab1f101d05be92332f8c4a8532f6807e580c0568 commit ab1f101d05be92332f8c4a8532f6807e580c0568 Author: lgrey <lgrey@chromium.org> Date: Mon Mar 20 15:13:20 2017 [Mac] Fix keyword hint spacing in RTL BUG= 668380 Review-Url: https://codereview.chromium.org/2755163002 Cr-Commit-Position: refs/heads/master@{#458064} [modify] https://crrev.com/ab1f101d05be92332f8c4a8532f6807e580c0568/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm
,
Mar 21 2017
Note: Verified the above issue on latest Canary # 59.0.3047.0 on Mac OS (10.11.6, 10.12.1). The issue is fixed and working as intended.
,
Mar 21 2017
,
Mar 21 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Mar 27 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6d326645bf0aeb91943f247cc7f65b6531dd890a commit 6d326645bf0aeb91943f247cc7f65b6531dd890a Author: spqchan <spqchan@chromium.org> Date: Mon Mar 27 17:20:09 2017 [Mac] Fix keyword hint spacing in RTL BUG= 668380 Review-Url: https://codereview.chromium.org/2755163002 Cr-Commit-Position: refs/heads/master@{#458064} (cherry picked from commit ab1f101d05be92332f8c4a8532f6807e580c0568) [Mac] Added missing right padding for keyword hint BUG= 668380 Review-Url: https://codereview.chromium.org/2753103002 Cr-Commit-Position: refs/heads/master@{#457687} (cherry picked from commit e6d41b083683603ccb42c1d01c0389d12c219cb8) Review-Url: https://codereview.chromium.org/2772383002 . Cr-Commit-Position: refs/branch-heads/3029@{#427} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} [modify] https://crrev.com/6d326645bf0aeb91943f247cc7f65b6531dd890a/chrome/browser/ui/cocoa/location_bar/keyword_hint_decoration.mm
,
Mar 27 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by msrchandra@chromium.org
, Nov 24 2016Owner: spqc...@chromium.org
Status: Assigned (was: Unconfirmed)