New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668374 link

Starred by 1 user
Status: Fixed
Owner:
█ catmulli...@chromium.org
Last visit > 30 days ago
Closed: Dec 2016
Cc:
rdevlin....@chromium.org
nyerramilli@chromium.org
█ tkonch...@chromium.org
█ msrchandra@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Learn More' link is misplaced on Disable 'Disable developer mode extension' bubble.

Reported by dmascare...@etouch.net, Nov 24 2016 
Chrome Version:57.0.2929.4 82367cc74e9f970cf4cfe84f62db913f06d0fc95-refs/branch-heads/2929@{#5} 64 bit
OS:MAC (10.11.6, 10.12.1)

Precondition : 'V2 app' (i.e. calculator) should be installed and developer mode should be enabled from chrome://extensions.

What steps will reproduce the problem?
1. Launch chrome and observe 'Learn more' link of 'Disable developer mode extension' bubble.

Actual:'Learn More' link is misplaced.
Expected:'Learn More' link should be at proper position.

This is regression issue, broken in 'M 56' and below is manual bisect info.

Good build:56.0.2907.0
Bad build:56.0.2908.0 

Note: Issue is not seen on Windows and Linux OS.
bubble.png
112 KB View Download

Comment 1 by msrchandra@chromium.org, Nov 24 2016

Labels: hasbisect-per-revision ReleaseBlock-Stable
Owner: catmulli...@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 56.0.2907.0 (Revision: 429169).
Bad build: 56.0.2908.0 (Revision: 429486).

You are probably looking for a change made after 429375 (known good), but no later than 429376 (first known bad).
CHANGELOG URL:
  https://chromium.googlesource.com/chromium/src/+log/49f47242e1c13505573e4c469a5f61f7f65f886b..22bc237867193148a4a4e14ac925a41905fff817

@catmullings -- Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.
Adding RB Label as this is a recent Regression.

Thank You.

Comment 2 by tkonch...@chromium.org, Nov 30 2016

Cc: tkonch...@chromium.org
catmullings@, Can we get an update on this please

Comment 3 by catmulli...@chromium.org, Nov 30 2016 

I have looked into this, and I am confirming that the crash is indeed caused by https://codereview.chromium.org/2206693002

I am currently implementing a fix.

Comment 4 by catmulli...@chromium.org, Dec 1 2016

Cc: rdevlin....@chromium.org
The fix has been implemented (see screenshot).

Landing the CL shortly.
learnMoreButtonFix.png
55.1 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 1 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aebc5dfefce04c8a258d43cf6061b94b6fbe241d

commit aebc5dfefce04c8a258d43cf6061b94b6fbe241d
Author: catmullings <catmullings@chromium.org>
Date: Thu Dec 01 23:26:26 2016

Fix learn more button positioning

Fix regression in which the Learn more button is right aligned on the
x-position, when instead it should be left aligned.

BUG= 668374 

Review-Url: https://codereview.chromium.org/2539293002
Cr-Commit-Position: refs/heads/master@{#435755}

[modify] https://crrev.com/aebc5dfefce04c8a258d43cf6061b94b6fbe241d/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm

Comment 6 by catmulli...@chromium.org, Dec 5 2016

Labels: Merge-Request-56
Status: Fixed (was: Assigned)

Comment 7 by dimu@chromium.org, Dec 5 2016

Labels: -Merge-Request-56 Merge-Approved-56 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M56 (branch: 2924)
Project Member

Comment 8 by bugdroid1@chromium.org, Dec 5 2016

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/037bdb35492ade172dda0e026f9c2ee50dcb36b0

commit 037bdb35492ade172dda0e026f9c2ee50dcb36b0
Author: Devlin Cronin <rdevlin.cronin@chromium.org>
Date: Mon Dec 05 21:01:34 2016

Fix learn more button positioning

Fix regression in which the Learn more button is right aligned on the
x-position, when instead it should be left aligned.

BUG= 668374 

Review-Url: https://codereview.chromium.org/2539293002
Cr-Commit-Position: refs/heads/master@{#435755}
(cherry picked from commit aebc5dfefce04c8a258d43cf6061b94b6fbe241d)

Review URL: https://codereview.chromium.org/2555553002 .

Cr-Commit-Position: refs/branch-heads/2924@{#341}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/037bdb35492ade172dda0e026f9c2ee50dcb36b0/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
►

Sign in to add a comment