New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668366 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Nov 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Bookmark bar doesn't open and close continuously on long pressing "Ctrl + Shift + B" key from keyboard.

Reported by adha...@etouch.net, Nov 24 2016

Issue description

Chrome Version: 57.0.2929.3 (Official Build) 3619fbd7f57a1d171fac4d4adedde499f17eec95-refs/branch-heads/2929@{#3} 32/64-bit.
OS: Windows (7,8,10).

What steps will reproduce the problem?
1. Launch chrome and go to NTP or any webpage.
2. Long press "Ctrl + Shift + B" key from keyboard and observe the bookmark bar.

Bookmark bar doesn't open and close continuously.
Bookmark bar should open and close continuously.

This is a regression issue, broken in M-55 series, below is manual regression range.

Good build: 55.0.2853.0
Bad build: 55.0.2855.0

Note: This issue is not seen on Mac and Linux OS.

Kindly review the attached screen-cast for reference.
 
Bookmark_Actual.mp4
371 KB View Download
Bookmark_Expected.mp4
485 KB View Download
Labels: Needs-Bisect
Status: Untriaged (was: Unconfirmed)
Cc: kkaluri@chromium.org
Labels: -Needs-Bisect hasbisect-per-revision
Owner: derat@chromium.org
Status: Assigned (was: Untriaged)
Bisect Info:
===========

Good build : 55.0.2853.0,  Revision Range 	416812
Bad build  : 55.0.2855.0,  Revision Range 	417475	

After executing the per-revision-bisect script, i got the following CL's between good and bad build versions
===========================================
https://chromium.googlesource.com/chromium/src/+log/ee7a59389604bc254617c71ef53aaf0eaf9c7237..42d287c9658c6bfa1202275597f28399409e8603

The suspecting Change Log is :
-----------
https://chromium.googlesource.com/chromium/src/+/42d287c9658c6bfa1202275597f28399409e8603

From the above CL suspecting the below change
---------------------------
https://codereview.chromium.org/2128243003


derat@- Could you please look into this issue, if it's related to your change?  if not could you please help us to reassign this issue to the right owner.

Labels: ReleaseBlock-Stable
Adding RB Label as this is a recent Regression. Please remove if not required.
Thank You.

Comment 4 by derat@chromium.org, Nov 25 2016

Status: WontFix (was: Assigned)
Please don't file any more bugs about non-repeating keyboard accelerators. This is clearly an intentional effect of the change that you linked to above (its title is "Make most browser accelerators not repeat."). Why would anyone want Ctrl-Shift-B to make the bookmark bar open and close continuously?

Sign in to add a comment