Issue 668358 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	█ kozyatinskiy@chromium.org Last visit > 30 days ago
Closed:	Dec 2016
Cc:	hablich@chromium.org █ kozyatinskiy@chromium.org dgozman@chromium.org
Components:	Platform>DevTools
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug-Regression
Stability-Memory-AddressSanitizer

A bunch of layout tests for inspector are failing on chromium.webkit/WebKit Linux Trusty ASAN

Project Member Reported by nhiroki@chromium.org, Nov 24 2016

Issue description

webkit_tests failing on chromium.webkit/WebKit Linux Trusty ASAN

Type: build-failure

Builders failed on: 
- WebKit Linux Trusty ASAN: 
  https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN

Comment 1 by nhiroki@chromium.org, Nov 24 2016

These failrues started at this build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty%20ASAN/builds/111

Probably this V8 roll causes the failures:
https://chromium.googlesource.com/chromium/src/+/539548342b360503fa229181f06a453618b3baf9

This roll contains inspector changes:
https://chromium.googlesource.com/v8/v8/+log/4d8f55ba..e037fad8

Comment 2 by nhiroki@chromium.org, Nov 24 2016

Labels: Stability-Memory-AddressSanitizer

Comment 3 by nhiroki@chromium.org, Nov 24 2016

# Sample log

08:17:37.437 24280 worker/0 http/tests/inspector/console-show-all-messages.html crashed, (stderr lines):
08:17:37.437 24280   [15050:15050:1123/081729:2321938449:WARNING:audio_manager.cc(317)] Multiple instances of AudioManager detected
08:17:37.437 24280   [15050:15050:1123/081729:2321938695:WARNING:audio_manager.cc(278)] Multiple instances of AudioManager detected
08:17:37.437 24280   Xlib:  extension "RANDR" missing on display ":9".
08:17:37.437 24280   Xlib:  extension "RANDR" missing on display ":9".
08:17:37.437 24280   =================================================================
08:17:37.437 24280   ==1==ERROR: AddressSanitizer: heap-use-after-free on address 0x60c0000a237c at pc 0x000002abc0dc bp 0x7ffebb34a610 sp 0x7ffebb34a608
08:17:37.437 24280   READ of size 1 at 0x60c0000a237c thread T0 (content_shell)
08:17:37.437 24280       #0 0x2abc0db in lastCallbackFallThrough ./out/Release/gen/v8/src/inspector/protocol/Protocol.h:848:45
08:17:37.437 24280       #1 0x2abc0db in evaluate ./out/Release/gen/v8/src/inspector/protocol/Runtime.cpp:1318:0
08:17:37.437 24280       #2 0x2ab289b in dispatch ./out/Release/gen/v8/src/inspector/protocol/Runtime.cpp:1224:12
08:17:37.437 24280       #3 0x2955228 in dispatch ./out/Release/gen/v8/src/inspector/protocol/Protocol.cpp:813:24
08:17:37.437 24280       #4 0x2c2e953 in dispatchProtocolMessage v8/src/inspector/v8-inspector-session-impl.cc:337:16
08:17:37.437 24280       #5 0x9208d9a in dispatchProtocolMessage third_party/WebKit/Source/core/inspector/InspectorSession.cpp:82:18
08:17:37.437 24280       #6 0x7832b7f in dispatchMessageFromFrontend third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:588:14
08:17:37.437 24280       #7 0x7832b7f in dispatchOnInspectorBackend third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:578:0
08:17:37.437 24280       #8 0x7165688 in OnDispatchOnInspectorBackend content/renderer/devtools/devtools_agent.cc:266:18
08:17:37.437 24280       #9 0x7164fd9 in DispatchToMethodImpl<content::DevToolsAgent *, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), const std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > &, 0, 1, 2, 3> base/tuple.h:143:3
08:17:37.437 24280       #10 0x7164fd9 in DispatchToMethod<content::DevToolsAgent *, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), const std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > &> base/tuple.h:150:0
08:17:37.437 24280       #11 0x7164fd9 in DispatchToMethod<content::DevToolsAgent, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), void, std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > > ipc/ipc_message_templates.h:26:0
08:17:37.437 24280       #12 0x7164fd9 in Dispatch<content::DevToolsAgent, content::DevToolsAgent, void, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &)> ipc/ipc_message_templates.h:121:0
08:17:37.437 24280       #13 0x716352f in OnMessageReceived content/renderer/devtools/devtools_agent.cc:107:5
08:17:37.437 24280       #14 0x6e21477 in OnMessageReceived content/renderer/render_frame_impl.cc:1485:18
08:17:37.437 24280       #15 0x6d056f9 in OnMessageReceived content/child/child_thread_impl.cc:795:18
08:17:37.437 24280       #16 0x469bcba in OnDispatchMessage ipc/ipc_channel_proxy.cc:340:14
08:17:37.438 24280       #17 0x428cdff in Run base/callback.h:68:12
08:17:37.438 24280       #18 0x428cdff in RunTask base/debug/task_annotator.cc:52:0
08:17:37.438 24280       #19 0x76b20b7 in ProcessTaskFromWorkQueue third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:358:19
08:17:37.438 24280       #20 0x76ae499 in DoWork third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:250:13
08:17:37.438 24280       #21 0x428cdff in Run base/callback.h:68:12
08:17:37.438 24280       #22 0x428cdff in RunTask base/debug/task_annotator.cc:52:0
08:17:37.438 24280       #23 0x415b1e0 in RunTask base/message_loop/message_loop.cc:413:19
08:17:37.438 24280       #24 0x415bad5 in DeferOrRunPendingTask base/message_loop/message_loop.cc:422:5
08:17:37.438 24280       #25 0x415c95e in DoWork base/message_loop/message_loop.cc:515:13
08:17:37.438 24280       #26 0x4164e80 in Run base/message_loop/message_pump_default.cc:35:31
08:17:37.438 24280       #27 0x415a950 in RunHandler base/message_loop/message_loop.cc:378:10
08:17:37.438 24280       #28 0x41afff5 in Run base/run_loop.cc:35:10
08:17:37.438 24280       #29 0x6f4150f in RendererMain content/renderer/renderer_main.cc:200:23
08:17:37.438 24280       #30 0x2fbf349 in RunZygote content/app/content_main_runner.cc:337:14
08:17:37.438 24280       #31 0x2fc20e9 in Run content/app/content_main_runner.cc:775:12
08:17:37.438 24280       #32 0x2fae5ba in ContentMain content/app/content_main.cc:20:28
08:17:37.438 24280       #33 0x516f8d in main content/shell/app/shell_main.cc:48:10
08:17:37.438 24280       #34 0x7f6296268f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0
08:17:37.438 24280
08:17:37.438 24280   0x60c0000a237c is located 60 bytes inside of 120-byte region [0x60c0000a2340,0x60c0000a23b8)
08:17:37.438 24280   freed by thread T0 (content_shell) here:
08:17:37.438 24280       #0 0x51495b in operator delete(void*) ??:?
08:17:37.438 24280       #1 0x296087e in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
08:17:37.438 24280       #2 0x296087e in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
08:17:37.438 24280       #3 0x296087e in ~unique_ptr buildtools/third_party/libc++/trunk/include/memory:2703:0
08:17:37.438 24280       #4 0x296087e in ~pair buildtools/third_party/libc++/trunk/include/utility:280:0
08:17:37.438 24280       #5 0x296087e in ~__hash_value_type buildtools/third_party/libc++/trunk/include/unordered_map:624:0
08:17:37.438 24280       #6 0x296087e in __destroy<std::__1::__hash_value_type<v8_inspector::String16, std::__1::unique_ptr<v8_inspector::protocol::DispatcherBase, std::__1::default_delete<v8_inspector::protocol::DispatcherBase> > > > buildtools/third_party/libc++/trunk/include/memory:1673:0
08:17:37.438 24280       #7 0x296087e in destroy<std::__1::__hash_value_type<v8_inspector::String16, std::__1::unique_ptr<v8_inspector::protocol::DispatcherBase, std::__1::default_delete<v8_inspector::protocol::DispatcherBase> > > > buildtools/third_party/libc++/trunk/include/memory:1536:0
08:17:37.438 24280       #8 0x296087e in __deallocate buildtools/third_party/libc++/trunk/include/__hash_table:1322:0
08:17:37.438 24280       #9 0x296087e in ~__hash_table buildtools/third_party/libc++/trunk/include/__hash_table:1262:0
08:17:37.438 24280       #10 0x296087e in ~unordered_map buildtools/third_party/libc++/trunk/include/unordered_map:772:0
08:17:37.438 24280       #11 0x296087e in ~UberDispatcher ./out/Release/gen/v8/src/inspector/protocol/Protocol.cpp:816:0
08:17:37.438 24280       #12 0x2c25ad2 in ~V8InspectorSessionImpl v8/src/inspector/v8-inspector-session-impl.cc:115:1
08:17:37.438 24280       #13 0x2c265bd in ?? v8/src/inspector/v8-inspector-session-impl.cc:106:51
08:17:37.438 24280       #14 0x92088e8 in operator() buildtools/third_party/libc++/trunk/include/memory:2529:13
08:17:37.438 24280       #15 0x92088e8 in reset buildtools/third_party/libc++/trunk/include/memory:2735:0
08:17:37.439 24280       #16 0x92088e8 in dispose third_party/WebKit/Source/core/inspector/InspectorSession.cpp:74:0
08:17:37.439 24280       #17 0x782f51b in destroySession third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:473:14
08:17:37.439 24280       #18 0x782f51b in detach third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:498:0
08:17:37.439 24280       #19 0xb53d36f in Run base/callback.h:85:12
08:17:37.439 24280       #20 0xb53d36f in DispatchToCallback gin/function_template.h:183:0
08:17:37.439 24280       #21 0xb53d36f in DispatchToCallback gin/function_template.h:217:0
08:17:37.439 24280       #22 0x101c1ae in Call v8/src/api-arguments.cc:19:3
08:17:37.439 24280       #23 0x11aaa7a in HandleApiCallHelper<false> v8/src/builtins/builtins-api.cc:106:36
08:17:37.439 24280       #24 0x11a80de in Builtin_Impl_HandleApiCall v8/src/builtins/builtins-api.cc:135:5
08:17:37.439 24280       #10 0x7f62641843a6  (<unknown module>)
08:17:37.439 24280       #11 0x7f626429ed11  (<unknown module>)
08:17:37.439 24280       #12 0x7f626429e02d  (<unknown module>)
08:17:37.439 24280       #13 0x7f626429d892  (<unknown module>)
08:17:37.439 24280       #14 0x7f62641f0ac2  (<unknown module>)
08:17:37.439 24280       #15 0x7f62641b6700  (<unknown module>)
08:17:37.439 24280       #25 0x1ad369e in Invoke v8/src/execution.cc:139:13
08:17:37.439 24280       #26 0x1ad2ec2 in Call v8/src/execution.cc:176:10
08:17:37.439 24280       #27 0x103784e in Run v8/src/api.cc:1946:7
08:17:37.439 24280       #28 0x2c16bfb in runCompiledScript v8/src/inspector/v8-inspector-impl.cc:89:46
08:17:37.439 24280       #29 0x2c4af21 in evaluate v8/src/inspector/v8-runtime-agent-impl.cc:299:37
08:17:37.439 24280       #30 0x2aba259 in evaluate ./out/Release/gen/v8/src/inspector/protocol/Runtime.cpp:1317:16
08:17:37.439 24280       #31 0x2ab289b in dispatch ./out/Release/gen/v8/src/inspector/protocol/Runtime.cpp:1224:12
08:17:37.439 24280       #32 0x2955228 in dispatch ./out/Release/gen/v8/src/inspector/protocol/Protocol.cpp:813:24
08:17:37.439 24280       #33 0x2c2e953 in dispatchProtocolMessage v8/src/inspector/v8-inspector-session-impl.cc:337:16
08:17:37.439 24280       #34 0x9208d9a in dispatchProtocolMessage third_party/WebKit/Source/core/inspector/InspectorSession.cpp:82:18
08:17:37.439 24280       #35 0x7832b7f in dispatchMessageFromFrontend third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:588:14
08:17:37.439 24280       #36 0x7832b7f in dispatchOnInspectorBackend third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:578:0
08:17:37.439 24280       #37 0x7165688 in OnDispatchOnInspectorBackend content/renderer/devtools/devtools_agent.cc:266:18
08:17:37.439 24280       #38 0x7164fd9 in DispatchToMethodImpl<content::DevToolsAgent *, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), const std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > &, 0, 1, 2, 3> base/tuple.h:143:3
08:17:37.439 24280       #39 0x7164fd9 in DispatchToMethod<content::DevToolsAgent *, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), const std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > &> base/tuple.h:150:0
08:17:37.439 24280       #40 0x7164fd9 in DispatchToMethod<content::DevToolsAgent, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &), void, std::__1::tuple<int, int, std::__1::basic_string<char>, std::__1::basic_string<char> > > ipc/ipc_message_templates.h:26:0
08:17:37.439 24280       #41 0x7164fd9 in Dispatch<content::DevToolsAgent, content::DevToolsAgent, void, void (content::DevToolsAgent::*)(int, int, const std::__1::basic_string<char> &, const std::__1::basic_string<char> &)> ipc/ipc_message_templates.h:121:0
08:17:37.439 24280       #42 0x716352f in OnMessageReceived content/renderer/devtools/devtools_agent.cc:107:5
08:17:37.439 24280
08:17:37.439 24280   previously allocated by thread T0 (content_shell) here:
08:17:37.439 24280       #0 0x513d1b in operator new(unsigned long) ??:?
08:17:37.439 24280       #1 0x2adbaf5 in wire ./out/Release/gen/v8/src/inspector/protocol/Runtime.cpp:1753:86
08:17:37.439 24280       #2 0x2c23016 in V8InspectorSessionImpl v8/src/inspector/v8-inspector-session-impl.cc:74:3
08:17:37.440 24280       #3 0x2c2261f in create v8/src/inspector/v8-inspector-session-impl.cc:44:11
08:17:37.440 24280       #4 0x2c184aa in connect v8/src/inspector/v8-inspector-impl.cc:191:7
08:17:37.440 24280       #5 0x92078db in InspectorSession third_party/WebKit/Source/core/inspector/InspectorSession.cpp:47:28
08:17:37.440 24280       #6 0x782f810 in initializeSession third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:375:19
08:17:37.440 24280       #7 0x7831f08 in attach third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:482:3
08:17:37.440 24280       #8 0x7163ef1 in OnAttach content/renderer/devtools/devtools_agent.cc:237:18
08:17:37.440 24280       #9 0x7163a0e in DispatchToMethodImpl<content::DevToolsAgent *, void (content::DevToolsAgent::*)(const std::__1::basic_string<char> &, int), const std::__1::tuple<std::__1::basic_string<char>, int> &, 0, 1> base/tuple.h:143:3
08:17:37.440 24280       #10 0x7163a0e in DispatchToMethod<content::DevToolsAgent *, void (content::DevToolsAgent::*)(const std::__1::basic_string<char> &, int), const std::__1::tuple<std::__1::basic_string<char>, int> &> base/tuple.h:150:0
08:17:37.440 24280       #11 0x7163a0e in DispatchToMethod<content::DevToolsAgent, void (content::DevToolsAgent::*)(const std::__1::basic_string<char> &, int), void, std::__1::tuple<std::__1::basic_string<char>, int> > ipc/ipc_message_templates.h:26:0
08:17:37.440 24280       #12 0x7163a0e in Dispatch<content::DevToolsAgent, content::DevToolsAgent, void, void (content::DevToolsAgent::*)(const std::__1::basic_string<char> &, int)> ipc/ipc_message_templates.h:121:0
08:17:37.440 24280       #13 0x7163223 in OnMessageReceived content/renderer/devtools/devtools_agent.cc:104:5
08:17:37.440 24280       #14 0x6e21477 in OnMessageReceived content/renderer/render_frame_impl.cc:1485:18
08:17:37.440 24280       #15 0x6d056f9 in OnMessageReceived content/child/child_thread_impl.cc:795:18
08:17:37.440 24280       #16 0x469bcba in OnDispatchMessage ipc/ipc_channel_proxy.cc:340:14
08:17:37.440 24280       #17 0x428cdff in Run base/callback.h:68:12
08:17:37.440 24280       #18 0x428cdff in RunTask base/debug/task_annotator.cc:52:0
08:17:37.440 24280       #19 0x76b20b7 in ProcessTaskFromWorkQueue third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:358:19
08:17:37.440 24280       #20 0x76ae499 in DoWork third_party/WebKit/Source/platform/scheduler/base/task_queue_manager.cc:250:13
08:17:37.440 24280       #21 0x428cdff in Run base/callback.h:68:12
08:17:37.440 24280       #22 0x428cdff in RunTask base/debug/task_annotator.cc:52:0
08:17:37.440 24280       #23 0x415b1e0 in RunTask base/message_loop/message_loop.cc:413:19
08:17:37.440 24280       #24 0x415bad5 in DeferOrRunPendingTask base/message_loop/message_loop.cc:422:5
08:17:37.440 24280       #25 0x415c95e in DoWork base/message_loop/message_loop.cc:515:13
08:17:37.440 24280       #26 0x4164e80 in Run base/message_loop/message_pump_default.cc:35:31
08:17:37.440 24280       #27 0x415a950 in RunHandler base/message_loop/message_loop.cc:378:10
08:17:37.440 24280       #28 0x41afff5 in Run base/run_loop.cc:35:10
08:17:37.440 24280       #29 0x6f4150f in RendererMain content/renderer/renderer_main.cc:200:23
08:17:37.440 24280       #30 0x2fbf349 in RunZygote content/app/content_main_runner.cc:337:14
08:17:37.440 24280       #31 0x2fc20e9 in Run content/app/content_main_runner.cc:775:12
08:17:37.440 24280       #32 0x2fae5ba in ContentMain content/app/content_main.cc:20:28
08:17:37.440 24280       #33 0x516f8d in main content/shell/app/shell_main.cc:48:10
08:17:37.440 24280       #34 0x7f6296268f44 in __libc_start_main /build/eglibc-oGUzwX/eglibc-2.19/csu/libc-start.c:287:0
08:17:37.440 24280
08:17:37.440 24280   SUMMARY: AddressSanitizer: heap-use-after-free (/b/c/b/linux_layout/src/out/Release/content_shell+0x2abc0db)
08:17:37.440 24280   Shadow bytes around the buggy address:
08:17:37.440 24280     0x0c188000c410: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
08:17:37.440 24280     0x0c188000c420: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd
08:17:37.440 24280     0x0c188000c430: fa fa fa fa fa fa fa fa 00 00 00 00 00 00 00 00
08:17:37.441 24280     0x0c188000c440: 00 00 00 00 00 00 00 00 fa fa fa fa fa fa fa fa
08:17:37.441 24280     0x0c188000c450: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
08:17:37.441 24280   =>0x0c188000c460: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd[fd]
08:17:37.441 24280     0x0c188000c470: fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa fa
08:17:37.441 24280     0x0c188000c480: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
08:17:37.441 24280     0x0c188000c490: fa fa fa fa fa fa fa fa fd fd fd fd fd fd fd fd
08:17:37.441 24280     0x0c188000c4a0: fd fd fd fd fd fd fd fd fa fa fa fa fa fa fa fa
08:17:37.441 24280     0x0c188000c4b0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fa
08:17:37.441 24280   Shadow byte legend (one shadow byte represents 8 application bytes):
08:17:37.441 24280     Addressable:           00
08:17:37.441 24280     Partially addressable: 01 02 03 04 05 06 07
08:17:37.441 24280     Heap left redzone:       fa
08:17:37.441 24280     Freed heap region:       fd
08:17:37.441 24280     Stack left redzone:      f1
08:17:37.441 24280     Stack mid redzone:       f2
08:17:37.441 24280     Stack right redzone:     f3
08:17:37.441 24280     Stack after return:      f5
08:17:37.441 24280     Stack use after scope:   f8
08:17:37.441 24280     Global redzone:          f9
08:17:37.441 24280     Global init order:       f6
08:17:37.441 24280     Poisoned by user:        f7
08:17:37.441 24280     Container overflow:      fc
08:17:37.441 24280     Array cookie:            ac
08:17:37.441 24280     Intra object redzone:    bb
08:17:37.441 24280     ASan internal:           fe
08:17:37.441 24280     Left alloca redzone:     ca
08:17:37.441 24280     Right alloca redzone:    cb
08:17:37.442 24280   [15050:15379:1123/081734:2326497579:WARNING:crash_handler_host_linux.cc(324)] Could not translate tid, attempt = 1 retry ...
08:17:37.442 24280   ==1==ABORTING
08:17:37.468 24201 [5449/43191] http/tests/inspector/console-show-all-messages.html failed unexpectedly (renderer crashed)

Comment 4 by dgozman@chromium.org, Nov 24 2016

Owner: kozyatinskiy@chromium.org
Status: Assigned (was: Available)

I think this is https://chromium.googlesource.com/v8/v8/+/211a6a86370e476bf1dad21970a7f68c44e1ebf9

Comment 5 by dgozman@chromium.org, Nov 24 2016

We should only call lastCallbackFallThrough using weak pointer, since |this| could be deleted already.

Comment 6 by nhiroki@chromium.org, Nov 24 2016

kozyatinskiy@, dgozman@: Are you able to fix or revert it soon? If it's difficult  (I understand it's 10:30 PM in US now), I'll attempt to revert it :)

Comment 7 by kozyatinskiy@chromium.org, Nov 24 2016

It can be not trivial to revert it, two of depended CLs was landed to V8 and blink.
Here is a list:
blink: https://codereview.chromium.org/2522583002/ (last one)
v8: https://codereview.chromium.org/2523583005/
v8: https://codereview.chromium.org/2523743003/

You probably need to revert all of them. I can try to fix it in first half of the day tomorrow.
I've a question: why V8 was successfully rolled to blink with this change? Do we run "chromium.webkit/WebKit Linux Trusty ASAN" for commits to blink (including v8-autoroll)?

Comment 8 by nhiroki@chromium.org, Nov 24 2016

Status: Started (was: Assigned)

(Status Update) kozyatinskiy@ is now working on a workaround for this.

Comment 9 by machenb...@chromium.org, Nov 24 2016

I don't believe there is a webkit linux ASAN bot in the CQ. Therefore I wouldn't be happy about a roll revert (reverting the work of many other people). If somebody decides to revert the list of single CLs, I can help routing them into the next roll faster.

Comment 10 by machenb...@chromium.org, Nov 24 2016

Filed http://crbug.com/668391 to get more coverage.

Comment 11 by kozyatinskiy@chromium.org, Nov 24 2016

I uploaded partial revert in https://codereview.chromium.org/2526183002/ and checked that locally it fixed an issue. I'll figure out better solution after holidays.
Feel free to revert all 4 patches if it won't help or I can revert them tomorrow by myself.

Comment 12 by machenb...@chromium.org, Nov 24 2016

Thanks, I try to route this CL into the latest v8 roll.

Comment 13 by machenb...@chromium.org, Nov 24 2016

Cc: hablich@chromium.org

Project Member

Comment 14 by bugdroid1@chromium.org, Nov 24 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/4f798f9065e547074f86df7e45b576387ee82678

commit 4f798f9065e547074f86df7e45b576387ee82678
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Nov 24 08:09:10 2016

[inspector] revert fallThrough support for async methods

We can't use "this" after calling agent code since agent code can destroy dispatcher.

BUG= chromium:668358 
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2526183002
Cr-Commit-Position: refs/heads/master@{#41247}

[modify] https://crrev.com/4f798f9065e547074f86df7e45b576387ee82678/third_party/inspector_protocol/README.v8
[modify] https://crrev.com/4f798f9065e547074f86df7e45b576387ee82678/third_party/inspector_protocol/templates/TypeBuilder_cpp.template

Comment 15 by machenb...@chromium.org, Nov 24 2016

Roll with the partial revert:
https://codereview.chromium.org/2528883002/

Comment 16 Deleted

Comment 17 by kolos@chromium.org, Nov 24 2016

Labels: -Infra-Troopers

Comment 18 by kolos@chromium.org, Nov 24 2016

Labels: -Sheriff-Chromium

The builder is green.

Comment 19 by machenb...@chromium.org, Nov 24 2016

Labels: -Pri-1 Pri-2

Lower prio as build is green now...

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/d6c2f4de9dfceff79bcabf26e27e36ac2af358b3

commit d6c2f4de9dfceff79bcabf26e27e36ac2af358b3
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Dec 01 01:35:00 2016

Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896

This roll includes:
  - [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} [1]

[1] https://codereview.chromium.org/2545613002/

BUG= chromium:668358 
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2541253002
Cr-Commit-Position: refs/heads/master@{#41402}

[modify] https://crrev.com/d6c2f4de9dfceff79bcabf26e27e36ac2af358b3/third_party/inspector_protocol/README.v8
[modify] https://crrev.com/d6c2f4de9dfceff79bcabf26e27e36ac2af358b3/third_party/inspector_protocol/templates/TypeBuilder_cpp.template

Comment 21 by kozyatinskiy@chromium.org, Dec 1 2016

Status: Fixed (was: Started)

Project Member

Comment 22 by bugdroid1@chromium.org, Dec 1 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a85a4adb7d94f780e42155e36fc7413fd0dd9d

commit 37a85a4adb7d94f780e42155e36fc7413fd0dd9d
Author: kozyatinskiy <kozyatinskiy@chromium.org>
Date: Thu Dec 01 02:47:14 2016

Roll third_party/inspector_protocol to 715b83a3cfb45ce6c67b6c6fdd2c16391b5db896

This roll includes:
  - [inspector_protocol] always use weak pointer in DispatcherImpl::{command.name} [1]

[1] https://codereview.chromium.org/2545613002/

BUG= chromium:668358 
TBR=dgozman@chromium.org

Review-Url: https://codereview.chromium.org/2538043003
Cr-Commit-Position: refs/heads/master@{#435535}

[modify] https://crrev.com/37a85a4adb7d94f780e42155e36fc7413fd0dd9d/third_party/inspector_protocol/README.chromium
[modify] https://crrev.com/37a85a4adb7d94f780e42155e36fc7413fd0dd9d/third_party/inspector_protocol/templates/TypeBuilder_cpp.template

►

Issue 668358 link

Issue metadata

A bunch of layout tests for inspector are failing on chromium.webkit/WebKit Linux Trusty ASAN

Issue description

Comment 1 by nhiroki@chromium.org, Nov 24 2016

Comment 1 Deleted

Comment 2 by nhiroki@chromium.org, Nov 24 2016

Comment 2 Deleted

Comment 3 by nhiroki@chromium.org, Nov 24 2016

Comment 3 Deleted

Comment 4 by dgozman@chromium.org, Nov 24 2016

Comment 4 Deleted

Comment 5 by dgozman@chromium.org, Nov 24 2016

Comment 5 Deleted

Comment 6 by nhiroki@chromium.org, Nov 24 2016

Comment 6 Deleted

Comment 7 by kozyatinskiy@chromium.org, Nov 24 2016

Comment 7 Deleted

Comment 8 by nhiroki@chromium.org, Nov 24 2016

Comment 8 Deleted

Comment 9 by machenb...@chromium.org, Nov 24 2016

Comment 9 Deleted

Comment 10 by machenb...@chromium.org, Nov 24 2016

Comment 10 Deleted

Comment 11 by kozyatinskiy@chromium.org, Nov 24 2016

Comment 11 Deleted

Comment 12 by machenb...@chromium.org, Nov 24 2016

Comment 12 Deleted

Comment 13 by machenb...@chromium.org, Nov 24 2016

Comment 13 Deleted

Comment 14 by bugdroid1@chromium.org, Nov 24 2016

Comment 14 Deleted

Comment 15 by machenb...@chromium.org, Nov 24 2016

Comment 15 Deleted

Comment 16 Deleted

Comment 17 by kolos@chromium.org, Nov 24 2016

Comment 17 Deleted

Comment 18 by kolos@chromium.org, Nov 24 2016

Comment 18 Deleted

Comment 19 by machenb...@chromium.org, Nov 24 2016

Comment 19 Deleted

Comment 20 by bugdroid1@chromium.org, Dec 1 2016

Comment 20 Deleted

Comment 21 by kozyatinskiy@chromium.org, Dec 1 2016

Comment 21 Deleted

Comment 22 by bugdroid1@chromium.org, Dec 1 2016

Comment 22 Deleted

Sign in to add a comment