New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668357 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Dec 2016
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mus: Decouple CreateDisplayCompositor from GpuServiceInternal

Project Member Reported by fsam...@chromium.org, Nov 24 2016

Issue description

Currently, "CreateDisplayCompositor" is part of the GpuServiceInternal interface. This causes all kinds of problems including a recent tear down deadlock/crash that I have addressed for the short term here: https://codereview.chromium.org/2525213002/

GpuServiceInternal largely lives on the gpu thread, and DisplayCompositor lives on the compositor thread.

In Jellyfish, we had a DisplayCompositorFactory interface that the display compositor host requested and then called "CreateDisplayCompositor" on that interface. We can do the same here. This would allow us to decouple from GpuServiceInternal and make tear down simpler.

Here's the jellyfish impl: https://github.com/danakj/chromium/blob/jellyfish/cc/service/display_compositor_factory.h

Here's the interface:

https://github.com/danakj/chromium/blob/jellyfish/cc/ipc/compositor.mojom
 
Blocking: 601863
Components: MUS
Labels: displaycompositor
Owner: fsam...@chromium.org
Status: Fixed (was: Untriaged)
Fixed as of: https://codereview.chromium.org/2539893002/
Blocking: -601863
Components: -Internals>MUS Internals>Services>WindowService
Components: -MUS

Sign in to add a comment