MD Settings: Weird focus state for Internet: network-summary-item. |
||||
Issue descriptionI noticed this in Internet settings, but a few other pages use the [selectable] attribute. Clicking different parts of the item show the selected style (grey background) on those parts. Clicking "Wi-Fi" selects the Wi-Fi text and icon. Clicking between "Wi-Fi" and the expand arrow button selects the Wi-Fi text and icon, but the selected style extends to the right until the arrow button. The [selectable] style applies to both itself and its children, which is why it's possible to make only part of the row grey. Should it just be one or the other?
,
Dec 1 2016
More specifically: 1. Ethernet/Cellular/WiMax (any section that doesn't expand) should have a focusable '>' button similar to other sections with subpages. 2. The sections themselves should not highlight, just the '>' button. 3. The Add Wi-Fi and Add VPN items should receive focus and have a '>' button.
,
Dec 8 2016
,
Dec 14 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72d4e57305352cfe734daa5390c1c23c91949830 commit 72d4e57305352cfe734daa5390c1c23c91949830 Author: stevenjb <stevenjb@chromium.org> Date: Wed Dec 14 02:19:17 2016 MD Settings: Fix internet focus and styling BUG= 668341 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2556253007 Cr-Commit-Position: refs/heads/master@{#438390} [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/chrome/browser/resources/settings/internet_page/internet_page.html [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/chrome/browser/resources/settings/internet_page/network_summary_item.html [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/chrome/browser/resources/settings/internet_page/network_summary_item.js [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/chrome/browser/resources/settings/settings_shared_css.html [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/cr_elements/network/cr_network_list_item.html [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/cr_elements/network/cr_network_list_item.js [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/cr_elements/shared_style_css.html [modify] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/cr_elements_resources.grdp [rename] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/images/arrow_right.svg [rename] https://crrev.com/72d4e57305352cfe734daa5390c1c23c91949830/ui/webui/resources/images/open_in_new.svg
,
Dec 14 2016
,
Dec 15 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f commit f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f Author: stevenjb <stevenjb@chromium.org> Date: Thu Dec 15 22:29:11 2016 MD Settings: Internet: Hide subpage arrow when disabled BUG= 668341 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2579433002 Cr-Commit-Position: refs/heads/master@{#438937} [modify] https://crrev.com/f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f/chrome/browser/resources/settings/internet_page/network_summary_item.html [modify] https://crrev.com/f9ed2ee38f7e2f0c9109be6d00552577aaaf2e7f/chrome/browser/resources/settings/internet_page/network_summary_item.js
,
Mar 23 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by steve...@chromium.org
, Nov 28 2016Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)
Summary: MD Settings: Weird focus state for Internet: network-summary-item. (was: MD Settings: Weird focus state for multi-part selectable items)