New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668339 link

Starred by 2 users
Status: Fixed
Owner:
█ kateso...@chromium.org
Last visit > 30 days ago
Closed: May 2017
Cc:
chanli@chromium.org
lijeffrey@chromium.org
st...@chromium.org
█ robert...@chromium.org
liaoyuke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Culprit-Finder] Use Mocked http client for some tests.

Project Member Reported by kateso...@chromium.org, Nov 24 2016 
[Culprit-Finder] Use Mocked http client for some tests.

Comment 1 by ajha@chromium.org, Nov 24 2016

Components: Tools>Test>Predator

Comment 2 by kateso...@chromium.org, Nov 29 2016

Components: Tools>Test>FindIt
Actually this is more for findit (previously findit for waterfall and flake checker) side tests.

Comment 3 by kateso...@chromium.org, Nov 29 2016 

Please use Mocked http client in TestCase (testcase.py in gae_libs) instead of defining new mocked http client class in each test file.

Comment 4 by kateso...@chromium.org, Nov 29 2016

Cc: wrengr@chromium.org
 Issue 660571  has been merged into this issue.

Comment 5 by st...@chromium.org, Apr 24 2017

Cc: -wrengr@chromium.org -kateso...@chromium.org
Components: -Tools>Test>Predator
Owner: kateso...@chromium.org
Status: Assigned (was: Available)
What's the expected usage here? Which code could be improved?

Comment 6 by kateso...@chromium.org, May 15 2017

Status: Fixed (was: Assigned)
I meant some old tests defined duplicate mock http client class as in ``base_testcase.py``.

But it seems those old tests already got cleaned up.
►

Sign in to add a comment