New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668317 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Provide a Mojo equivalent to content::ThreadSafeSender.

Project Member Reported by jcivelli@chromium.org, Nov 24 2016

Issue description

The goal is to provide for mojo something similar to content::ThreadSafeSender: a way to create an interface and call methods on it from any thread even before the channel is connected.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/315d17fc22a94a23657b7c52df283f5f93795e89

commit 315d17fc22a94a23657b7c52df283f5f93795e89
Author: jcivelli <jcivelli@chromium.org>
Date: Tue Nov 29 16:15:05 2016

Provide a Mojo equivalent of ThreadSafeSender.

Introduces the ThreadSafeAssociatedInterfacePtrProvider class that
provides functionalities similar to the content::ThreadSafeSender.
You create it with a ChannelProxy and you can then retrieve
ThreadSafeInterfacePtr's from it that you can call methods on from any
thread and even before the actual channel is connected.

BUG= 668317 

Review-Url: https://codereview.chromium.org/2522333002
Cr-Commit-Position: refs/heads/master@{#435005}

[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/content/renderer/BUILD.gn
[add] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/content/renderer/mojo/thread_safe_associated_interface_ptr_provider.h
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/content/renderer/render_thread_impl.cc
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/content/renderer/render_thread_impl.h
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/ipc/ipc_channel_proxy.h
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/mojo/public/cpp/bindings/tests/associated_interface_unittest.cc
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/mojo/public/cpp/bindings/tests/interface_ptr_unittest.cc
[modify] https://crrev.com/315d17fc22a94a23657b7c52df283f5f93795e89/mojo/public/cpp/bindings/thread_safe_interface_ptr.h

Status: Fixed (was: Untriaged)

Sign in to add a comment