New issue
Advanced search Search tips

Issue 668304 link

Starred by 1 user
Status: Fixed
Owner:
wjmaclean@chromium.org
Closed: Feb 2018
Cc:
lazyboy@chromium.org
lfg@chromium.org
wjmaclean@chromium.org
mcnee@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

"AppViewTests/AppViewTest.KillGuestCommunicatingWithWrongAppView/0" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Nov 23 2016 
"AppViewTests/AppViewTest.KillGuestCommunicatingWithWrongAppView/0" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 3 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyTAsSBUZsYWtlIkFBcHBWaWV3VGVzdHMvQXBwVmlld1Rlc3QuS2lsbEd1ZXN0Q29tbXVuaWNhdGluZ1dpdGhXcm9uZ0FwcFZpZXcvMAw.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs

Comment 1 by lukasza@chromium.org, Nov 24 2016

Components: Internals>Plugins
Labels: OS-Linux
Owner: wjmaclean@chromium.org
wjmaclean@, could you please take a look and route it to the right owner?  I've temporarily assigned to you based on chrome/browser/apps/guest_view/OWNERS.

FWIW, the try-flakes above reports that the test timed out on 3 linux_chromium_chromeos_rel_ng builds.

I'll go ahead and put together a CL to disable the test above on Linux.

Comment 2 by lukasza@chromium.org, Nov 24 2016

Cc: lazyboy@chromium.org
CL to disable the flaky test is in CQ: https://codereview.chromium.org/2527823002.  It is probably okay to remove this bug from the sheriff queue after this CL lands.

Comment 3 by lukasza@chromium.org, Nov 24 2016

Status: Assigned (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 24 2016 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/250f56bcc10f8e063bfca47090e0ba31497cc023

commit 250f56bcc10f8e063bfca47090e0ba31497cc023
Author: lukasza <lukasza@chromium.org>
Date: Thu Nov 24 17:02:49 2016

Disable flaky KillGuestCommunicatingWithWrongAppView on Linux.

BUG= 668304 
TBR=wjmaclean@chromium.org, lazyboy@chromium.org

Review-Url: https://codereview.chromium.org/2527823002
Cr-Commit-Position: refs/heads/master@{#434352}

[modify] https://crrev.com/250f56bcc10f8e063bfca47090e0ba31497cc023/chrome/browser/apps/guest_view/app_view_browsertest.cc

Comment 5 by magjed@chromium.org, Nov 28 2016

Labels: -Sheriff-Chromium
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 12 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae562c46b262f3c68dbb067299ac2d9e6be96ce

commit 0ae562c46b262f3c68dbb067299ac2d9e6be96ce
Author: Kevin McNee <mcnee@chromium.org>
Date: Mon Feb 12 21:57:06 2018

Remove BrowserPlugin parameterization of AppViewTests.

AppViewTests now only run for the GuestViewCrossProcessFrames
enabled case.

Tests that were disabled for flaking in the BrowserPlugin case are
reenabled.

Bug: 533069,  810935 ,  794490 ,  668304 
Change-Id: Ied54ca2fdafec1c15b7b68f3e8da1617c9d63a73
Reviewed-on: https://chromium-review.googlesource.com/913715
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536203}
[modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/chrome/browser/apps/guest_view/app_view_browsertest.cc
[modify] https://crrev.com/0ae562c46b262f3c68dbb067299ac2d9e6be96ce/testing/buildbot/filters/mojo.fyi.mash.browser_tests.filter

Comment 7 by mcnee@chromium.org, Feb 12 2018

Components: Platform>Apps>BrowserTag
Status: Fixed (was: Assigned)
AppViewTests now only test the OOPIF implementation.
►

Sign in to add a comment