New issue
Advanced search Search tips

Issue 668272 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 681951
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Synced scroll offset should be rounded consistently with scroll snap.

Project Member Reported by flackr@chromium.org, Nov 23 2016

Issue description

In ScrollTree::PullDeltaForMainThread we used to floor the scroll offset which led to  issue 663291  on desktop when blink would draw the main frame using the floored offset but cc would snap the scroll to the nearest pixel (See TransformTree::UpdateSnapping). I resolved this for the common case by rounding instead, but there are cases where this won't be correct.

If there are transforms, or the device scale factor is not 1, rounding may not be the closest scroll offset to the snapped position. We should know the scroll snap in the scroll tree so that we can apply the same snapping when sending the position back to blink.
 
Owner: smcgruer@chromium.org
Cc: flackr@chromium.org
I was unable to reproduce across a range of --force-device-scale-factor=x.y on http://output.jsbin.com/somobu/quiet . Do we have a known reproduction case?

Comment 4 by flackr@chromium.org, Jan 18 2017

Mergedinto: 681951
Status: Duplicate (was: Assigned)
This was assuming that the original CL stuck, but since we had to revert this is really just a part of issue 681951 as has been pointed out there.

Sign in to add a comment