New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668268 link

Starred by 2 users
Status: Fixed
Owner:
capn@chromium.org
Closed: Jun 2017
Cc:
█ krasin@chromium.org
sugoi@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

https://codereview.chromium.org/2528483002/ broke ClangToTLinuxUBSanVptr bot

Project Member Reported by thakis@chromium.org, Nov 23 2016 
FAILED: swiftshader_unittests 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings -fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -fuse-ld=gold -B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads -Wl,--thread-count=4 -pthread -m64 -Werror -Wl,-O1 -Wl,--gc-sections --sysroot=../../build/linux/debian_wheezy_amd64-sysroot -L/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu -L/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -Wl,-rpath-link=/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu -L/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -Wl,-rpath-link=/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6 -L/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -Wl,-rpath-link=/b/c/b/ClangToTLinuxUBSanVptr/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib -fsanitize=vptr -fsanitize-coverage=edge -Wl,-rpath-link=. -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/. -Wl,-rpath-link=. -Wl,-u_sanitizer_options_link_helper -fsanitize=vptr -fsanitize-coverage=edge -o "./swiftshader_unittests" -Wl,--start-group @"./swiftshader_unittests.rsp" swiftshader/libEGL.so swiftshader/libGLESv2.so -Wl,--end-group  -ldl -lrt 
swiftshader/libEGL.so: error: undefined reference to 'typeinfo for egl::Image'
swiftshader/libGLESv2.so: error: undefined reference to 'typeinfo for llvm::GEPOperator'
swiftshader/libGLESv2.so: error: undefined reference to 'typeinfo for llvm::Operator'
swiftshader/libGLESv2.so: error: undefined reference to 'typeinfo for llvm::PossiblyExactOperator'
swiftshader/libGLESv2.so: error: undefined reference to 'typeinfo for llvm::OverflowingBinaryOperator'
swiftshader/libGLESv2.so: error: undefined reference to 'typeinfo for llvm::TargetIntrinsicInfo'


(i hope swiftshader doesn't rely on rtti?)

Probably best to revert for now?

(krasin, do we have some ubsan label?)

Comment 3 by krasin@chromium.org, Nov 23 2016 

hi Nico,

thank you for spotting this (I was deep into profiling Clang and didn't look for the bots).

No, we don't have a ubsan label. At least not yet.

Comment 4 by sugoi@chromium.org, Nov 23 2016 

Yeah, I'll revert for now and investigate tomorrow.

Comment 5 by sugoi@chromium.org, Nov 23 2016 

Just FYI, nothing in SwiftShader relies on RTTI. Maybe I forgot to disable RTTI explicitly for swiftshaser_unittests in the BUILD.gn file.

Comment 7 by senorblanco@chromium.org, Nov 28 2016

Status: Assigned (was: Untriaged)

Comment 8 by capn@chromium.org, Jun 14 2017

Owner: capn@chromium.org
Status: Fixed (was: Assigned)
swiftshader_unittests builds, runs, and passes with is_ubsan_vptr now.
►

Sign in to add a comment