ec: llvm produces errors when CONFIG_HOSTCMD_ALIGNED is not defined |
|||||||||||||||
Issue descriptioncurrently boards have to manually select CONFIG_HOSTCMD_ALIGNED. this shouldn't be needed -- the default should be to turn it on for arches that typically require aligned loads for natural sizes (e.g. arm & aarch64) and to default it to off for the rest. and then we can strip most boards of it (like reverting https://chromium-review.googlesource.com/413108).
,
Dec 15 2016
Found same issue on nyan_big. @shawnn, Can you check all arm/aarch64 boards that need this?
,
Dec 15 2016
,
Dec 15 2016
I will look into the issue of llvm throwing errors when CONFIG_HOSTCMD_ALIGNED is not defined. manojgupta@, can you provide information on how to setup your build environment?
,
Dec 15 2016
Sorry, didn't mean to remove vpalatin@.
,
Dec 15 2016
This seems like an auto-complete bug. Sorry.
,
Dec 15 2016
,
Dec 15 2016
Here are the steps to reproduce.
Please run these in ~/trunk/src/scripts
1. emerge llvm with llvm-next option.
$ USE="llvm-next" sudo emerge llvm clang
Next step has to be repeated per board.
2. Setup llvm profile for build and build ec-utils
$ ./setup_board --board $BOARD --force --profile=llvm && emerge-${BOARD} ec-utils
,
Dec 15 2016
Oak board also has the same issue (and presumably most other arm/aarch64 boards).
,
Dec 15 2016
Bumping to P2.
,
Dec 15 2016
Did not intend to remove laszio@. Adding him back. (Hitting probably same auto-complete bug in #6)
,
Dec 17 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/ec/+/c6c5a4467467b546c25e1f73a4f4fa2c630b62c6 commit c6c5a4467467b546c25e1f73a4f4fa2c630b62c6 Author: Shawn Nematbakhsh <shawnn@chromium.org> Date: Thu Dec 15 22:02:27 2016 util/ectool: Fix llvm compiler errors BUG= chromium:668259 BRANCH=None TEST=Manual on samus (w/ gcc-built ectool). Verify 'ectool pause_in_s5 [on|off]' followed by 'ectool pause_in_s5' reflects the new updated state. Verify 'ectool --name=cros_pd flashpd 0 1 ec.RW.bin' succeeds to flash valid zinger RW image. Also verify `emerge-nyan_big ec-utils` succeeds w/ new llvm toolchain. Change-Id: Ibe83ee0fc0b2e6f535ed822603f438ed62350d29 Signed-off-by: Shawn Nematbakhsh <shawnn@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/419797 Commit-Ready: Shawn N <shawnn@chromium.org> Tested-by: Shawn N <shawnn@chromium.org> Reviewed-by: Manoj Gupta <manojgupta@chromium.org> Reviewed-by: Randall Spangler <rspangler@chromium.org> [modify] https://crrev.com/c6c5a4467467b546c25e1f73a4f4fa2c630b62c6/util/ectool.c
,
Jan 3 2017
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Aug 3 2017
Closing. Please reopen it if its not fixed. Thanks! |
|||||||||||||||
►
Sign in to add a comment |
|||||||||||||||
Comment 1 by sha...@chromium.org
, Nov 23 2016