New issue
Advanced search Search tips

Issue 668257 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2016-12-07
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Global "let" variable doesn't update within function

Reported by qxzcr...@gmail.com, Nov 23 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/54.0.2840.99 Safari/537.36

Steps to reproduce the problem:
1. Open the attached index.html (with script.js accessible of course)
2. Press "P" a few times to toggle the "fancy" flag
3. Observe how the values in the two functions get "out of sync"

What is the expected behavior?
Both functions should report the same value of the "fancy" variable.

What went wrong?
The value reported by "frame" is consistent with the toggling, but the value in "autoShoot" seems to get stuck or lag behind.

Did this work before? N/A 

Chrome version: 54.0.2840.99  Channel: stable
OS Version: 10.0
Flash Version: Shockwave Flash 23.0 r0

See this question on StackOverflow for more info/debugging attempts:
http://stackoverflow.com/questions/40732294/js-global-let-variable-not-updating-in-function
 
index.html
198 bytes View Download
script.js
1.0 KB View Download
Labels: -Pri-2 M-54 Needs-Triage-M54 Pri-1

Comment 2 by kojii@chromium.org, Nov 24 2016

Components: -Blink Blink>JavaScript
Labels: Needs-Feedback
Thank you for the report.

I confirmed the two values are out of sync in Stable 54.0.2840.99, but not on Canary 57.0.2928.0. Could you mind to try Canary to see if it fixes your problem?

Comment 3 by kojii@chromium.org, Nov 24 2016

NextAction: 2016-12-07
Labels: -Type-Bug -Needs-Feedback hasbisect-per-revision OS-Linux OS-Mac Type-Bug-Regression
Owner: mstarzinger@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, Mac 10.11.6 and Ubuntu 14.04 using reported version #54.0.2840.99 but the same is not reproducible in the latest canary #57.0.2928.0.

Reverse Bisect Information:
=====================
Good build: 56.0.2906.0  Revision(428890)
Bad Build : 56.0.2905.0  Revision(428611)

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/1b37cd6a32a0205f2bc61dfc4b19609e2db6761a..db6cc02a443dbd2b485875583204d7c813f6335e

From the above change log possible CL that fixed this issue:

Review-Url: https://codereview.chromium.org/2453973004

mstarzinger@ - Could you please check and merge the fix to M54 if it is a valid canadidate.

Thanks...!!
Cc: bmeu...@chromium.org hablich@chromium.org
The CL in question cannot be merged back. It is a serious architectural replumbing of our compilation pipeline. But maybe there is a more targeted fix that we can identify to merge back. Needs investigation.
Status: Fixed (was: Assigned)
No backmerge happend, but M56 fixed the issue. Nothing actionable left here.

Sign in to add a comment