New issue
Advanced search Search tips

Issue 668238 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2016
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Introduce better monitoring for Android APK sizes

Project Member Reported by agrieve@chromium.org, Nov 23 2016

Issue description

From looking at historical apk size changes:
https://docs.google.com/spreadsheets/d/1GrRkszV7Oy5pVsaMb5Eb6s8izW9t4dElBxIH3iGq93o/edit

I'd like to introduce a new metric that should be monitored for apk size that:
1. Always considers the uncompressed dex / native lib size, and
2. Ignores fluctuations caused by strings changing and translation dumps.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/07a7037737a96effe5a08f56458246c45a7c1283

commit 07a7037737a96effe5a08f56458246c45a7c1283
Author: agrieve <agrieve@chromium.org>
Date: Wed Nov 23 22:04:31 2016

Report more apk size metrics in resource_sizes.py

Specifically, this adds:
*RESULT ChromePublic.apk_Specifics: main dex size= 5914088 bytes
*RESULT ChromePublic.apk_Specifics: secondary dex size= 5712 bytes
*RESULT ChromePublic.apk_Specifics: main lib size= 46557792 bytes
*RESULT ChromePublic.apk_Specifics: other lib size= 83540 bytes
*RESULT ChromePublic.apk_Specifics: normalized apk size= 70865792 bytes
*RESULT ChromePublic.apk_Specifics: file count= 2554 zip entries

This also adds a handy-for-local-testing flag: --no-output-dir, which
disables all metrics that rely on having an up-to-date build output
(allows script to be run on any .apk).

Finally, it includes .webp files along with .png files (wished this had just
been called "drawables" or something, but don't want to change the name now.

I've ensured that running the script before & after this change produces the
same existing measurements.

BUG= 668238 

Review-Url: https://codereview.chromium.org/2524033004
Cr-Commit-Position: refs/heads/master@{#434263}

[modify] https://crrev.com/07a7037737a96effe5a08f56458246c45a7c1283/build/android/resource_sizes.py

Status: Fixed (was: Started)

Sign in to add a comment