From discussion with qinmin@ on getting the pending notification presented.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/59651690714d5c1b475d60a796ca11db423038cd commit 59651690714d5c1b475d60a796ca11db423038cd Author: dougarnett <dougarnett@chromium.org> Date: Wed Nov 30 08:08:03 2016 [OfflinePages] Call NotifyInterrupted for pending requests BUG= 668231 Review-Url: https://codereview.chromium.org/2521353005 Cr-Commit-Position: refs/heads/master@{#435154} [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/download_notifying_observer.cc [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/download_notifying_observer.h [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/download_notifying_observer_unittest.cc [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/download_ui_item.h [modify] https://crrev.com/59651690714d5c1b475d60a796ca11db423038cd/components/offline_pages/downloads/offline_page_download_notifier.h
Your change meets the bar and is auto-approved for M56 (branch: 2924)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c78948c6b3058e73032c8991f6bf1e79c2abf119 commit c78948c6b3058e73032c8991f6bf1e79c2abf119 Author: Pete Williamson <petewil@chromium.org> Date: Wed Nov 30 22:20:25 2016 [OfflinePages] Call NotifyInterrupted for pending requests BUG= 668231 Review-Url: https://codereview.chromium.org/2521353005 Cr-Commit-Position: refs/heads/master@{#435154} (cherry picked from commit 59651690714d5c1b475d60a796ca11db423038cd) Review URL: https://codereview.chromium.org/2537373004 . Cr-Commit-Position: refs/branch-heads/2924@{#216} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/chrome/browser/android/offline_pages/downloads/offline_page_notification_bridge.cc [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/download_notifying_observer.cc [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/download_notifying_observer.h [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/download_notifying_observer_unittest.cc [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/download_ui_item.cc [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/download_ui_item.h [modify] https://crrev.com/c78948c6b3058e73032c8991f6bf1e79c2abf119/components/offline_pages/downloads/offline_page_download_notifier.h
Issue 670222 has been merged into this issue.
Comment 1 by bugdroid1@chromium.org
, Nov 30 2016