New issue
Advanced search Search tips

Issue 668223 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 3
Type: Feature

Blocked on:
issue angleproject:1826
issue 737813

Blocking:
issue 602688



Sign in to add a comment

Run the WebGL conformance tests against the passthrough command buffer

Project Member Reported by geoffl...@chromium.org, Nov 23 2016

Issue description

Update the bots to run the WebGL (1 and eventually 2) conformance tests against the passthrough command buffer.  Add another expectation token so that passthrough specific expectations can be added.
 
Components: Blink>WebGL
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 29 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c

commit f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c
Author: geofflang <geofflang@chromium.org>
Date: Tue Nov 29 03:52:10 2016

Implement GetTranslatedShaderSource in the passthrough cmd decoder.

Many WebGL tests use this function.

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2532543002
Cr-Commit-Position: refs/heads/master@{#434877}

[modify] https://crrev.com/f0cfd74ce448fa4ecef7c9b57ac4897dceea5b2c/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_doers.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e

commit 774e87a5a2ecea722c2d03b14c6a1f20f404ab7e
Author: geofflang <geofflang@chromium.org>
Date: Mon Dec 05 16:29:01 2016

Run the WebGL conformance tests with the passthrough command decoder.

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2529713002
Cr-Commit-Position: refs/heads/master@{#436316}

[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/content/browser/gpu/gpu_internals_ui.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/content/browser/gpu/gpu_process_host.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/content/test/gpu/gpu_tests/gpu_test_expectations.py
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/content/test/gpu/gpu_tests/webgl_conformance_expectations_unittest.py
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/config/gpu_info.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/config/gpu_info.h
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/config/gpu_info_collector.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/common/gpu_info.mojom
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/common/gpu_info_struct_traits.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/common/gpu_info_struct_traits.h
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/common/gpu_param_traits_macros.h
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/common/struct_traits_unittest.cc
[modify] https://crrev.com/774e87a5a2ecea722c2d03b14c6a1f20f404ab7e/gpu/ipc/service/gpu_init.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 5 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4fa641c03547bb016fe128563d541764f0b1d599

commit 4fa641c03547bb016fe128563d541764f0b1d599
Author: geofflang <geofflang@chromium.org>
Date: Mon Dec 05 22:28:02 2016

Run the WebGL conformance tests with the passthrough command decoder.

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2553773002
Cr-Commit-Position: refs/heads/master@{#436427}

[modify] https://crrev.com/4fa641c03547bb016fe128563d541764f0b1d599/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/4fa641c03547bb016fe128563d541764f0b1d599/gpu/command_buffer/service/gles2_cmd_decoder_passthrough.cc
[modify] https://crrev.com/4fa641c03547bb016fe128563d541764f0b1d599/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c185d6030e450ab59c11473a679642351d071dec

commit c185d6030e450ab59c11473a679642351d071dec
Author: geofflang <geofflang@chromium.org>
Date: Tue Dec 06 21:42:44 2016

Supress WebGL test failures in the passthrough cmd buffer.

TBR=zmo@chromium.org
NOTRY=true

BUG= angleproject:1652 
BUG= 668223 
BUG= 671713 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2555033002
Cr-Commit-Position: refs/heads/master@{#436743}

[modify] https://crrev.com/c185d6030e450ab59c11473a679642351d071dec/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 6 by bugdroid1@chromium.org, Dec 6 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6de1888592c14b089c90c14356f5f90f0b78663d

commit 6de1888592c14b089c90c14356f5f90f0b78663d
Author: geofflang <geofflang@chromium.org>
Date: Tue Dec 06 22:12:11 2016

Enumerate WebGL extension test expectations for the passthrough cmd decoder.

The AMD R5 230 bot appears to have issues parsing the wildcard
expectations.  Try enumerating them.

TBR=zmo@chromium.org
NOTRY=true

BUG= angleproject:1652 
BUG= 668223 
BUG= 671713 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2552973003
Cr-Commit-Position: refs/heads/master@{#436758}

[modify] https://crrev.com/6de1888592c14b089c90c14356f5f90f0b78663d/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 7 by bugdroid1@chromium.org, Dec 7 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/03707c6b39b3dd765abb41a766c2d5a90ef6d652

commit 03707c6b39b3dd765abb41a766c2d5a90ef6d652
Author: geofflang <geofflang@chromium.org>
Date: Wed Dec 07 17:20:54 2016

Supress WebGL framebuffer-state-restoration failures in the passthrough cmd buffer.

TBR=zmo@chromium.org

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2562453002
Cr-Commit-Position: refs/heads/master@{#436990}

[modify] https://crrev.com/03707c6b39b3dd765abb41a766c2d5a90ef6d652/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 9 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9038bcb2f30582773c59986e9f6c42e656b7679d

commit 9038bcb2f30582773c59986e9f6c42e656b7679d
Author: geofflang <geofflang@chromium.org>
Date: Thu Dec 08 22:35:38 2016

Roll ANGLE b5e997f..dceacf5

https://chromium.googlesource.com/angle/angle.git/+log/b5e997f..dceacf5

BUG= 668028 , 668223 , chromium:661857 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2562813002
Cr-Commit-Position: refs/heads/master@{#437368}

[modify] https://crrev.com/9038bcb2f30582773c59986e9f6c42e656b7679d/DEPS

Project Member

Comment 10 by bugdroid1@chromium.org, Dec 12 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/cc507aa0efca2cae35ddc257092e5ceacb7570c9

commit cc507aa0efca2cae35ddc257092e5ceacb7570c9
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Dec 12 15:09:52 2016

Make the NPOT extension requestable. Fix NPOT validation in CopyTexImage.

BUG=angleproject:1523
BUG= 668223 
TEST=conformance/more/functions/copyTexImage2DBadArgs.html

Change-Id: I5fbf4f99fa941c356ecb57d67dd47a33741ce189
Reviewed-on: https://chromium-review.googlesource.com/418944
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/cc507aa0efca2cae35ddc257092e5ceacb7570c9/src/libANGLE/Caps.cpp
[modify] https://crrev.com/cc507aa0efca2cae35ddc257092e5ceacb7570c9/src/libANGLE/validationES.h
[modify] https://crrev.com/cc507aa0efca2cae35ddc257092e5ceacb7570c9/src/libANGLE/validationES2.cpp
[modify] https://crrev.com/cc507aa0efca2cae35ddc257092e5ceacb7570c9/src/libANGLE/validationES.cpp

Project Member

Comment 11 by bugdroid1@chromium.org, Dec 13 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d398b797dbcd4e88c229f0ba535198c087e15c2b

commit d398b797dbcd4e88c229f0ba535198c087e15c2b
Author: qiankun.miao <qiankun.miao@intel.com>
Date: Tue Dec 13 14:16:12 2016

Roll ANGLE d023939..c31b741

https://chromium.googlesource.com/angle/angle.git/+log/d023939..c31b741

BUG= 308366 ,  672380 ,  668028 ,  668223 , angleproject:1523,  angleproject:523 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2567173003
Cr-Commit-Position: refs/heads/master@{#438161}

[modify] https://crrev.com/d398b797dbcd4e88c229f0ba535198c087e15c2b/DEPS

Project Member

Comment 12 by bugdroid1@chromium.org, Dec 17 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/178234d4c943ba92d9e8d7c9a6fb38daa9e19071

commit 178234d4c943ba92d9e8d7c9a6fb38daa9e19071
Author: cwallez <cwallez@chromium.org>
Date: Sat Dec 17 01:05:58 2016

gles2_cmd_decoder_passthrough: Handle Tex[Sub]Image[2/3]D with empty shm

BUG= chromium:668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2587583002
Cr-Commit-Position: refs/heads/master@{#439270}

[modify] https://crrev.com/178234d4c943ba92d9e8d7c9a6fb38daa9e19071/gpu/command_buffer/service/gles2_cmd_decoder_passthrough_handlers.cc

Project Member

Comment 13 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/a8ccb95b2ef7e683614e4fc0a7c7c589cb3f2780

commit a8ccb95b2ef7e683614e4fc0a7c7c589cb3f2780
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Dec 16 20:12:57 2016

FormatString: avoid an UB when we need to grow the buffer

A va_list is undefined after it has been used by vsnprtinf. This was
causing crashes in the GL backend when the driver was returning big
info logs.

BUG= chromium:668223 

Change-Id: I444194ecce2846960c8a27f20f322f7099c651e5
Reviewed-on: https://chromium-review.googlesource.com/421271
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/a8ccb95b2ef7e683614e4fc0a7c7c589cb3f2780/src/common/angleutils.cpp

Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/7b91d0c1098306920fe4cdabb4de1b0645c633e3

commit 7b91d0c1098306920fe4cdabb4de1b0645c633e3
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Dec 16 19:46:26 2016

OpenGL: implement GL_ANGLE_translated_shader_source

BUG= chromium:668223 

Change-Id: I2068370f3e6963f297d0cb6545c40abf84d543ce
Reviewed-on: https://chromium-review.googlesource.com/421092
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/7b91d0c1098306920fe4cdabb4de1b0645c633e3/src/libANGLE/renderer/gl/renderergl_utils.cpp
[modify] https://crrev.com/7b91d0c1098306920fe4cdabb4de1b0645c633e3/src/libANGLE/renderer/gl/ShaderGL.cpp

Project Member

Comment 15 by bugdroid1@chromium.org, Dec 19 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3c90ed6bee1d57c8014462a5487246b502d5a8c6

commit 3c90ed6bee1d57c8014462a5487246b502d5a8c6
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Dec 16 21:19:28 2016

Implement the WebGL restriction on reading from missing attachments

BUG=angleproject:1523
BUG= chromium:668223 

Change-Id: I2dffa3c92dd32e384d3b3109084420650ca7f795
Reviewed-on: https://chromium-review.googlesource.com/421113
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/3c90ed6bee1d57c8014462a5487246b502d5a8c6/src/libANGLE/validationES.cpp

Project Member

Comment 16 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19fa73af253fb8af1199767812814eb2c3f98295

commit 19fa73af253fb8af1199767812814eb2c3f98295
Author: jmadill <jmadill@chromium.org>
Date: Tue Dec 20 00:51:59 2016

Roll ANGLE d967122..37ee8a6

https://chromium.googlesource.com/angle/angle.git/+log/d967122..37ee8a6

BUG= chromium:668223 

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2580313003
Cr-Commit-Position: refs/heads/master@{#439642}

[modify] https://crrev.com/19fa73af253fb8af1199767812814eb2c3f98295/DEPS

Project Member

Comment 18 by bugdroid1@chromium.org, Dec 20 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b5de482ad9cc882bf3ef9a73f3d75953a3350c44

commit b5de482ad9cc882bf3ef9a73f3d75953a3350c44
Author: jmadill <jmadill@chromium.org>
Date: Tue Dec 20 23:15:24 2016

Roll ANGLE f047097..d901983

https://chromium.googlesource.com/angle/angle.git/+log/f047097..d901983

BUG=None,chromium:668223,chromium:674143

TBR=cwallez@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2589343002
Cr-Commit-Position: refs/heads/master@{#439916}

[modify] https://crrev.com/b5de482ad9cc882bf3ef9a73f3d75953a3350c44/DEPS

Project Member

Comment 20 by bugdroid1@chromium.org, Dec 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f8438beb74dd3443e928c2e53082dbde81ca1900

commit f8438beb74dd3443e928c2e53082dbde81ca1900
Author: jmadill <jmadill@chromium.org>
Date: Fri Dec 23 16:29:06 2016

Roll ANGLE b8a580a..d5fe352

https://chromium.googlesource.com/angle/angle.git/+log/b8a580a..d5fe352

BUG= 676333 , 676689 , 672719 , 668223 , 630498 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2606473002
Cr-Commit-Position: refs/heads/master@{#440636}

[modify] https://crrev.com/f8438beb74dd3443e928c2e53082dbde81ca1900/DEPS

Project Member

Comment 21 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/53905cc1c8e0471b9699343a97f941c9cc5d80a8

commit 53905cc1c8e0471b9699343a97f941c9cc5d80a8
Author: geofflang <geofflang@chromium.org>
Date: Thu Jan 12 17:09:14 2017

Supress failures on the passthrough command buffer with Intel.

TBR=zmo@chromium.org

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2620133005
Cr-Commit-Position: refs/heads/master@{#443268}

[modify] https://crrev.com/53905cc1c8e0471b9699343a97f941c9cc5d80a8/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 22 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bf1c346a7c2967e70d05d2c93f1d33775482bff

commit 1bf1c346a7c2967e70d05d2c93f1d33775482bff
Author: geofflang <geofflang@chromium.org>
Date: Fri Jan 13 22:39:15 2017

Use --disable-es3-apis when running WebGL tests on the passthrough cmd decoder.

Chrome always creates ES3 contexts which cause some WebGL validation
failures.  Disable ES3 contexts so that WebGL 1 testing works as expected
until the GL bindings are refactored.

BUG= 668223 
BUG= 671217 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2621163007
Cr-Commit-Position: refs/heads/master@{#443705}

[modify] https://crrev.com/1bf1c346a7c2967e70d05d2c93f1d33775482bff/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/1bf1c346a7c2967e70d05d2c93f1d33775482bff/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/1bf1c346a7c2967e70d05d2c93f1d33775482bff/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 23 by bugdroid1@chromium.org, Jan 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/3f6d4dffa248c656cd56eeb8984fb7128b1b14b2

commit 3f6d4dffa248c656cd56eeb8984fb7128b1b14b2
Author: Corentin Wallez <cwallez@chromium.org>
Date: Mon Jan 30 23:04:36 2017

WebGLCompatibility implement and add tests for section 6.4

The checks for VertexAttribPointer were already implemented in a
previous patch, so we only add the checks for DrawElements.

BUG=angleproject:1523
BUG= chromium:668223 

Change-Id: I5da55f9a7e7479627099c7f77618353a63b75a8e
Reviewed-on: https://chromium-review.googlesource.com/434958
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>

[modify] https://crrev.com/3f6d4dffa248c656cd56eeb8984fb7128b1b14b2/src/tests/gl_tests/DrawElementsTest.cpp
[modify] https://crrev.com/3f6d4dffa248c656cd56eeb8984fb7128b1b14b2/src/tests/gl_tests/WebGLCompatibilityTest.cpp
[modify] https://crrev.com/3f6d4dffa248c656cd56eeb8984fb7128b1b14b2/src/libANGLE/validationES.cpp

Project Member

Comment 24 by bugdroid1@chromium.org, Feb 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/0844f2db017f42f50105e85fb7e7acfdc62ddca9

commit 0844f2db017f42f50105e85fb7e7acfdc62ddca9
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Feb 01 23:16:53 2017

WebGLCompatibility: add tests for OOB in DrawElements' index buffer

Also add a small fix for a WebGL test where DrawElements with a count
of 0 should skip OOB checks.

BUG=angleproject:1523
BUG= chromium:668223 

Change-Id: I67fbe939f6c8b925551b658b6178dbbae982df89
Reviewed-on: https://chromium-review.googlesource.com/435279
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/0844f2db017f42f50105e85fb7e7acfdc62ddca9/src/tests/gl_tests/WebGLCompatibilityTest.cpp
[modify] https://crrev.com/0844f2db017f42f50105e85fb7e7acfdc62ddca9/src/libANGLE/validationES.cpp

Project Member

Comment 25 by bugdroid1@chromium.org, Feb 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d9e2d2a37375e9aba8f2e3f33e0ed7548b85ac

commit f2d9e2d2a37375e9aba8f2e3f33e0ed7548b85ac
Author: fjhenigman <fjhenigman@chromium.org>
Date: Thu Feb 02 22:46:53 2017

Roll ANGLE ccab69d..ea20d62

https://chromium.googlesource.com/angle/angle.git/+log/ccab69d..ea20d62

BUG= chromium:668223 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2670143003
Cr-Commit-Position: refs/heads/master@{#447866}

[modify] https://crrev.com/f2d9e2d2a37375e9aba8f2e3f33e0ed7548b85ac/DEPS

Blockedon: angleproject:1826
Project Member

Comment 27 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37a2606c39140427064a529c9c5c16c1afdb676c

commit 37a2606c39140427064a529c9c5c16c1afdb676c
Author: geofflang <geofflang@chromium.org>
Date: Mon Mar 06 23:20:27 2017

Test WebGL with the passthrough command decoder on Linux.

TBR=kbr@chromium.org

BUG= 668223 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2709613012
Cr-Commit-Position: refs/heads/master@{#454994}

[modify] https://crrev.com/37a2606c39140427064a529c9c5c16c1afdb676c/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/37a2606c39140427064a529c9c5c16c1afdb676c/content/test/gpu/gpu_tests/webgl_conformance_expectations.py
[modify] https://crrev.com/37a2606c39140427064a529c9c5c16c1afdb676c/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 28 by bugdroid1@chromium.org, Mar 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94d4131d288b6c9d29f2eb33026a7e182f8d8bbc

commit 94d4131d288b6c9d29f2eb33026a7e182f8d8bbc
Author: geofflang <geofflang@chromium.org>
Date: Tue Mar 07 01:52:19 2017

Re-generate GPU bot json.

TBR=kbr@chromium.org
NOTRY=true

BUG= 668223 

Review-Url: https://codereview.chromium.org/2737623004
Cr-Commit-Position: refs/heads/master@{#455022}

[modify] https://crrev.com/94d4131d288b6c9d29f2eb33026a7e182f8d8bbc/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 29 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/fe9306a8e5bb6a8d52368e8e7b8e92f3bc7e77d4

commit fe9306a8e5bb6a8d52368e8e7b8e92f3bc7e77d4
Author: Corentin Wallez <cwallez@chromium.org>
Date: Thu Mar 09 02:07:28 2017

WebGLCompatibility: Add test for "negative" offset in DrawElements

BUG=angleproject:1523
BUG= chromium:668223 

Change-Id: I2d21c15b53fa204b3cb2b0be849cfe91ca63046b
Reviewed-on: https://chromium-review.googlesource.com/435884
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Jamie Madill <jmadill@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/fe9306a8e5bb6a8d52368e8e7b8e92f3bc7e77d4/src/tests/gl_tests/WebGLCompatibilityTest.cpp
[modify] https://crrev.com/fe9306a8e5bb6a8d52368e8e7b8e92f3bc7e77d4/src/libANGLE/validationES.cpp

Project Member

Comment 30 by bugdroid1@chromium.org, Mar 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5cea42bb7e2b04527e13a02a7441e7226f44e318

commit 5cea42bb7e2b04527e13a02a7441e7226f44e318
Author: ynovikov <ynovikov@chromium.org>
Date: Thu Mar 09 21:14:27 2017

Roll ANGLE 05356e3..6445ddf

https://chromium.googlesource.com/angle/angle.git/+log/05356e3..6445ddf

BUG= chromium:668223 

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2743553004
Cr-Commit-Position: refs/heads/master@{#455863}

[modify] https://crrev.com/5cea42bb7e2b04527e13a02a7441e7226f44e318/DEPS

Project Member

Comment 33 by bugdroid1@chromium.org, Mar 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2275661a8cf3507ad5b48faf6bff55682ce305a8

commit 2275661a8cf3507ad5b48faf6bff55682ce305a8
Author: cwallez <cwallez@chromium.org>
Date: Thu Mar 30 16:52:22 2017

Roll ANGLE 795e757..fe48632

https://chromium.googlesource.com/angle/angle.git/+log/795e757..fe48632

BUG= chromium:668223 

TBR=geofflang@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Merge branch 'master' of https://chromium.googlesource.com/chromium/src

Revert "Reland "Add enable_ipc_logging build argument (patchset #2 id:20001 of https://codereview.chromium.org/2770653002/ )""

This reverts commit b39d83360c64113ff17e64169c49e1a83329b61e.

Review-Url: https://codereview.chromium.org/2781403002
Cr-Commit-Position: refs/heads/master@{#460796}

[modify] https://crrev.com/2275661a8cf3507ad5b48faf6bff55682ce305a8/DEPS

Project Member

Comment 34 by bugdroid1@chromium.org, Jun 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/527670475d874c4d8f69e74775812ab948e05567

commit 527670475d874c4d8f69e74775812ab948e05567
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jun 15 15:38:09 2017

Run the WebGL2 tests with D3D11 passthrough on the GPU FYI bots.

BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5666b515e4a489947233b05ce2e8a21de5b39a54
Reviewed-on: https://chromium-review.googlesource.com/533795
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#479713}
[modify] https://crrev.com/527670475d874c4d8f69e74775812ab948e05567/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/527670475d874c4d8f69e74775812ab948e05567/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/527670475d874c4d8f69e74775812ab948e05567/testing/buildbot/chromium.gpu.fyi.json

Project Member

Comment 35 by bugdroid1@chromium.org, Jun 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc2db90843670b66ff8af08e3a4ed58efb540c90

commit bc2db90843670b66ff8af08e3a4ed58efb540c90
Author: Geoff Lang <geofflang@chromium.org>
Date: Fri Jun 16 18:06:48 2017

Update WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ia246d0275cb1efc5eb3ffa8c6316d9a3e254c551
Reviewed-on: https://chromium-review.googlesource.com/538085
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#480099}
[modify] https://crrev.com/bc2db90843670b66ff8af08e3a4ed58efb540c90/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Comment 36 by kbr@chromium.org, Jun 29 2017

Blockedon: 737813
Project Member

Comment 37 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4002f02934aae5a770a331cd66122fdcfbf91120

commit 4002f02934aae5a770a331cd66122fdcfbf91120
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jul 04 17:04:43 2017

Update the WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG=602688
BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic670f4a79adffe377d77dad79856f6aea9394746
Reviewed-on: https://chromium-review.googlesource.com/558677
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484132}
[modify] https://crrev.com/4002f02934aae5a770a331cd66122fdcfbf91120/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 38 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8820cf155326cb6c4d7fab2c94fc4f0b4ce483ff

commit 8820cf155326cb6c4d7fab2c94fc4f0b4ce483ff
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jul 04 19:44:34 2017

Update the WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I3e87b2a0a2e18c52978b11159f4159b4f3b2ea67
Reviewed-on: https://chromium-review.googlesource.com/559007
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484150}
[modify] https://crrev.com/8820cf155326cb6c4d7fab2c94fc4f0b4ce483ff/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 39 by bugdroid1@chromium.org, Jul 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a2ea034686149648ecfc52f32b5d44b1e57a844

commit 8a2ea034686149648ecfc52f32b5d44b1e57a844
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jul 04 19:51:49 2017

Roll ANGLE f0be43f..e145def

https://chromium.googlesource.com/angle/angle.git/+log/f0be43f..e145def

BUG= chromium:738281 

TBR=jmadill@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Merge branch 'master' of https://chromium.googlesource.com/chromium/src


Update the WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG= 668223 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Idd68c32bf0ff93b23ef2a532f5f2bab743e8271f
Reviewed-on: https://chromium-review.googlesource.com/558610
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484151}
[modify] https://crrev.com/8a2ea034686149648ecfc52f32b5d44b1e57a844/DEPS

Project Member

Comment 40 by bugdroid1@chromium.org, Jul 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/041bc8660d3eeb6988505c9593e7b56d2a7a8ed9

commit 041bc8660d3eeb6988505c9593e7b56d2a7a8ed9
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jul 10 21:03:15 2017

Update the WebGL expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org

BUG= 668223 

Change-Id: I3eeffe7cb4d7165fbe2fffea67fb144e7ebf6a37
Reviewed-on: https://chromium-review.googlesource.com/565111
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#485382}
[modify] https://crrev.com/041bc8660d3eeb6988505c9593e7b56d2a7a8ed9/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/041bc8660d3eeb6988505c9593e7b56d2a7a8ed9/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Comment 41 by kbr@chromium.org, Jul 13 2017

deqp/functional/gles3/shaderstruct.html is still failing on Win7/NVIDIA:
https://luci-milo.appspot.com/buildbot/chromium.gpu.fyi/Win7%20Release%20%28NVIDIA%29/30770

Re-suppressing this failure in https://chromium-review.googlesource.com/c/569456/ .

Project Member

Comment 42 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03e88f993d7e9035ff889e66b7287439ee99b08

commit b03e88f993d7e9035ff889e66b7287439ee99b08
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Jul 13 03:07:54 2017

Re-suppress one failure on the pass-through cmd decoder.

deqp/functional/gles3/shaderstruct.html is still failing on
Win7/NVIDIA.

BUG= 668223 
TBR=geofflang@chromium.org
NOTRY=true

Change-Id: Ib689a88c08e94114d947c4ca8e3890bc71508f56
Reviewed-on: https://chromium-review.googlesource.com/569456
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486245}
[modify] https://crrev.com/b03e88f993d7e9035ff889e66b7287439ee99b08/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 43 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/982d9727cc417161751ea9bdac2a95443cea25b8

commit 982d9727cc417161751ea9bdac2a95443cea25b8
Author: Geoff Lang <geofflang@chromium.org>
Date: Thu Jul 13 18:35:43 2017

Update WebGL expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG= 668223 

Change-Id: Ib4e0e2993c285b7edfa9e443d63fdefdcd28986d
Reviewed-on: https://chromium-review.googlesource.com/570668
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486446}
[modify] https://crrev.com/982d9727cc417161751ea9bdac2a95443cea25b8/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/982d9727cc417161751ea9bdac2a95443cea25b8/content/test/gpu/gpu_tests/webgl_conformance_expectations.py

Project Member

Comment 44 by bugdroid1@chromium.org, Jul 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df5364b96644f19a9c4f43ce0fe2cddbc17ac7f7

commit df5364b96644f19a9c4f43ce0fe2cddbc17ac7f7
Author: Geoff Lang <geofflang@chromium.org>
Date: Mon Jul 17 19:41:43 2017

Update the WebGL2 conformance expectations for the passthrough cmd decoder.

TBR=zmo@chromium.org
NOTRY=true

BUG= 668223 

Change-Id: Ibf09100c74fa4ec2c8e7738f7f977153f1816c69
Reviewed-on: https://chromium-review.googlesource.com/574929
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487198}
[modify] https://crrev.com/df5364b96644f19a9c4f43ce0fe2cddbc17ac7f7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py

Project Member

Comment 45 by bugdroid1@chromium.org, Jul 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e67f7c46cba145f93519c421d7ea517314b467d7

commit e67f7c46cba145f93519c421d7ea517314b467d7
Author: Geoff Lang <geofflang@chromium.org>
Date: Tue Jul 18 15:56:55 2017

Run the WebGL2 ANGLE tests using the passthrough command decoder on Linux.

BUG= 668223 

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Change-Id: Icaa5c0f7cf3130770d89b34eb46afbfd8379bee9
Reviewed-on: https://chromium-review.googlesource.com/574688
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487488}
[modify] https://crrev.com/e67f7c46cba145f93519c421d7ea517314b467d7/content/test/gpu/generate_buildbot_json.py
[modify] https://crrev.com/e67f7c46cba145f93519c421d7ea517314b467d7/content/test/gpu/gpu_tests/webgl2_conformance_expectations.py
[modify] https://crrev.com/e67f7c46cba145f93519c421d7ea517314b467d7/testing/buildbot/chromium.gpu.fyi.json

Status: Fixed (was: Started)

Sign in to add a comment