New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668217 link

Starred by 2 users

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug

Blocked on:
issue 875130
issue 875092
issue 875129



Sign in to add a comment

HWATest failing on Lollipop Phone Tester

Project Member Reported by mariakho...@chromium.org, Nov 23 2016

Issue description

org.chromium.chrome.browser.hardware_acceleration.ToastHWATest#testDownloadingToast
org.chromium.chrome.browser.hardware_acceleration.ToastHWATest#testNoRenderThread
org.chromium.chrome.browser.hardware_acceleration.ToastHWATest#testOpenedInBackgroundToast
org.chromium.chrome.browser.hardware_acceleration.ToastHWATest#testToastNoAcceleration


From logcat:

Device(06e3a0f000eb84e3) 11-23 00:20:29.689 14278 14366 F chromium: [FATAL:field_trial.cc(676)] Check failed: global_->create_trials_from_command_line_called_. 
Device(06e3a0f000eb84e3) 11-23 00:20:29.689 14278 14366 F chromium: 
Device(06e3a0f000eb84e3) 11-23 00:20:29.689 14278 14366 F libc    : Fatal signal 6 (SIGABRT), code -6 in tid 14366 (Chrome_InProcGp)
Device(06e3a0f000eb84e3) 11-23 00:20:29.740 14278 14278 I art     : Rejecting re-init on previously-failed class java.lang.Class<org.chromium.content.browser.FloatingA
ctionModeCallback>
Device(06e3a0f000eb84e3) 11-23 00:20:29.741 14278 14278 I art     : Rejecting re-init on previously-failed class java.lang.Class<org.chromium.content.browser.FloatingA
ctionModeCallback>
Device(06e3a0f000eb84e3) 11-23 00:20:29.775 14278 14353 D cr_ChildProcLauncher: [ChildProcessLauncher.java:741] Setting up connection to process: slot=0
Device(06e3a0f000eb84e3) 11-23 00:20:29.784 14314 14330 I cr_LibraryLoader: Using linker: org.chromium.base.library_loader.LegacyLinker
Device(06e3a0f000eb84e3) 11-23 00:20:29.786 14314 14348 W linker  : libchromium_android_linker.so: unused DT entry: type 0x6ffffffe arg 0x41f8
Device(06e3a0f000eb84e3) 11-23 00:20:29.786 14314 14348 W linker  : libchromium_android_linker.so: unused DT entry: type 0x6fffffff arg 0x3
Device(06e3a0f000eb84e3) 11-23 00:20:29.787 14278 14353 D cr_ChildProcLauncher: [ChildProcessLauncher.java:779] on connect callback, pid=14314 context=-1618333392 call
backType=2
Device(06e3a0f000eb84e3) 11-23 00:20:29.793   189   189 I DEBUG   : *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
Device(06e3a0f000eb84e3) 11-23 00:20:29.793   189   189 I DEBUG   : Build fingerprint: 'google/hammerhead/hammerhead:5.1.1/LMY48I/2074855:userdebug/dev-keys'
Device(06e3a0f000eb84e3) 11-23 00:20:29.793   189   189 I DEBUG   : Revision: '11'
Device(06e3a0f000eb84e3) 11-23 00:20:29.793   189   189 I DEBUG   : ABI: 'arm'
Device(06e3a0f000eb84e3) 11-23 00:20:29.794   189   189 I DEBUG   : pid: 14278, tid: 14366, name: Chrome_InProcGp  >>> org.chromium.chrome <<<
Device(06e3a0f000eb84e3) 11-23 00:20:29.794   189   189 I DEBUG   : signal 6 (SIGABRT), code -6 (SI_TKILL), fault addr --------
Device(06e3a0f000eb84e3) 11-23 00:20:29.805 14314 14348 W cr_LibraryLoader: Low-memory device: shared RELROs used in all processes
Device(06e3a0f000eb84e3) 11-23 00:20:29.806 14314 14348 I cr_LibraryLoader: Loading chrome
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   : Abort message: '[FATAL:field_trial.cc(676)] Check failed: global_->create_trials_from_command_line_
called_. 
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   : 
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   : '
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   :     r0 00000000  r1 0000381e  r2 00000006  r3 00000000
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   :     r4 9c8d1db8  r5 00000006  r6 00000000  r7 0000010c
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   :     r8 9c8d13e8  r9 9c8d185c  sl 00000000  fp 0000000a
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   :     ip 0000381e  sp 9c8d1270  lr b6e6f3c5  pc b6e9323c  cpsr 600b0010
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   : 
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   : backtrace:
Device(06e3a0f000eb84e3) 11-23 00:20:29.817   189   189 I DEBUG   :     #00 pc 0003b23c  /system/lib/libc.so (tgkill+12)
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #01 pc 000173c1  /system/lib/libc.so (pthread_kill+52)
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #02 pc 00017fd3  /system/lib/libc.so (raise+10)
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #03 pc 00014795  /system/lib/libc.so (__libc_android_abort+36)
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #04 pc 00012f44  /system/lib/libc.so (abort+4)
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #05 pc 000fd2e7  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #06 pc 00111c8d  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #07 pc 0011f201  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.818   189   189 I DEBUG   :     #08 pc 01f6fa71  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.819   189   189 I DEBUG   :     #09 pc 02b77a45  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.819   189   189 I DEBUG   :     #10 pc 02b7b919  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.819   189   189 I DEBUG   :     #11 pc 00155a79  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.820   189   189 I DEBUG   :     #12 pc 00150505  /data/app/org.chromium.chrome-1/lib/arm/libchrome.so
Device(06e3a0f000eb84e3) 11-23 00:20:29.820   189   189 I DEBUG   :     #13 pc 00016baf  /system/lib/libc.so (__pthread_start(void*)+30)
Device(06e3a0f000eb84e3) 11-23 00:20:29.820   189   189 I DEBUG   :     #14 pc 00014af3  /system/lib/libc.so (__start_thread+6)
Device(06e3a0f000eb84e3) 11-23 00:20:29.887 14314 14348 I cr_LibraryLoader: Time to load native libraries: 82 ms (timestamps 7197-7279)
Device(06e3a0f000eb84e3) 11-23 00:20:29.887 14314 14348 I cr_LibraryLoader: Expected native library version number "57.0.2929.0", actual native library version number
 
Cc: asvitk...@chromium.org
Suspect https://codereview.chromium.org/2504163005/ is the culprit.
Will take a look. Probably just need to change the tests to make sure they initialize field trial list.
Cc: -asvitk...@chromium.org mariakho...@chromium.org
Owner: asvitk...@chromium.org
Working on a fix now. Hoping can just land today without having to revert the CL.

(There's a dependent CL already landed and would be bad to have to revert the chain.)
Here's the symbolized stack:

Using toolchain from: /usr/local/google/code/clankium/src/third_party/android_tools/ndk/toolchains/arm-linux-androideabi-4.9/prebuilt/linux-x86_64/bin/arm-linux-androideabi-
[FATAL:field_trial.cc(676)] Check failed: global_->create_trials_from_command_line_called_. 

Stack Trace:
  RELADDR   FUNCTION                                                                                                                                                                                    FILE:LINE
  0009923b  logging::LogMessage::~LogMessage()                                                                                                                                                          /usr/local/google/code/clankium/src/base/logging.cc:532
  000a69e3  base::FieldTrialList::GetInitiallyActiveFieldTrials(base::CommandLine const&, std::__ndk1::vector<base::FieldTrial::ActiveGroup, std::__ndk1::allocator<base::FieldTrial::ActiveGroup> >*)  /usr/local/google/code/clankium/src/base/metrics/field_trial.cc:676
  0028c4df  chrome_variations::ChildProcessFieldTrialSyncer::InitFieldTrialObserving(base::CommandLine const&)                                                                                          /usr/local/google/code/clankium/src/chrome/common/variations/child_process_field_trial_syncer.cc:41
  0028c481  ChromeContentGpuClient::Initialize(base::FieldTrialList::Observer*)                                                                                                                         /usr/local/google/code/clankium/src/chrome/gpu/chrome_content_gpu_client.cc:72
  004aab2f  content::InProcessGpuThread::Init()                                                                                                                                                         /usr/local/google/code/clankium/src/content/gpu/in_process_gpu_thread.cc:66
  000dd619  base::Thread::ThreadMain()                                                                                                                                                                  /usr/local/google/code/clankium/src/base/threading/thread.cc:322
  000d8065  ThreadFunc                                                                                                                                                                                  /usr/local/google/code/clankium/src/base/threading/platform_thread_posix.cc:71
  00046abf  <unknown>                                                                                                                                                                                   /system/lib/libc.so

Ah, so this happens because Android runs the GPU thread code in the same process as the browser.

So we actually need to *not* run the ChildProcessFieldTrialSyncer code in that case, since they're in the same process.
GPU runs in the same process as browser on low-end Android devices. On high-end devices, they are in separate processes. This test specifically forces the "low-end" mode.
Status: Started (was: Assigned)
Makes sense - testing a fix now.
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbe6717b654cfd51f6eec2e12b90a91eb5186775

commit cbe6717b654cfd51f6eec2e12b90a91eb5186775
Author: asvitkine <asvitkine@chromium.org>
Date: Wed Nov 23 23:51:22 2016

Fix field trial DCHECK when gpu process is in-process.

The DCHECK was introduced by my CL here:
https://codereview.chromium.org/2504163005/

In fact, it caught the problem that we were running
the field trial syncer code even when the GPU process
was part of the browser process, which is unneeded.
This change fixes that by not running that code in
that case.

BUG=668217

Review-Url: https://codereview.chromium.org/2525973003
Cr-Commit-Position: refs/heads/master@{#434286}

[modify] https://crrev.com/cbe6717b654cfd51f6eec2e12b90a91eb5186775/chrome/gpu/chrome_content_gpu_client.cc

Status: Fixed (was: Started)
Tests no longer failing with latest run:

https://uberchromegw.corp.google.com/i/chromium.android/builders/Lollipop%20Phone%20Tester/builds/8126

(There's an unrelated org.chromium.blimp.app.auth.RetryingTokenSourceTest_testFailedTokenSource failure however.) 
Cc: asvitk...@chromium.org
Labels: -Pri-3 Pri-1
Owner: ian...@chromium.org
Status: Assigned (was: Fixed)
testDownloadingToast is flaking again:
http://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/8146
http://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/8155

junit.framework.AssertionFailedError: Activity did not regain focus.
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:74)
	at org.chromium.content.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:89)
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectOpenContextMenuItem(ContextMenuUtils.java:165)
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItemByJs(ContextMenuUtils.java:118)
	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItem(ContextMenuUtils.java:99)
	at org.chromium.chrome.browser.hardware_acceleration.ToastHWATest.testDownloadingToast(ToastHWATest.java:79)
	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:726)
	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
Owner: dskiba@chromium.org
Oops, s/ianwen/dskiba/
I'm also seeing flakes for #testOpenedInBackgroundToast on the Marshmallow Tablet Tester:

https://build.chromium.org/p/chromium.android/builders/Marshmallow%20Tablet%20Tester/builds/7638

C 1426.116s Main  [FAIL] org.chromium.chrome.browser.hardware_acceleration.ToastHWATest#testOpenedInBackgroundToast:
C 1426.116s Main  junit.framework.AssertionFailedError: '2131690266' is not visible
C 1426.116s Main  	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectOpenContextMenuItem(ContextMenuUtils.java:152)
C 1426.116s Main  	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItemByJs(ContextMenuUtils.java:116)
C 1426.116s Main  	at org.chromium.chrome.test.util.browser.contextmenu.ContextMenuUtils.selectContextMenuItem(ContextMenuUtils.java:97)
C 1426.116s Main  	at org.chromium.chrome.browser.hardware_acceleration.ToastHWATest.testOpenedInBackgroundToast(ToastHWATest.java:119)
C 1426.117s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C 1426.117s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C 1426.117s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C 1426.117s Main  	at org.chromium.chrome.test.ChromeActivityTestCaseBase.runTest(ChromeActivityTestCaseBase.java:752)
C 1426.117s Main  	at org.chromium.base.test.BaseTestResult.runParameterized(BaseTestResult.java:161)
C 1426.117s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:124)
C 1426.117s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C 1426.117s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C 1426.117s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C 1426.117s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

Comment 15 Deleted

Is it possible to force bot to take a screenshot when this happens?
Owner: ----
Status: Available (was: Assigned)
Status: WontFix (was: Available)
Cc: yolandyan@chromium.org
Components: Test>Android
Labels: Sheriff-Chromium
Owner: dskiba@chromium.org
Status: Assigned (was: WontFix)
Disabling several tests (bot-detected, see newly linked bugs for details) in https://crrev.com/c/1179665.

dskiba: Could you please investigate or help to find a recent owner?
Blockedon: 875129
Blockedon: 875092
Blockedon: 875130
Project Member

Comment 23 by bugdroid1@chromium.org, Aug 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2db0839d6a455786e586c14cfcffa02fc96af665

commit 2db0839d6a455786e586c14cfcffa02fc96af665
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Aug 17 10:06:09 2018

[Flaky][Android] Mark several ToastHWATests flaky

Theses tests were known to be flaky for a while and this is not the
first time they are disabled for unknown reasons. Reopened and linked
bugs with details.

TBR=dskiba@chromium.org, tedchoc@chromium.org

Bug: 668217, 875130,  875129 ,  875092 
Change-Id: Ifee7d29bbdf28349aea3837a6b1a2525484c6e9a
Reviewed-on: https://chromium-review.googlesource.com/1179665
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584010}
[modify] https://crrev.com/2db0839d6a455786e586c14cfcffa02fc96af665/chrome/android/javatests/src/org/chromium/chrome/browser/hardware_acceleration/ToastHWATest.java

Labels: -Sheriff-Chromium
Cc: dskiba@chromium.org
Labels: Sheriff-Chromium
Owner: ----
Status: Available (was: Assigned)
Hi, please find someone else as I'm not working on Clank anymore.
Labels: -Sheriff-Chromium
Owner: tedc...@chromium.org
tedchoc: do you know who may be a good POC? The directory hasn't had any changes in almost 9 months and you're in the next owners file up. Thanks!

Sign in to add a comment