PPAPI build fails on AArch64 Linux
Reported by
ossy.sze...@gmail.com,
Nov 23 2016
|
||||
Issue description
UserAgent: Mozilla/5.0 (Windows NT 5.1; rv:50.0) Gecko/20100101 Firefox/50.0
Steps to reproduce the problem:
build log:
In file included from ../ppapi/tests/test_struct_sizes.c:26:
../ppapi/tests/arch_dependent_sizes_32.h:14:1: error: '_COMPILE_ASSERT_FAILED_The_type_named_GLintptr_is_not_4_bytes_wide' declared as an array with a negative size
PP_COMPILE_ASSERT_SIZE_IN_BYTES(GLintptr, 4);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../ppapi/c/pp_macros.h:77:53: note: expanded from macro 'PP_COMPILE_ASSERT_SIZE_IN_BYTES'
#define PP_COMPILE_ASSERT_SIZE_IN_BYTES(NAME, SIZE) \
^
../ppapi/c/pp_macros.h:69:13: note: expanded from macro '\
PP_COMPILE_ASSERT_SIZE_IN_BYTES_IMPL'
_bytes_wide[(sizeof(CTYPENAME) == SIZE) ? 1 : -1]; }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
...
What is the expected behavior?
What went wrong?
build
Did this work before? N/A
Chrome version: Channel: n/a
OS Version:
Flash Version:
The problem is that ppapi/tests/test_struct_sizes.c
includes arch_dependent_sizes_32.h instead of arch_dependent_sizes_64.h on AArch64.
,
Nov 23 2016
,
Nov 29 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/801a47add3317b8870cd067726dab3fd533ecca9 commit 801a47add3317b8870cd067726dab3fd533ecca9 Author: ossy.szeged <ossy.szeged@gmail.com> Date: Tue Nov 29 17:26:25 2016 Fix the PPAPI build on AArch64. BUG= 668208 Review-Url: https://codereview.chromium.org/2525993002 Cr-Commit-Position: refs/heads/master@{#435022} [modify] https://crrev.com/801a47add3317b8870cd067726dab3fd533ecca9/ppapi/tests/test_struct_sizes.c
,
Dec 21 2016
,
Jan 2 2017
The fix landed, it can be closed. (but I don't have the power to do it.)
,
Jan 12 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by ossy.sze...@gmail.com
, Nov 23 2016