New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668201 link

Starred by 3 users
Status: Fixed
Owner:
█ olka@chromium.org
OOO Dec 22 - Jan 8
Closed: Dec 2016
Cc:
sande...@chromium.org
crouleau@chromium.org
solenberg@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Add NullSink info to chrome://media-internals

Project Member Reported by crouleau@chromium.org, Nov 23 2016 
Since https://codereview.chromium.org/2413653002, when audio authorization fails it causes the video to play back muted.

We should add an entry to chrome://media-internals to log when this happens so that it is easy to tell what happened without having to look at chrome debug logs.

sandersd@ is currently working on improvements to chrome://media-internals, so he should be able to point you to the code to use and help with questions.

Comment 1 by olka@chromium.org, Nov 30 2016

Status: Started (was: Assigned)

Comment 2 by olka@chromium.org, Dec 9 2016

Status: Fixed (was: Started)
https://codereview.chromium.org/2533443002/
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 13 2016

Labels: merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d73a9f728dd8d305feadb1a1febc75c40e13b3

commit a8d73a9f728dd8d305feadb1a1febc75c40e13b3
Author: olka <olka@chromium.org>
Date: Tue Dec 13 12:03:39 2016

Fallback to null sink moved from WebMediaPlayer to WebAudioSourceProvider::Initialize(), so that we do it on media thread. UMA stats for AudioOutputDevice status and for fallbacks to null sink.

BUG= 668506 , 668201 ,663546, 626862 , 673291 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=dalecurtis@chromium.org,dcheng@chromium.org,holte@chromium.org
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2533443002
Cr-Commit-Position: refs/heads/master@{#436614}
(cherry picked from commit e4ba2ed8354d01411848143efbe8d17b41e1853b)

Review-Url: https://codereview.chromium.org/2569883003
Cr-Commit-Position: refs/branch-heads/2924@{#472}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/content/common/media/audio_messages.h
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/content/renderer/media/html_audio_element_capturer_source_unittest.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/audio/audio_output_device.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/audio/null_audio_sink.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/base/output_device_info.h
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/blink/webaudiosourceprovider_impl.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/blink/webaudiosourceprovider_impl.h
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/blink/webaudiosourceprovider_impl_unittest.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/a8d73a9f728dd8d305feadb1a1febc75c40e13b3/tools/metrics/histograms/histograms.xml
►

Sign in to add a comment