New issue
Advanced search Search tips

Issue 668196 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

content_shell.log and bots

Reported by j...@nottheoilrig.com, Nov 23 2016

Issue description

What do the bots do with content_shell.log?

 Issue 665515  caused a major outage [1].
Here's an example of the jobs that were failing [2].
content_shell.log probably contained a message that might have helped identify the problem:

> [...:ERROR:fontconfig_util_linux.cc(88)] You are missing /usr/share/fonts/opentype/ipafont-gothic/ipag.ttf. Try re-running build/install-build-deps.sh. Also see https://chromium.googlesource.com/chromium/src/+/master/docs/layout_tests_linux.md

but the build logs contain only:

> 16:53:48.821 13886 Failed to start the content_shell process: 
> 16:53:48.822 13886 content_shell took too long to startup.
> 16:53:48.857 13886 worker/0 http/tests/accessibility/slow-document-load.html crashed, (no stderr)
> 16:53:48.866 13806 [1/43088] http/tests/accessibility/slow-document-load.html failed unexpectedly (content_shell crashed [pid=13894])
> 16:53:48.858 13886 worker/0 killing primary driver
> 16:53:48.858 13886 worker/0 killing secondary driver
> 16:53:48.858 13886 worker/0 http/tests/accessibility/slow-document-load.html failed:
> 16:53:48.858 13886 worker/0  content_shell crashed [pid=13894]

I haven't found the content_shell.log contents anywhere in the logs [3].

This change [4] switched content_shell from logging to stderr to logging to content_shell.log, when called with --dump-render-tree.
 Issue 145147  changed it to always log to content_shell.log.
 Issue 453252  renamed --dump-render-tree to --run-layout-test.

[1] https://groups.google.com/a/chromium.org/d/msg/chromium-dev/6nG_HiEzroU/yZPPBIjcAwAJ
[2] https://luci-milo.appspot.com/buildbot/chromium.webkit/WebKit%20Linux%20Trusty/19980
[3] https://bugs.chromium.org/p/chromium/issues/detail?id=665515#c25
[4] https://chromiumcodereview.appspot.com/10636052
 
I took a stab at a solution [1].

[1] https://codereview.chromium.org/2525033003

Comment 2 by ajha@chromium.org, Nov 24 2016

Components: Build
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ca8dc086777939dbf144e40feddd6e5d4957b32b

commit ca8dc086777939dbf144e40feddd6e5d4957b32b
Author: jack <jack@nottheoilrig.com>
Date: Fri Dec 02 16:50:37 2016

Display content_shell error messages.

When run with --run-layout-tests, this change switches content_shell
logging back to stderr, instead of logging to content_shell.log.
The layout tests can then capture and display any messages.

BUG= 668196 

Review-Url: https://codereview.chromium.org/2525033003
Cr-Commit-Position: refs/heads/master@{#435954}

[modify] https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 2 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1c680884cf397a504043c63f7ccb906823857d1

commit d1c680884cf397a504043c63f7ccb906823857d1
Author: jbroman <jbroman@chromium.org>
Date: Fri Dec 02 19:04:39 2016

Revert of Display content_shell error messages. (patchset #2 id:20001 of https://codereview.chromium.org/2525033003/ )

Reason for revert:
Suspected of causing crashes in win_chromium_rel_ng runs.

e.g. https://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/342943/steps/webkit_tests%20%28with%20patch%29/logs/stdio

10:05:33.718 4648   [1202/100532.865:FATAL:sandbox_win.cc(789)] Check failed: base::FilePath(logging::GetLogFileFullPath()).IsAbsolute().
10:05:33.718 4648   Backtrace:
10:05:33.718 4648   	base::debug::StackTrace::StackTrace [0x01DB6877+23]
10:05:33.718 4648   	logging::LogMessage::~LogMessage [0x01D64C61+49]
10:05:33.718 4648   	content::StartSandboxedProcess [0x01012CE2+1101]
10:05:33.718 4648   	content::ChildProcessLauncher::Launch [0x01A3BB32+983]
10:05:33.718 4648   	Invoke< ?? :: ?? :: ?? ::Callback<void ,base::$00$00,enum content::BrowserThread::ID const &,int const &,ID::SandboxedProcessLauncherDelegate * const &,mojo::edk::ScopedPlatformHandle,base::CommandLine * const &> const &> [0x01A3B0CC+41]
10:05:33.718 4648   	??$RunImpl@ABQ6AXABV?$Callback@$$A6AX$$TVProcess@base@@H@Z$00$00@base@@W4ID@BrowserThread@content@@HPAVSandboxedProcessLauncherDelegate@5@VScopedPlatformHandle@edk@mojo@@PAVCommandLine@2@@ZABV?$tuple@V?$Callback@$$A6AX$$TVProcess@base@@H@Z$00$00@base@@W4I [0x01A3B190+53]
10:05:33.718 4648   	base::internal::Invoker<base::internal::BindState<void ,ZV12::nternal,ZV12::CommandLine *>,void __cdecl(void)>::Run [0x01A3BED8+22]
10:05:33.718 4648   	base::debug::TaskAnnotator::RunTask [0x01DE32FE+286]
10:05:33.718 4648   	base::MessageLoop::RunTask [0x01DA54EC+1228]
10:05:33.718 4648   	base::MessageLoop::DoWork [0x01DA4493+611]
10:05:33.718 4648   	base::MessagePumpDefault::Run [0x01DE518B+219]
10:05:33.718 4648   	base::MessageLoop::RunHandler [0x01DA5011+305]
10:05:33.718 4648   	base::RunLoop::Run [0x01DB66AA+122]
10:05:33.718 4648   	base::Thread::Run [0x01DA1B6D+173]
10:05:33.718 4648   	content::BrowserThreadImpl::ProcessLauncherThreadRun [0x01A1F71C+30]
10:05:33.718 4648   	content::BrowserThreadImpl::Run [0x01A1F860+222]
10:05:33.718 4648   	base::Thread::ThreadMain [0x01DA266E+622]
10:05:33.719 4648   	base::PlatformThread::Sleep [0x01D66982+290]
10:05:33.719 4648   	BaseThreadInitThunk [0x7538338A+18]
10:05:33.719 4648   	RtlInitializeExceptionChain [0x77359A02+99]
10:05:33.719 4648   	RtlInitializeExceptionChain [0x773599D5+54]

Original issue's description:
> Display content_shell error messages.
>
> When run with --run-layout-tests, this change switches content_shell
> logging back to stderr, instead of logging to content_shell.log.
> The layout tests can then capture and display any messages.
>
> BUG= 668196 
>
> Committed: https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b
> Cr-Commit-Position: refs/heads/master@{#435954}

TBR=dpranke@chromium.org,peter@chromium.org,jack@nottheoilrig.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 668196 

Review-Url: https://codereview.chromium.org/2548453004
Cr-Commit-Position: refs/heads/master@{#435985}

[modify] https://crrev.com/d1c680884cf397a504043c63f7ccb906823857d1/content/shell/app/shell_main_delegate.cc
[modify] https://crrev.com/d1c680884cf397a504043c63f7ccb906823857d1/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 9 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ca5ee2fde09bd2a3798e8edf0e3dd3d3fb5de87

commit 6ca5ee2fde09bd2a3798e8edf0e3dd3d3fb5de87
Author: jack <jack@nottheoilrig.com>
Date: Fri Dec 09 03:36:44 2016

Display content_shell error messages.

BUG= 668196 

Committed: https://crrev.com/ca8dc086777939dbf144e40feddd6e5d4957b32b
Review-Url: https://codereview.chromium.org/2525033003
Cr-Original-Commit-Position: refs/heads/master@{#435954}
Cr-Commit-Position: refs/heads/master@{#437453}

[modify] https://crrev.com/6ca5ee2fde09bd2a3798e8edf0e3dd3d3fb5de87/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/driver.py

Labels: TE-NeedsTriageHelp
Project Member

Comment 7 by sheriffbot@chromium.org, Feb 13 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment