New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668184 link

Starred by 0 users

Issue metadata

Status: Duplicate
Merged: issue 667786
Owner:
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

1% regression in memory.top_10_mobile at 432502:432530

Project Member Reported by nzolghadr@chromium.org, Nov 23 2016

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=668184

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICg6-mJrgoM


Bot(s) for this bug's original alert(s):

android-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Nov 23 2016

Cc: aber...@chromium.org
Owner: aber...@chromium.org

=== Auto-CCing suspected CL author aberent@chromium.org ===

Hi aberent@chromium.org, the bisect results pointed to your CL below as possibly
causing a regression. Please have a look at this info and see whether
your CL be related.


===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Implement Android key/value backup
Author  : aberent
Commit description:
  
This replaces our previous impmentation of (Dolly) Auto Backup.
Only the preferences needed to restore the user's signin atate
and sync state are backed up.

BUG= 661188 

Review-Url: https://codereview.chromium.org/2496693002
Cr-Commit-Position: refs/heads/master@{#432517}
Commit  : d56b7ec3e6e6c3236835414584f4205283beb218
Date    : Wed Nov 16 16:47:09 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@432501  18295467  165643   12  good
chromium@432516  18315520  214577   12  good
chromium@432517  18518221  131809   5   bad    <--
chromium@432518  18466560  251436   8   bad
chromium@432520  18499379  74946.7  5   bad
chromium@432523  18437120  57781.2  5   bad
chromium@432530  18441899  380259   12  bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 668184

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=https.www.google.co.uk.hl.en.q.science memory.top_10_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/foreground/https_www_google_co_uk_hl_en_q_science
Relative Change: 0.44%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2773
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995186319102540160


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5277105175134208

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!
Owner: nzolghadr@chromium.org
Seems highly unlikely. This CL should only be using a trivial amount of memory (a few pointers) while Chrome is running. Even during a backup (when most of the code is invoked) it shouldn't be using significant memory.
Project Member

Comment 6 by 42576172...@developer.gserviceaccount.com, Nov 24 2016

Mergedinto: 667786
Status: Duplicate (was: Untriaged)

===== BISECT JOB RESULTS =====
Status: completed


===== SUSPECTED CL(s) =====
Subject : Reland of Enable WebVR for non component build (patchset #1 id:1 of https://codereview.chromium.org/2505963003/ )
Author  : bshe
Commit description:
  
Reason for revert:
Hi Andrew.
It turns out that our UX review is blocked on this. We need it in canary build. I will revert your revert for now. And I will work with you tomorrow to figure out if there is a way to reduce dex size of gvr. There should be enough time to land/merge these improvements before it hits stable.
Anyway, let's talk tomorrow. Thanks!

Original issue's description:
> Revert of Enable WebVR for non component build (patchset #5 id:80001 of https://codereview.chromium.org/2502643002/ )
>
> Reason for revert:
> Reverting until dex size growth is understood.
>
> Original issue's description:
> > Enable Android WebVR for arm & arm64
> >
> > BUG=644785
> >
> > Committed: https://crrev.com/7e31a518a02e80fa167181be029691d41fadb898
> > Cr-Commit-Position: refs/heads/master@{#432489}
>
> TBR=bshe@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=644785
>
> Committed: https://crrev.com/19ef7689f208ee3222539bf0bb1d4054b2dbf780
> Cr-Commit-Position: refs/heads/master@{#432606}

TBR=agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=644785

Review-Url: https://codereview.chromium.org/2505313002
Cr-Commit-Position: refs/heads/master@{#432723}
Commit  : eabd2c4458bf716a84e060d3d80e3d931dfa69d7
Date    : Thu Nov 17 03:30:49 2016


===== TESTED REVISIONS =====
Revision         Mean      Std Dev  N   Good?
chromium@432043  18371328  533931   8   good
chromium@432438  18440448  626421   8   good
chromium@432635  18659328  594104   12  good
chromium@432685  18630827  910126   12  good
chromium@432710  18663424  779183   12  good
chromium@432722  18689024  1438834  18  good
chromium@432723  18971876  1010381  18  bad      <--
chromium@432724  19010987  713668   12  bad
chromium@432725  19018411  1111911  18  bad
chromium@432728  18900233  1119288  27  unknown
chromium@432729  19051558  1502710  27  bad
chromium@432734  18980295  968471   18  bad
chromium@432832  18976640  461092   8   bad

Bisect job ran on: android_nexus6_perf_bisect
Bug ID: 668184

Test Command: src/tools/perf/run_benchmark -v --browser=android-chromium --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.media.youtube system_health.memory_mobile
Test Metric: memory:chrome:all_processes:reported_by_os:system_memory:java_heap:proportional_resident_size_avg/browse_media/browse_media_youtube
Relative Change: 3.05%

Buildbot stdio: http://build.chromium.org/p/tryserver.chromium.perf/builders/android_nexus6_perf_bisect/builds/2777
Job details: https://chromeperf.appspot.com/buildbucket_job_status/8995178751220327888


Not what you expected? We'll investigate and get back to you!
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5773255636418560

| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Tests>AutoBisect.  Thank you!

Sign in to add a comment