InputMethodMusTest.DispatchKeyEvent is flakey |
||||||||
Issue descriptionRunning this test by itself more often then not deadlocks. This test connects to the test_ime_driver dispatches a key event and waits until input is received. This test is expecting the test_ime_driver to register itself as the current IMEDriver. Problem is, there is no guarantee by the time the key event is dispatched the test_ime_driver has completed registration. It should wait for that before it dispatches the key event.
,
Nov 30 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2edfc8753717dee68567dbb08f04e8623f1be65 commit c2edfc8753717dee68567dbb08f04e8623f1be65 Author: moshayedi <moshayedi@chromium.org> Date: Wed Nov 30 16:45:01 2016 IME for Mus: Fix InputMethodMusTest.DispatchKeyEvent's deadlock. What was happening was: - IMEServerImpl starts test_ime_driver, which registers itself to Mus. - InputMethodMusTests requests to start test_ime_driver, but before it starts, it connects to IMEServer, which creates a connection between client and the first test_ime_driver. - test_ime_driver starts for a 2nd time, which causes IMEServerImpl to drop the connection to the first test_ime_driver. This causes clients using the first test_ime_driver to hang. This fix: - Removes starting the test_ime_driver for a 2nd time. - Rejects drivers after first driver registers itself. BUG= 668181 Review-Url: https://codereview.chromium.org/2535403002 Cr-Commit-Position: refs/heads/master@{#435291} [modify] https://crrev.com/c2edfc8753717dee68567dbb08f04e8623f1be65/services/ui/ime/ime_server_impl.cc [modify] https://crrev.com/c2edfc8753717dee68567dbb08f04e8623f1be65/ui/views/mus/input_method_mus_unittest.cc
,
Nov 30 2016
,
Mar 4 2017
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Oct 14 2017
,
Jan 24 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by moshayedi@chromium.org
, Nov 29 2016