GetPagesMatchingQuery returns empty result before the model is loaded |
|||||
Issue descriptionVersion: ToT OS: Android Currently if we call GetPagesMatchingQuery() before offline_pages_model->is_loaded() == true, we get empty result. This is not a problem, since we can do the call on OfflinePageModelLoaded(), but all other methods inside the model seem to use RunWhenLoaded https://cs.chromium.org/chromium/src/components/offline_pages/offline_page_model_impl.cc?q=RunWhenLoaded&sq=package:chromium&l=375&dr=C so it seems a bit odd that GetPagesMatchingQuery. Is this intended?
,
Nov 23 2016
Do you need this for M56? Or can it be solved in M57 only?
,
Nov 23 2016
M57 only.
,
Nov 24 2016
,
Nov 28 2016
,
Nov 28 2016
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e3282abc2d498c63720bb7262bccf14013bd2484 commit e3282abc2d498c63720bb7262bccf14013bd2484 Author: fgorski <fgorski@chromium.org> Date: Mon Nov 28 21:49:31 2016 [Offline pages] Preventing GetPagesMatchingQuery from running before model is loaded * When making a function to get offline pages using query public, we missed making it run only when the model is loaded. This patch fixes that by deferring the actually execution after the model is loaded. BUG= 668174 Review-Url: https://codereview.chromium.org/2536573003 Cr-Commit-Position: refs/heads/master@{#434726} [modify] https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484/components/offline_pages/offline_page_model_impl.cc [modify] https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484/components/offline_pages/offline_page_model_impl.h [modify] https://crrev.com/e3282abc2d498c63720bb7262bccf14013bd2484/components/offline_pages/offline_page_model_impl_unittest.cc
,
Nov 28 2016
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by fgor...@chromium.org
, Nov 23 2016