Get rid of duplicate, fork of html5lib tests |
||||||
Issue descriptionUserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/602.2.14 (KHTML, like Gecko) Version/10.0.1 Safari/602.2.14 Steps to reproduce the problem: Look at third_party/WebKit//LayoutTests/html5lib and third_party/WebKit//LayoutTests/imported/wpt/html/syntax/parsing and notice we have two copies of all the html5lib tests What is the expected behavior? We have one copy What went wrong? We have two copies, and the one in third_party/WebKit/LayoutTests/html5lib has changes from upstream that don't match the spec with no issues filed on the spec. Did this work before? N/A Does this work in other browsers? Yes Chrome version: Channel: n/a OS Version: OS X 10.11.6 Flash Version: See https://chromium.googlesource.com/chromium/src.git/+log/master/third_party/WebKit/LayoutTests/html5lib/resources for changes to the tests, almost none of which have issues open on the spec, seemingly with us having chosen to deviate from the spec without telling anyone.
,
Nov 23 2016
,
Dec 12 2016
Thanks for reporting this. We need to go back through the history and see what parts of these changes need to be upstreamed. Some of the downstream changes look innocuous, eg testing our threaded parser. So this may need a bit of test reengineering too to use the upstream test data.
,
Dec 12 2016
https://github.com/html5lib/html5lib-tests/pull/67 got most of it upstreamed, and the only two changes in Blink since are restoring the <applet> parsing (which the removal of didn't land upstream, because the spec never dropped it), and removing the SVG viewTarget attribute (which wouldn't land upstream given the spec still requires it). So I think upstream is still in sync with spec-correct changes in Blink?
,
Dec 21 2016
https://github.com/whatwg/html/issues/2168 is a bug on the HTML spec in case things should change in the spec.
,
Aug 22 2017
Bulk disowning per sshruthi's email about bug triage best practices.
,
Aug 22
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue. Sorry for the inconvenience if the bug really should have been left as Available. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 23
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ligim...@chromium.org
, Nov 23 2016