New issue
Advanced search Search tips

Issue 668161 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression

Blocked on:
issue 706699



Sign in to add a comment

DevTools: unable to tab from Element Classes' TextPrompt to checkboxes for toggling classes

Reported by cont...@jaygeorge.co.uk, Nov 23 2016

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2926.0 Safari/537.36

Steps to reproduce the problem:
1. Open DevTools and inspect an element, with the DevTools Elements tab open 
2. Click the "Cls" button in the top left of the "styles" panel within Elements
3. Click into the "Add new class" input box then try to press "tab" to move to the class checkboxes

What is the expected behavior?
The first class checkbox should be focused. Pressing tab again should focus subsequent checkboxes

What went wrong?
Class checkboxes are not focusable

Did this work before? Yes A month or 2 ago

Chrome version: 57.0.2926.0  Channel: canary
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 24.0 r0

There was a similar issue I reported some time ago, which got fixed.

https://bugs.chromium.org/p/chromium/issues/detail?id=580199
 
I meant the Cls button in the top "right", NOT top "left".
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
Eric, could you please take a look?

Comment 4 by l...@chromium.org, Nov 23 2016

Labels: -Pri-2 Hotlist-Polish Pri-1
Thanks for the report, it would be good to have check this in our unit tests.

It looks like we are consuming tab events when we shouldn't because we expect an autocomplete box to be shown.

Comment 5 by l...@chromium.org, Dec 2 2016

Status: Started (was: Assigned)

Comment 6 by l...@chromium.org, Dec 6 2016

Cc: l...@chromium.org
Owner: einbinder@chromium.org
Status: Assigned (was: Started)
Summary: DevTools: unable to tab from Element Classes' TextPrompt to checkboxes for toggling classes (was: Toggling "element classes" checkboxes is not possible via keyboard)
Right now, TextPrompt's tabKeyPressed() returns false all the time.
Blockedon: 706699
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93cf8ced501ad85664fa80e69610621b69b6dd09

commit 93cf8ced501ad85664fa80e69610621b69b6dd09
Author: einbinder <einbinder@chromium.org>
Date: Fri Mar 31 05:51:59 2017

DevTools: Allow tabbing in and out of TextPrompt

TextPrompt was handling tab events even if there was no autocomplete.

BUG= 706699 ,  668161 

Review-Url: https://codereview.chromium.org/2786003002
Cr-Commit-Position: refs/heads/master@{#461052}

[modify] https://crrev.com/93cf8ced501ad85664fa80e69610621b69b6dd09/third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js

Status: Fixed (was: Assigned)

Sign in to add a comment