New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 668148 link

Starred by 1 user
Status: Fixed
Owner:
█ ackermanb@chromium.org
Last visit 28 days ago
Closed: Sep 10
Cc:
rdevlin....@chromium.org
msramek@chromium.org
bklmn@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

Extension pages should display a puzzle icon as default favicon

Project Member Reported by dullweber@chromium.org, Nov 23 2016 
When you create a bookmark for a page from an extension that didn't define a favicon, you get the default icon for a page. 
It would be great if the chrome-extension:// scheme could get a default favicon similar to the puzzle icon from the extension page.

The favicon is used in other places like content-settings as well and it would be a big improvement if it could be used to distinguish extensions from sites easier.

Example:
1. Install sample extension:
https://developer.chrome.com/extensions/examples/api/downloads/download_filename_controller.zip
2. Create bookmark for options.html page
Project Member

Comment 1 by sheriffbot@chromium.org, Nov 24 2017

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available. If you change it back, also remove the "Hotlist-Recharge-Cold" label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by lazyboy@chromium.org, Dec 1 2017

Labels: -Hotlist-Recharge-Cold Hotlist-GoodFirstBug
Status: Available (was: Untriaged)

Comment 3 by rdevlin....@chromium.org, Jul 11

Cc: bklmn@chromium.org
Owner: ackermanb@chromium.org
Status: Assigned (was: Available)
This seems like a good one for ackermanb@ to look into.  ackermanb@, ExtensionWebUI::GetFaviconForURL() is probably the best place to start looking.

bklmn@, quick question: do you have a preference between showing the extension puzzle piece and showing the "icon placeholder" we generate (which is a monochrome icon with the first letter of the name)?  I'd slightly lean towards the puzzle piece, but I don't have a strong preference.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/001a7f871bf716e6cacc59049bbed44276ad983b

commit 001a7f871bf716e6cacc59049bbed44276ad983b
Author: Benjamin Ackerman <ackermanb@chromium.org>
Date: Mon Sep 10 14:53:30 2018

[Extensions UI] Fallback to a placeholder favicon for extension pages.

Use a placeholder icon for the favicon on the chrome-extension:// pages
when the extension does not provide one.

Bug:  668148 
Change-Id: I3a523d459053aa956145839abee25c699f74f1c4
Reviewed-on: https://chromium-review.googlesource.com/1163292
Commit-Queue: Benjamin Ackerman <ackermanb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589908}
[modify] https://crrev.com/001a7f871bf716e6cacc59049bbed44276ad983b/chrome/browser/extensions/extension_web_ui.cc
[modify] https://crrev.com/001a7f871bf716e6cacc59049bbed44276ad983b/chrome/browser/extensions/extension_web_ui_unittest.cc

Comment 5 by ackermanb@chromium.org, Sep 10

Status: Fixed (was: Assigned)
►

Sign in to add a comment