New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668142 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 739103



Sign in to add a comment

QuickView/FileManagerBrowserTest is flaky

Project Member Reported by kolos@chromium.org, Nov 23 2016

Issue description

browser_tests on Ubuntu-12.04 failing on chromium.chromiumos/Linux ChromiumOS Tests (dbg)(1)

Type: build-failure

Builders failed on: 
- Linux ChromiumOS Tests (dbg)(1): 
  https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29



 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7d5b142ecbf74e3f186a99ac2c7a24222dc2cdc6

commit 7d5b142ecbf74e3f186a99ac2c7a24222dc2cdc6
Author: kolos <kolos@chromium.org>
Date: Wed Nov 23 14:45:09 2016

Disable QuickView/FileManagerBrowserTest

The test is flake. See the bug.

TBR=hirono@chromium.org, kinaba@chromium.org, fukino@chromium.org
BUG= 668142 

Review-Url: https://codereview.chromium.org/2524983002
Cr-Commit-Position: refs/heads/master@{#434164}

[modify] https://crrev.com/7d5b142ecbf74e3f186a99ac2c7a24222dc2cdc6/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc

Components: Platform>Apps>FileManager
Labels: -Sheriff-Chromium OS-Chrome Pri-2 Type-Bug
Summary: QuickView/FileManagerBrowserTest is flaky (was: QuickView/FileManagerBrowserTest is falky)
Thanks for disabling the test in #c1.  Since the test is disabled now, I think it should be okay to remove this bug from the sheriff queue.

Comment 3 by kinaba@chromium.org, Nov 24 2016

Owner: oka@chromium.org
+oka who looks to be the original author of the test.
https://codereview.chromium.org/2080613002

Comment 4 by tapted@chromium.org, Nov 25 2016

There's no link to the exact build that failed. But I suspect this failure is also related

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/322020/

Providers/FileManagerBrowserTest.Test/3

Fails like
Providers/FileManagerBrowserTest.Test/3 (run #1):
[ RUN      ] Providers/FileManagerBrowserTest.Test/3
/* snip */
[22117:22117:1124/183541:FATAL:extension_function.cc(469)] Check failed: !browser_client || browser_client->IsShuttingDown() || did_respond() || ignore_all_did_respond_for_testing_do_not_use. test.sendMessage
#0 0x0000032c4f9e base::debug::StackTrace::StackTrace()
#1 0x0000032dc4ca logging::LogMessage::~LogMessage()
#2 0x000002ddebd6 UIThreadExtensionFunction::~UIThreadExtensionFunction()
#3 0x000002eeee13 extensions::TestSendMessageFunction::~TestSendMessageFunction()
#4 0x00000137f275 file_manager::(anonymous namespace)::FileManagerTestListener::~FileManagerTestListener()
#5 0x00000137efb9 file_manager::FileManagerBrowserTestBase::RunTestMessageLoop()
#6 0x00000137e9e5 file_manager::FileManagerBrowserTestBase::StartTest()


Comment 5 by oka@chromium.org, Nov 29 2016

Status: Started (was: Available)

Comment 6 by battre@chromium.org, Nov 29 2016

I have filed  crbug.com/668680  for comment #4. I think that's different. oka@, please feel free to claim  bug 668680 .

Comment 7 by oka@chromium.org, Nov 30 2016

Status: Assigned (was: Started)
Blocking: 739103
Owner: tetsui@chromium.org
Status: Started (was: Assigned)
Cc: oka@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2908de779d1f322c368bba7eab39766e7b52a7a

commit c2908de779d1f322c368bba7eab39766e7b52a7a
Author: Tetsui Ohkubo <tetsui@chromium.org>
Date: Fri Jul 07 07:14:44 2017

Fix the flakiness and restore openQuickView test.

BUG= 668142 
TEST=out/Debug/browser_tests \
'--gtest_filter=QuickView/FileManagerBrowserTest.Test/0' \
--gtest_repeat=40

Change-Id: Ic326ef21c41281203cddfc8c43a552bebef57b35
Reviewed-on: https://chromium-review.googlesource.com/562905
Reviewed-by: Keigo Oka <oka@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#484850}
[modify] https://crrev.com/c2908de779d1f322c368bba7eab39766e7b52a7a/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/c2908de779d1f322c368bba7eab39766e7b52a7a/ui/file_manager/integration_tests/file_manager/quick_view.js

Status: Fixed (was: Started)

Comment 13 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment