New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668141 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 666647
issue 672012



Sign in to add a comment

Return |struct|s in PhysicalWebDataSource::GetMetadata()

Project Member Reported by vitaliii@chromium.org, Nov 23 2016

Issue description

Version: ToT
OS: Android

Currently GetMedata() returns |ListValue| with |DictionaryValue|s inside.
This may be inconvenient:

1) There is no static check that you provide to your clients what they expect;

2) You can easily break someone, such that it is visible to the users;

3) Clients have to do a lot of |DCHECKS|s;

4) In order to understand what is returned, one needs to go a long way up to Java code. 

Have you considered returning a vector of structs instead?
 
Summary: Return |struct|s in PhysicalWebDataSource::GetMetadata() (was: Returns |struct|s in PhysicalWebDataSource::GetMetadata() )
Blocking: 672012
Blocking: 666647
Status: Fixed (was: Untriaged)
Done by PW team in https://codereview.chromium.org/2561493002/.

Sign in to add a comment