New issue
Advanced search Search tips

Issue 668139 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Feature



Sign in to add a comment

Create browser test that checks protection of preferences used to define default search provider

Project Member Reported by a-...@yandex-team.ru, Nov 23 2016

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/53.0.2785.116 YaBrowser/16.10.0.2564 Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
Create browser test that checks protection of preferences that are used to define default search provider.
Currently where are tests that check protected prefs mechanism but no tests for preferences that are used in TemplateUrlService to store or override default search provider settings.

What is the expected behavior?

What went wrong?
 Not applicable

Did this work before? N/A 

Chrome version: 53.0.2785.116  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 23.0 r0
 
Components: Tests Tests>Missing
Labels: M-57

Comment 2 by hdodda@chromium.org, Nov 24 2016

Labels: TE-NeedsTriageHelp
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 8 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38416868dc6ab9b4ae6b56ec4006d601c47704f0

commit 38416868dc6ab9b4ae6b56ec4006d601c47704f0
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Thu Dec 08 08:40:13 2016

Added browser test for TemplateUrlService protected prefs

Create browser test that checks protection of preferences that are used
to define default search provider. Currently where are tests that check
protected prefs mechanism but no tests for preferences that are used in
TemplateUrlService to store or override default search provider
settings.

BUG= 668139 

R=pkasting@chromium.org, gab@chromium.org

Review-Url: https://codereview.chromium.org/2521823007
Cr-Commit-Position: refs/heads/master@{#437211}

[modify] https://crrev.com/38416868dc6ab9b4ae6b56ec4006d601c47704f0/chrome/browser/prefs/tracked/pref_hash_browsertest.cc

Fixed, can be closed.
Project Member

Comment 5 by sheriffbot@chromium.org, Feb 13 2018

Status: Archived (was: Unconfirmed)
Issue has not been modified or commented on in the last 365 days, please re-open or file a new bug if this is still an issue.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Archived)

Sign in to add a comment