New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 668136 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Nov 2016
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Mus should use InProcessContextProvider::SetUpdateVSyncParametersCallback

Project Member Reported by fsam...@chromium.org, Nov 23 2016

Issue description

Looks like I forgot to wire up DirectOutputSurface and DirectOutputSurfaceOzone to the vsync callback to update the vsync parameters on the BeginFrameSource. This bug tracks a fix.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 23 2016

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58b5a2252f651bc852b7afe57377e4f0f5a8bb91

commit 58b5a2252f651bc852b7afe57377e4f0f5a8bb91
Author: fsamuel <fsamuel@chromium.org>
Date: Wed Nov 23 23:50:24 2016

Mus: Fix Capabilities and Install SwapBuffersCompleted/VSync callbacks

DirectOutputSurface(Ozone) should be informed when a swap buffers is
completed or when vsync parameters are updated so that it can update the
compositor accordingly. We need to make sure that the callback is called on the Mus
compositor thread. InProcessCommandBuffer calls
these callbacks on the "origin" thread in this patch.

Furthermore, InProcessContextProvider was faking Capabilities instead of grabbing
them from InProcessContextProvider. This doesn't work on
ozone platforms.

BUG= 668136 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2529703002
Cr-Commit-Position: refs/heads/master@{#434285}

[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/cc/output/in_process_context_provider.cc
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/gpu/ipc/gl_in_process_context.cc
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/gpu/ipc/gl_in_process_context.h
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/gpu/ipc/in_process_command_buffer.cc
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/gpu/ipc/in_process_command_buffer.h
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/services/ui/surfaces/direct_output_surface.cc
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/services/ui/surfaces/direct_output_surface.h
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/services/ui/surfaces/direct_output_surface_ozone.cc
[modify] https://crrev.com/58b5a2252f651bc852b7afe57377e4f0f5a8bb91/services/ui/surfaces/direct_output_surface_ozone.h

Status: Fixed (was: Untriaged)

Sign in to add a comment